mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Onur Özkan" <work@onurozkan.dev>,
	rcu@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: <ojeda@kernel.org>, <boqun@kernel.org>, <gary@garyguo.net>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <aliceryhl@google.com>,
	<tmgross@umich.edu>, <dakr@kernel.org>, <peterz@infradead.org>,
	<fujita.tomonori@gmail.com>, <tamird@kernel.org>,
	<jiangshanlai@gmail.com>, <paulmck@kernel.org>,
	<josh@joshtriplett.org>, <rostedt@goodmis.org>,
	<mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v8 1/4] rust: helpers: add SRCU helpers
Date: Fri, 29 May 2026 12:58:17 +0100	[thread overview]
Message-ID: <DIV55HYTKCM3.23VXO47N90C9G@garyguo.net> (raw)
In-Reply-To: <20260529114449.112066-2-work@onurozkan.dev>

On Fri May 29, 2026 at 12:43 PM BST, Onur Özkan wrote:
> Add helper wrappers for SRCU functions that are exposed to Rust
> through generated bindings.
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> Signed-off-by: Onur Özkan <work@onurozkan.dev>
> ---
>  include/linux/srcu.h   |  5 +++++
>  rust/helpers/helpers.c |  1 +
>  rust/helpers/srcu.c    | 30 ++++++++++++++++++++++++++++++
>  3 files changed, 36 insertions(+)
>  create mode 100644 rust/helpers/srcu.c
>
> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 81b1938512d5..790a4ef713c0 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -57,6 +57,11 @@ int __init_srcu_struct_fast_updown(struct srcu_struct *ssp, const char *name,
>  #else /* #ifdef CONFIG_DEBUG_LOCK_ALLOC */
>  
>  int init_srcu_struct(struct srcu_struct *ssp);
> +static inline int __init_srcu_struct(struct srcu_struct *ssp, const char *name,
> +				     struct lock_class_key *key)
> +{
> +	return init_srcu_struct(ssp);
> +}


This looks like a different strategy than, say, how mutex handles lockdep. IMO
the way that mutex handles this is more clear.

If we follow the way mutex is handles this, the `init_srcu_struct` would always
create lock class key and forward to `__init_srcu_struct`, and
`__init_srcu_struct` is an inline function that either calls
`init_srcu_struct_lockdep` with all args, or discard name/key and forward to
`init_srcu_struct_mutex`.

This is beneficial because the usage flows one way. You don't have in one config
`init_srcu_struct` call `__init_srcu_struct` and have the opposite in another
config, which I think can be quite confusing.

Best,
Gary

>  #ifndef CONFIG_TINY_SRCU
>  int init_srcu_struct_fast(struct srcu_struct *ssp);
>  int init_srcu_struct_fast_updown(struct srcu_struct *ssp);
> diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
> index 625921e27dfb..f3562d3b3888 100644
> --- a/rust/helpers/helpers.c
> +++ b/rust/helpers/helpers.c
> @@ -88,6 +88,7 @@
>  #include "signal.c"
>  #include "slab.c"
>  #include "spinlock.c"
> +#include "srcu.c"
>  #include "sync.c"
>  #include "task.c"
>  #include "time.c"
> diff --git a/rust/helpers/srcu.c b/rust/helpers/srcu.c
> new file mode 100644
> index 000000000000..225b3bf9334a
> --- /dev/null
> +++ b/rust/helpers/srcu.c
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <linux/srcu.h>
> +
> +__rust_helper int rust_helper_init_srcu_struct_with_key(struct srcu_struct *ssp,
> +							const char *name,
> +							struct lock_class_key *key)
> +{
> +	return __init_srcu_struct(ssp, name, key);
> +}
> +
> +__rust_helper int rust_helper_srcu_read_lock(struct srcu_struct *ssp)
> +{
> +	return srcu_read_lock(ssp);
> +}
> +
> +__rust_helper void rust_helper_srcu_read_unlock(struct srcu_struct *ssp, int idx)
> +{
> +	srcu_read_unlock(ssp, idx);
> +}
> +
> +__rust_helper void rust_helper_srcu_barrier(struct srcu_struct *ssp)
> +{
> +	srcu_barrier(ssp);
> +}
> +
> +__rust_helper void rust_helper_synchronize_srcu_expedited(struct srcu_struct *ssp)
> +{
> +	synchronize_srcu_expedited(ssp);
> +}



  reply	other threads:[~2026-05-29 11:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 11:43 [PATCH v8 0/4] " Onur Özkan
2026-05-29 11:43 ` [PATCH v8 1/4] " Onur Özkan
2026-05-29 11:58   ` Gary Guo [this message]
2026-05-29 12:07     ` Onur Özkan
2026-05-29 12:16       ` Gary Guo
2026-05-29 12:30         ` Onur Özkan
2026-05-30 19:01         ` Paul E. McKenney
2026-05-30 19:04           ` Onur Özkan
2026-05-29 11:43 ` [PATCH v8 2/4] srcu: expose srcu_readers_active() Onur Özkan
2026-05-29 11:58   ` Gary Guo
2026-05-29 11:43 ` [PATCH v8 3/4] rust: sync: add SRCU abstraction Onur Özkan
2026-05-29 11:43 ` [PATCH v8 4/4] MAINTAINERS: add Rust SRCU files to SRCU entry Onur Özkan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIV55HYTKCM3.23VXO47N90C9G@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=fujita.tomonori@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®