From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70999377004 for ; Fri, 29 May 2026 16:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073155; cv=none; b=Bi+uttH49MICP+UaRO3++9F8+2MFwPA9RDwmf9rArsIQl/Hwbs3U4ouv91d6KZp4rHfvtFDd5ZoEK0l3VcN5GRRhzDs7IsNYiKCNtzGFvQE8vzw3nKWjv+wV92tXPv7X6FvlO96MTMrJuQzaGuMfY1p1zAfD+9CJWchCoraReAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780073155; c=relaxed/simple; bh=aCI6e/l7Dth2yzzxP11p44pWFmgqpTitIRCmWKW+Zeo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=AFu9fP/h/9PLZDRq3DawmzY3DI0hK4K5isa4p87gFZBVHueCUwrQkL7vjxGwxBIG3r9kmmO86cUH0ak21sODcWpEEdZdnA1QGT2/mAjlgQy7hqvhD5gUCysPpLBrJZvYp0LFKrdPwwHdyuEtOF3uJYJyY7TOwL26kJrJaRqEQD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=U6YU6Qgy; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="U6YU6Qgy" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36ba285e98bso1637455a91.2 for ; Fri, 29 May 2026 09:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1780073149; x=1780677949; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aCI6e/l7Dth2yzzxP11p44pWFmgqpTitIRCmWKW+Zeo=; b=U6YU6QgykwPA7soFByIMVg2vbXSf59v0zB9T82Pl5qEorozbfJvZKAlGI0zVP87zEO PyB74ETcPxMSukAmfp5cIQ3SdDvbp7bTDloQb2+VY7F/Gr5qHYiePCBvvx1I3ALVJLFd WknBmMA/H9QPmkOPAWyKHRRmVMvziPyQXmrXy2Dyk67UX1jBvkwEFAnr1QfXxjap/rtM XppvEPHy/pqFcyDgPQksoaM4rXhb/gZIhCryYwYUEJWCT+toO0MH4ex5qA9kBGdtKOGl rhFXfu67mnePh6eXQWmuZvM7pberkMaZMtaMtG0GpEsZ3s/rKHX1/RzuuydJqD3CneCh RIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780073149; x=1780677949; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aCI6e/l7Dth2yzzxP11p44pWFmgqpTitIRCmWKW+Zeo=; b=NyerHtnlV5/KQZo4fgtpc1Mq+rTWd4prBiqk4Lu4G9DXADqZOPdT14VxA7+N98IJM3 hPzN5wG00v9OOCkgkg17mWiYWfirzqjl/z2mrYh5MvDtZk1KeBgNdO5ujzH/kGhN2nFc DhIZ1ASZNHbygzLkPAJfdq78mCAIkab9fn4B9pGXFQJoHIhC8a5FmE/FxO7+OS4FhJG5 UPjnDWBTMnmqjmdJyJFV7okm//hQ63fdyDH82Dwht3WrSbwSIarkzxtCUTruiaPdaEuM REDc2FFNcymrsvcbXrC8P7GDg1ysFkeZZbWBKsQqpsVLRpMOOiBUKmG3PAOQq8Mz41pW RqdA== X-Forwarded-Encrypted: i=1; AFNElJ+/1kIriDzkqA5sT4VICSfMD1BE3/7KL1KTS3X/Ab2/D9ECuRO2mKpRMx/Uh/0fQpmmgQc+zIQ3fWZtzc8=@vger.kernel.org X-Gm-Message-State: AOJu0YzadBN+p0NeLN//yHt7ciUMna1V0P3DWSYnqB4Qg1qlJmQyQNmF KTZyaa+RtenHS/+dVk9iIbpL/PBURsH9QIaaSuY7UY9Yho8mOS/z0OjcXIfxb1+B3J4= X-Gm-Gg: Acq92OGtvVNtYXi3cTXJJ2y7DDNc2Y4RIujIZqkOM6kr7z1EU3Zs1aJGNYhini1pdWl OOURyLSbabo6yDLXy14vbzxeHKQ78wEpqJ2Dq8aC3sOA/isiHEfT50oYLYdP0Z1w7CrZeyaHomE sDT71N6Awh8XpNQp1Ggulqcu9s3zr85VbsF77YJR6tz6tkYX+1NBa9DK6HsNWWc1yUgc2ArNpN2 mTzqmMA4OkdSJ0VSf02ZsEPFId/iKwN7yqx4ybEiL9WTsS2aZACd0kNoHiARlXoGRu9g/B2dKX4 Z6Taq6Y1l0oGKOmnkATH1XtWuxKWJoSIMhO9vsNfOhBTuMvFTU5UrlggkfF8Yq7ieW1qE3Obkvc JNpu3L1XxFQa1RIIiL5KAcNQodBa4hyyHNZ0RW7hcHOwJJ5FF78vFIXTsG8sVss6X4tM3umIE2G G5ISRajdteVMZufTpNrluojA2VIB8NSmrS5m0= X-Received: by 2002:a17:902:d583:b0:2b4:5931:bc4c with SMTP id d9443c01a7336-2bf367cbf43mr8005005ad.15.1780073148788; Fri, 29 May 2026 09:45:48 -0700 (PDT) Received: from localhost ([2001:569:58a0:da00:a5c8:c4ce:f7c1:40c1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c26b3bsm25060415ad.64.2026.05.29.09.45.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 09:45:48 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 29 May 2026 12:45:47 -0400 Message-Id: Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 0/3] bpf: cgroup: fix sysctl new-value handling in __cgroup_bpf_run_filter_sysctl From: "Emil Tsalapatis" To: "Dawei Feng" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <0f50af7f-03c5-46d5-9d68-553dc6995df0@linux.dev> <20260529113752.2863465-1-dawei.feng@seu.edu.cn> In-Reply-To: <20260529113752.2863465-1-dawei.feng@seu.edu.cn> On Fri May 29, 2026 at 7:37 AM EDT, Dawei Feng wrote: > On Fri, May 29, 2026 at 12:44 PM, Jiayuan Chen wrote: >>I think patch 1 and patch 3 should be adjacent in the series. >> >>Why is patch 2 placed between them? > > Hi Jiayuan, > > Thanks for the review. > > Patch 1 and Patch 2 are actually parallel to each other. They both addres= s > pre-existing issues that would be exposed and triggered once the changes > in Patch 3 are applied. > > In a previous iteration, a test bot and another maintainer pointed out > that activating the code path without fixing the underlying issues first > could trigger a kernel panic. > > I placed both prerequisite fixes (Patch 1 and Patch 2) before Patch 3. > This ensures that the fixes are already in place before the code path is > activated. > > If you prefer a different order, please let me know and I will be happy t= o > adjust it. > >> Change is fine but fixes tag is wrong like the bot said. > > Noted. I will correct the Fixes tag in v3. > >> I saw a reviewed-by tag given by Emil in previous thread. Pls carry it= =20 >> when sending new verson. > > Thanks for catching this. I will make sure to collect and carry Emil's > Reviewed-by tag in the upcoming v3. > Seconding what Jiayuan said in terms of the Fixes: tag. Also feel free to add my Reviewed-by: on patch 2/3 that IIRC was not present on v1. > Best regards, > Dawei