From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D55C2E9ED6 for ; Tue, 2 Jun 2026 12:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780403695; cv=none; b=WaHrhApG7Gg3T8KLpjuPE2FNjkHlfeU4oYqN+f0CwbuHu6J0VWAZw91+bKkIk9GFzARaaCDfTID9cOPC3jQ7b0mZw0ZuDjOaHnfvdkAUcl/eLVgkayU0nJW8/gaMWD6VI8W7WqCD61xsRz/+pTCq5zMo3DN8mJCjScO/XhTc5fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780403695; c=relaxed/simple; bh=g3+PolSFTvl+Dbxqo7LBVuF4Wk/ljZfu9PhVMO+r3Uk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=ZkYkjwl+BE3ReZ9MIAFxAWZTQwkiiDJyMAK1KtGpmlHDwGIJ/qh5r9sF9/jjtgYd6LO3w/kA86rVCUbpzPDNcoAd3KXnMBmNBxyCY3MEvjZtha3Z9lh/LvdDOOy/0rWTHMQ6PlRQaangyIg/jDCJ4zuuiLLb1jzU+OhOLbVx67g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CAcko4UU; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CAcko4UU" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so10884705e9.0 for ; Tue, 02 Jun 2026 05:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780403693; x=1781008493; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g3+PolSFTvl+Dbxqo7LBVuF4Wk/ljZfu9PhVMO+r3Uk=; b=CAcko4UUMDxvlDsleuegKtUOyjZCBwIlzUUbqhHjZwbDvuSW6lDgClh8WYh8DjkrJm 9s/jeMp5xLRNbYYHz567f8aibGlAzJ2fCLCKtn3K65Um5JhYu70uORRpazGA23jLrtd9 w56WifPZ2Kkd9qdV2KYeK1Ojy4A0oID1OMwLBdQXu4576uoe5JP3mcDflRbat8yvIlkV vHBc+LQMhRe2d3e8Xp7l8OAo94GWWTX8w3Ytgps5zyqIY7Bg89PwGhcfpNgUIvImFLM4 dliUqn5zS2AtdIXWyy0dm2vgiIgF6Gpl3gMpfvM9C07BP3/qIAlxF74/gHk98y+JcqFk ATzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780403693; x=1781008493; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g3+PolSFTvl+Dbxqo7LBVuF4Wk/ljZfu9PhVMO+r3Uk=; b=FiNo3kMbbJARA9htr3oRLHFjRxBUO1XECP0ZaFCp2hVi2bgcUluy09B3UrVVyzU2tw 6Q5pDauyV4OkKO2F3l87LrMzhlDexYWi9gow5aCt3pG6ddrXATZiMVhYKwzetmzFnA3M iQi7FMJ6ZDGWvJDQs8BQimobz8xfSConc8ugh2ZMC9x6k8FGuKOS4NlWG+KWdSvQvhjK 2AJr7RZR6OlT1Cu8bf/9d3masLXZ3ehMm+TkoZ0NBro3CKTVExCYqI+XI7i046sT8wIb gLaWNtIpKXsLZd8YmlGXgy4zSjFC4zw88P+hCukuaJkDlLsSvW7nOIP4j1P1abBZvaVT h6yQ== X-Forwarded-Encrypted: i=1; AFNElJ9eNtPPZEm701SPtUsD7cT7Kyp3sq08RX35H7PLZk8QGn5GhigfVNsqHZTysm2+scvTVlmSQ/1mvwF5KTs=@vger.kernel.org X-Gm-Message-State: AOJu0YwUKmjS5mTXPxwZYPAq7jIfEWYQdM34oDeUv+OOwwiLHDpCx+XW ZS1ZVwjmiXQo2DXWwV684vOhchdfIcFiafDQUr86o68cF+N9wxc4garA X-Gm-Gg: Acq92OEU885e1xPHH5tFS8DT1bU7IVQ+dJrr2mjWGtN6PTfNhp8SPNT9d76cOvrbOKW Imw+AhPR7L20Syd/1vL3IzvsLVSr8qPl9SKrK4GS3S3YNxcuQank6JsijQnPkF5wwhEF7jZP1AS f726xv/jiliC8iRDw4ZEWKF1at1//3nNRZ813VenBl2xVoiUe1NrmpzaItoQUGWveIqBfspzmrs yaCAcGeHkF/Vcg/tqI8/4pJH59sXQNXswW3+Ugcj5Lz8p8wv17Fk+uE1oijvNbSjJrubbv6Qkm2 J0TDTV6Qkfz46Nrd9bx1JHLYamnzVCG2Pxry/rZvwMkNviWf0XKUi/DSYyuYVJmhTmuLb9MNy9q veuETqd5erpaB1aPJ8pH/ZXkGnrtkBdke4Hn2I3jmYlRUueIw5Vkin2QVnlGxQIAASGlmfKe7IO gvytrGMVkikn9uH5x0HzJy4hXkVUx5L9oaoUHtd+iFzcnVRGI= X-Received: by 2002:a05:600c:8b2e:b0:490:6889:1ff with SMTP id 5b1f17b1804b1-490a2940dd2mr275892015e9.28.1780403692736; Tue, 02 Jun 2026 05:34:52 -0700 (PDT) Received: from localhost ([2001:4bb8:152:df59:3b69:56ea:a39b:adb4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c0e8c1bsm137133085e9.3.2026.06.02.05.34.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 05:34:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 02 Jun 2026 14:34:50 +0200 Message-Id: Subject: Re: [PATCH v4 2/4] iio: light: add support for veml6031x00 ALS series Cc: "Andy Shevchenko" , "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rishi Gupta" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Matti Vaittinen" , , , To: "Joshua Crofts" , "Javier Carrasco" From: "Javier Carrasco" X-Mailer: aerc 0.21.0-143-g2f3a2e260c09 References: <20260531-veml6031x00-v4-0-e64f7fdce38d@gmail.com> <20260531-veml6031x00-v4-2-e64f7fdce38d@gmail.com> In-Reply-To: On Tue Jun 2, 2026 at 2:33 PM CEST, Joshua Crofts wrote: > On Tue, 2 Jun 2026 at 14:22, Javier Carrasco > wrote: >> >> On Tue Jun 2, 2026 at 1:47 PM CEST, Joshua Crofts wrote: >> > On Tue, 2 Jun 2026 at 13:35, Javier Carrasco >> > wrote: >> >> Thank you, Joshua. One question, though: maybe you remember that your >> >> last driver was missing one header (which I am not criticizing at all= , >> >> as you can see I missed some too!), and I am wondering if it was beca= use >> >> iwyu missed it and if so, how that could be avoided. >> > >> > About that - I didn't actually run iwyu on my driver, I recently migra= ted to >> > Fedora and forgot to set up LLVM and iywu-tool :-) >> >> I installed IWYU and added your mapping for a quick test, and it wants >> to add a million headers or so: >> If that is correct, I bet there is almost no driver prior to IWYU that >> has all the headers :D > > Well, as Andy said - it's still far from ideal. It generates unnecessary = noise. > > Question: did you run `make compile_commands.json` before running iwyu? > > iwyu_tool -p compile_commands.json drivers/iio/magnetometer/ak8975.c -- \ > -Xiwyu --no_default_mappings -Xiwyu --mapping_file=3D/home/josh/iio.imp > > This was the command I used when I did some cleaning up on the ak8975. I used the compile_commands.json generated by scripts/clang-tools/gen_compile_commands.py, which I always use to have a better experience with clangd and Neovim. Should it make any difference?