From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1373327F19F for ; Tue, 2 Jun 2026 19:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780429774; cv=none; b=M5fvH9K7SsJPrxKxZafR7y9U3ogGj7cUWadirK8x5ZhOGGhzC6zq9/DZ5fByk8H4n4yeKi02h/puFxC77/murFOabAAntPAASb+jXTvbwaEyLcrEP359zPdSN5I0Yvfe1urXYOlvb83YJydAtWdWN1OuxDRkcxtXzK7lHPMtnqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780429774; c=relaxed/simple; bh=oBaTI4c79O6vpTgtjlM41+/n4xq+WnG2e+IzVNiDbJU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Pxs/PDZLAsElB+tAz7J1Q/Ew1UumM7coYUkaWBwbEU2mv+Rrwiiq/TRC3oj2W41xLPaLa19qmNlXC6nJ5ew1wj9/5rVbIZK9jc+ha8DVfBbmQhPNnfnqEDKxVDRJymXh+xDIDm8kSyURS4PJkNlkvDY+zipPY9l6vMqsx0XaVnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UIZL/+P2; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UIZL/+P2" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49041fb8c23so89809155e9.0 for ; Tue, 02 Jun 2026 12:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780429771; x=1781034571; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uspwVvtiltCsqTff8wL3whaP7rrxXxnCkwg5ui4E/K8=; b=UIZL/+P2j+ObC1TFknmKvWW+pvVGOvQ65357KvL2WrRK7JuPiejBSgMapE/rDxmsf9 vQILcjVvuz9mcx6E1ICApAYYjMFzlGOOWQbqcmi76iNBm42WCJHP90Gker3mFVCZO2Nn V659XeY3viIK9N55O9XUVVUFkj4O5rNzkGG9cI26Uf9LsxZtNJJf+uMWQNJw8YEsRTXw HywqDmVGAihaT2UNIbCuZlxrwfuw7wyA0Zb1HNSORb0bzPaP7Y9uOLd1KIf0xhlpe2GR 1b+vT2YJZXOtMmWE3fLkOIX0ZmJUW6NV+7Cz9ANpq3NDWCSDl034azL3vulPAmexINHS 5jlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780429771; x=1781034571; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uspwVvtiltCsqTff8wL3whaP7rrxXxnCkwg5ui4E/K8=; b=qApreQrwDvaRJP61/HhixExHMHixPa8KMmKfpFQCpfLTDOLNnUT64ZV0HD5jYPeIIU mBhdii7cDHxiXkTZGvulV+sSPXg8G2Oan0zFEJ7AbTBt1PgdIH35nj+IFpAmbEkn8da+ EvkiOPyo4+E4i1YtxHoj1wgkZFoejTvy9+ReBEbwiSRH3Sb17tI6aJ9IgK5mrDyO2/ST w0x+nrW6edXiCqX2FcNElmLLKOcyuwv8oSjcRPC8T/JKHe6Iumnxase+KVgRoJbCdpx+ QRXZP+8y7W9vHK74Rd4WyP2kQNXwfa8tc9qJMI3qpNDK+pm7scWWA3QfM39Dk2uP2Ql8 SaGQ== X-Forwarded-Encrypted: i=1; AFNElJ+5OO9QB12wTEv+pyCvrG5vLDx2//2DJ61lvUX0EFC7HxRzewf2mOIzCri2spaHDFj7Kci9Hmra1n4yphc=@vger.kernel.org X-Gm-Message-State: AOJu0YzKw6ETRJYdf6mo5FeE4oMN+StAwpmpecyFGX3k5AiFbDSOZsll bP3EirTuOOsZfOrNOq0boF56hEuW+MxT8gxCTKfA32q2TvOaeXnUpyqp/wozm0u7uJA= X-Gm-Gg: Acq92OElNrOARyPkg7sY0ionkpDY3htNBhEaaQlL7ZX4pgBj+PKyo2UiiHwc/GnDUI8 bShn66xiR1YNjKTd1VQfsbL655uC07824+7WGucMX2f/1AfApMImzUrM7fSKRpw35eizxc2Udoa Bke27EyzzNDsQIIaD6X+PTZV18pmg+ICOlbBzJ3BdZvbbWKjIyiGTrlPaR9dAbxA/ZcEgKZCXCh ZFcJaWBsJVFIzVezRWi9yQdLpoFrTOQf5lN7eZAkcE9T0xWXvRwtJ6x2/80PQXNtLtM7A0/phxv ba44woEljdfG02Ns5w+59IBS6FwMGM+tZ3pJzEaqMUnui3M+XltCa8IsEmhHSFpx7pkKiAJAKJU 1jLPZJdmOCDbfezTrT5MOFhqoCni2h06z0HEtmbe7zI3TKD0py1PU8feNazfcNiqoTqKFTob34p wdu6reXs7T7BoH0UHA6TT3JGtAchWLbLgJaUtY+VW6FRY+nVmBEGlteMCrYKkxlJL35ru5r+lg/ N8/KFPVEWFJ0MQ6o7/Bib6bp+KoRERJGU4= X-Received: by 2002:a05:600c:8b61:b0:490:b1b4:d437 with SMTP id 5b1f17b1804b1-490b5d3e1d5mr4934545e9.0.1780429771536; Tue, 02 Jun 2026 12:49:31 -0700 (PDT) Received: from localhost ([94.4.195.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b60f6d5asm3064455e9.0.2026.06.02.12.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 12:49:31 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 02 Jun 2026 20:49:29 +0100 Message-Id: Cc: , , , , , , , "Krzysztof Kozlowski" Subject: Re: [PATCH v7 2/5] thermal: samsung: Add Exynos ACPM TMU driver GS101 From: "Alexey Klimov" To: "Tudor Ambarus" , "Rafael J. Wysocki" , "Daniel Lezcano" , "Zhang Rui" , "Lukasz Luba" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bartlomiej Zolnierkiewicz" , "Krzysztof Kozlowski" , "Kees Cook" , "Gustavo A. R. Silva" , "Peter Griffin" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Alim Akhtar" X-Mailer: aerc 0.21.0 References: <20260602-acpm-tmu-v7-0-8047dd54b0e9@linaro.org> <20260602-acpm-tmu-v7-2-8047dd54b0e9@linaro.org> In-Reply-To: <20260602-acpm-tmu-v7-2-8047dd54b0e9@linaro.org> On Tue Jun 2, 2026 at 6:00 PM BST, Tudor Ambarus wrote: > Add driver for the Thermal Management Unit (TMU) managed via the Alive > Clock and Power Manager (ACPM), found on Samsung Exynos SoCs such as > Google GS101 (and Exynos850, autov920, etc.). > > The TMU on utilizes a hybrid management model shared between the > Application Processor (AP) and the ACPM firmware. The driver maintains > direct memory-mapped access to the TMU interrupt pending registers to > identify thermal events, while delegating functional tasks - such as > sensor initialization, threshold configuration, and temperature > acquisition - to the ACPM firmware via the ACPM IPC protocol. > > Signed-off-by: Tudor Ambarus > Acked-by: Krzysztof Kozlowski > --- > drivers/thermal/samsung/Kconfig | 19 ++ > drivers/thermal/samsung/Makefile | 2 + > drivers/thermal/samsung/acpm-tmu.c | 618 +++++++++++++++++++++++++++++++= ++++++ > 3 files changed, 639 insertions(+) > > diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kc= onfig > index f4eff5a41a84..383ae3f56cbb 100644 > --- a/drivers/thermal/samsung/Kconfig > +++ b/drivers/thermal/samsung/Kconfig > @@ -9,3 +9,22 @@ config EXYNOS_THERMAL > the TMU, reports temperature and handles cooling action if defined. > This driver uses the Exynos core thermal APIs and TMU configuration > data from the supported SoCs. > + > +config EXYNOS_ACPM_THERMAL > + tristate "Exynos ACPM thermal management unit driver" > + depends on THERMAL_OF > + depends on HAS_IOMEM > + depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOC= OL) > + default ARCH_EXYNOS > + help > + Support for the Thermal Management Unit (TMU) on Samsung Exynos SoCs > + (such as Google GS101 and Exynos850). This driver doesn't support Exynos850. There is no initialisation sequence and etc, moreover the next section is also not entirely correct for Exynos8= 50. Not sure why it is mentioned here in such way. (Not even mentioning that ACPM TMU part is not aligned for Exynos850) > + The TMU on these platforms is managed through a hybrid architecture. > + This driver handles direct register access for thermal interrupt stat= us > + monitoring and communicates with the Alive Clock and Power Manager > + (ACPM) firmware via the ACPM IPC protocol for functional sensor contr= ol > + and configuration. > + Select this if you want to monitor device temperature and enable > + thermal mitigation on Samsung Exynos ACPM based devices. [..] BR, Alexey