From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: <bot+bpf-ci@kernel.org>, <ethantidmore06@gmail.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
<eddyz87@gmail.com>, <memxor@gmail.com>, <ameryhung@gmail.com>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <john.fastabend@gmail.com>, <martin.lau@linux.dev>,
<song@kernel.org>, <yonghong.song@linux.dev>, <jolsa@kernel.org>,
<martin.lau@kernel.org>, <clm@meta.com>,
<ihor.solodrai@linux.dev>
Subject: Re: [PATCH] bpf: Fix signedness bug
Date: Fri, 05 Jun 2026 22:31:15 -0500 [thread overview]
Message-ID: <DJ1NDNGUKCZR.3CRKEWPZ3OOMN@gmail.com> (raw)
In-Reply-To: <86b976f32a179141dbeb3eed5fa106f18f2e46b5c6849ca2c800484847d1deb7@mail.kernel.org>
On Fri Jun 5, 2026 at 10:25 PM CDT, bot+bpf-ci wrote:
>> commit cc27f12c12ff54b8eace339c3e130317bf205277
>> Author: Ethan Tidmore <ethantidmore06@gmail.com>
>>
>> bpf: Fix signedness bug
>>
>> The function acquire_reference() returns negative error codes and 'id'
>> is an unsigned integer, so the check (id < 0) is always impossible.
>
> Is this commit message accurate? Looking at check_kfunc_call() in
> kernel/bpf/verifier.c, the variable 'id' is declared as a signed int:
>
> const struct btf_param *args;
> u32 i, nargs, ptr_type_id;
> struct btf *desc_btf;
> int id;
No, 'id' is assigned as a u32:
u32 i, nargs, ptr_type_id, id;
--
Thanks,
ET
https://github.com/sponsors/ethantidmore
next prev parent reply other threads:[~2026-06-06 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 2:45 Ethan Tidmore
2026-06-06 3:25 ` bot+bpf-ci
2026-06-06 3:30 ` Amery Hung
2026-06-06 3:31 ` Ethan Tidmore [this message]
2026-06-06 3:50 ` Amery Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ1NDNGUKCZR.3CRKEWPZ3OOMN@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®