From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FCF438F646 for ; Mon, 8 Jun 2026 07:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780903979; cv=none; b=njfhm6zjJOsdzkNh1DUXcEGASQi8zNM2JiWGBUqmOWjF+3Wil4AerQVqjBRkwTQlxWq+/2pOODtFZhL20kAQgmCLhxn3jngXY+gl15wDx2af9s0XUvDH1tas/eF0BdhhHm0cgW2SGuFRuKD7qR8ueoi4TZ/G9PG+dxPVnXb3CLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780903979; c=relaxed/simple; bh=XMHyOQHx6WIm/tuQ1tglv5lWCjfTXh95qCF2ldK+bKM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=gVfmYmze3J5ad0NGoskCNU1qOZQjC/b5ilNs/9kKJkwropE1YmG4LmS8gwV5vDDX4qAqbEwCMvduTdfDIE5NUvALlfmJ2I1+L7bSfUIoh/J7EN2iJ1OkVoGFbHFsBof8FlFhwigEUfoLkobUqJsX+KQRsMGcLk06MBIyJ9Z5RJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=wGFcigS3; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="wGFcigS3" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-bebac79fff8so397115866b.0 for ; Mon, 08 Jun 2026 00:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1780903975; x=1781508775; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5e4yVKORIbgcZMiPjlqQS5Msk7HSGQTKiassh3VqtIA=; b=wGFcigS3B+FXukYWVi5TuZg0Iuo6fSbyAfy6NUHUuTyKi3aZ5s5eNx9ncKP3Jjj8qt 8i1LY9nXLim4RY+BzxCPdSXverYy2XgfIB4EfVKT6B4X/3vKM3K2FZS+gRBkP1euC3BZ zGJ2tfn/wD1yVYyWbv/zeVMxld81oyJjV0K0MR8o/vGEekpoivOuxBgs4QjJlPkm1qlv Rsqz9h21+KSR+WkU8nwsdA5YnNKdSGYjnzE2q5gS5mVJp7VNQxmYzdgBbofcDQuZwvbO b99N69rEUw/T4Sb9GPoWywQgTWJ6HmTdtNeca54HsiJT4ZZx/FIvFqLlJAiczzl7xdFT ab9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780903975; x=1781508775; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5e4yVKORIbgcZMiPjlqQS5Msk7HSGQTKiassh3VqtIA=; b=Fdid+GnOqZ5tzbpMsMDUDvu1OtyDWpIn2jF6LbwYjbkgSZ1NF80f/AftaaynS95rpH 9lCQXgpW5810w6DYFApgcCNsQsh8AcJQUh8qctN4/pkZuGg6M3JLnSXhjeKNt5lMYj8g m2ITFZmZD9t2wKoxgpDJb5b+T40Ey/9m2PH+O6S81kfU4DA6ta+gTAFzqnGzoLV+BHt7 xRAxvc8bmIdE7DVZlxJuF2afJcvBl0MIQ/ozL8SPoy8ZUS4C5zVVOevqSKyctWY2xmtr m2DYSxgHaSrtrQA6+LSXfcjYmPgQsuJi00jvolQtU3mkSPzoaSOKTPW+l/qgarpD/tnO Z0Ng== X-Forwarded-Encrypted: i=1; AFNElJ+9FW4NUSkYmB8p2zhehcRGw+ULhqQFGkZM5vwFUCwUGxVTiMaV+igZ4zqYh3kIh1VcOGkG3bPiI85GonM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj1JuRM7xeRPnsQKWx/H/K+hfO+DA/fFapKPoNZNNbMF0SqQyA L+KuxipHxSPIhjr/y7sJ0vGAniaur07EljcISZ8udjEwX6yxY4x6PGaZ3tfOqUJqvac= X-Gm-Gg: Acq92OEC/+ISFWTaNsKTp3vOM7aBr17ailws0Tb8+22MryLrEmTGp3ejvnCmd0yaUDB Sx6RIW5TAg16KLH9pZpE+21D8YTLIGsd0lK+rVTt2/v5wMrPjnk1kGqGk1Wssaour4dGWNB7uMK TL+6J0TkrIGGXJbgjmpvfJIKH1fuRveW9M6yKKeAQ1jONLnk0aMd+R7AyFXQFlceNUCccZCjvwa f/uFbMWFcW+K5u5MQxL+yF2O1WnJQGA7PL2PhxMnyZ3k72B6ZGybTFeZW8ny4gXi3U0uZAeVsD+ i6GtV3HvU8zDrepTyPVWJEbzQ82mc8jmUTdJdVY9M+vH5Y+0+PfvQGurrIRfRz2AJta9D1OWnEY AlSaAYqTsBVd+FJ5JKskUTw0D8DDJ7v6GW2+BhCklddU8rzjqYAz5IzyvVTCBFp5GWcnGOoluhK YuSwbu+mx3G9UMwDwkKJd2WICtro/r53VcKIZiDcnE/KzdtEXzGIz1S6yUPq3VFVAyjPNRF8IUs HbemOI= X-Received: by 2002:a17:907:3f20:b0:bdf:8e2a:1092 with SMTP id a640c23a62f3a-bf370e639e5mr722825866b.3.1780903975340; Mon, 08 Jun 2026 00:32:55 -0700 (PDT) Received: from localhost (144-178-202-142.static.ef-service.nl. [144.178.202.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf051d82a31sm831571366b.19.2026.06.08.00.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 00:32:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 08 Jun 2026 09:32:54 +0200 Message-Id: Cc: "Ajit Pandey" , "Imran Shaik" , "Jagadeesh Kona" , , , , , , Subject: Re: [PATCH 5/5] arm64: dts: qcom: Add GP M/N clock controller node for SA8775P and QCS8300 From: "Luca Weiss" To: "Taniya Das" , "Bjorn Andersson" , "Michael Turquette" , "Stephen Boyd" , "Brian Masney" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Linus Walleij" , "Richard Cochran" , "Konrad Dybcio" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260602-pdm_clk_gp_mnd_v1-v1-0-1522662b6c53@oss.qualcomm.com> <20260602-pdm_clk_gp_mnd_v1-v1-5-1522662b6c53@oss.qualcomm.com> In-Reply-To: <20260602-pdm_clk_gp_mnd_v1-v1-5-1522662b6c53@oss.qualcomm.com> Hi Taniya, On Tue Jun 2, 2026 at 5:21 PM CEST, Taniya Das wrote: > Add the GP M/N divider clock controller node at 0x088d3000 to the > SA8775P (kodiak, lemans) and QCS8300 (monaco) SoC device trees. > > The node uses the qcom,clk-gp-mnd compatible, is clocked by the PDM > XO4 and AHB clocks from GCC, and exposes a single clock output > (gp_mn_clk) on the dedicated gp_mn pin mux function. The XO4 clock > is pre-assigned to 4.8 MHz (XO/4). > > Signed-off-by: Taniya Das > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/lemans.dtsi | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/monaco.dtsi | 14 ++++++++++++++ > 3 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/q= com/kodiak.dtsi > index 1ff9e1598d00429c03b2bcae41fa370ab2c892bd..cbc13ac37f8aeb0b1071ad060= 9ec11e829d2c798 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -4412,6 +4412,20 @@ usb2_role_switch: endpoint { > }; > }; > =20 > + gp_mn: clock-controller@88d3000 { > + compatible =3D "qcom,clk-gp-mnd"; > + reg =3D <0x0 0x088d3000 0x0 0xc>; > + clocks =3D <&gcc GCC_PDM_XO4_CLK>, > + <&gcc GCC_PDM_AHB_CLK>; > + clock-names =3D "pdm_clk", "ahb_clk"; > + clock-output-names =3D "gp_mn_clk"; > + #clock-cells =3D <0>; > + pinctrl-names =3D "active"; > + pinctrl-0 =3D <&gp_mn_active>; > + assigned-clocks =3D <&gcc GCC_PDM_XO4_CLK>; > + assigned-clock-rates =3D <4800000>; > + }; Am I missing something, or would this just configure gpio60 for all boards for this clock controller output? On QCM6490 Fairphone 5 this pin is connected to FP_3P3_EN, so it's definitely not unused. Maybe disable them by default and let the board enable it, if it wants to make use of this clock? Regards Luca > + > qspi: spi@88dc000 { > compatible =3D "qcom,sc7280-qspi", "qcom,qspi-v1"; > reg =3D <0 0x088dc000 0 0x1000>; > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/q= com/lemans.dtsi > index 19f8cf4e15482947f6049188050c370340afaead..d192f92a896bb13017abdf820= 62e8305aab3e5d5 100644 > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > @@ -4353,6 +4353,20 @@ opp-384000000 { > }; > }; > =20 > + gp_mn: clock-controller@88d3000 { > + compatible =3D "qcom,clk-gp-mnd"; > + reg =3D <0x0 0x088d3000 0x0 0xc>; > + clocks =3D <&gcc GCC_PDM_XO4_CLK>, > + <&gcc GCC_PDM_AHB_CLK>; > + clock-names =3D "pdm_clk", "ahb_clk"; > + clock-output-names =3D "gp_mn_clk"; > + #clock-cells =3D <0>; > + pinctrl-names =3D "active"; > + pinctrl-0 =3D <&gp_mn_active>; > + assigned-clocks =3D <&gcc GCC_PDM_XO4_CLK>; > + assigned-clock-rates =3D <4800000>; > + }; > + > usb_0_hsphy: phy@88e4000 { > compatible =3D "qcom,sa8775p-usb-hs-phy", > "qcom,usb-snps-hs-5nm-phy"; > diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/q= com/monaco.dtsi > index ebe5889daa5300efa7857314e9170d7d2fc33ef7..f6c5ec38c7491b7a16ebfb853= f8af88bdf1f0db3 100644 > --- a/arch/arm64/boot/dts/qcom/monaco.dtsi > +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi > @@ -4867,6 +4867,20 @@ opp-384000000 { > }; > }; > =20 > + gp_mn: clock-controller@88d3000 { > + compatible =3D "qcom,clk-gp-mnd"; > + reg =3D <0x0 0x088d3000 0x0 0xc>; > + clocks =3D <&gcc GCC_PDM_XO4_CLK>, > + <&gcc GCC_PDM_AHB_CLK>; > + clock-names =3D "pdm_clk", "ahb_clk"; > + clock-output-names =3D "gp_mn_clk"; > + #clock-cells =3D <0>; > + pinctrl-names =3D "active"; > + pinctrl-0 =3D <&gp_mn_active>; > + assigned-clocks =3D <&gcc GCC_PDM_XO4_CLK>; > + assigned-clock-rates =3D <4800000>; > + }; > + > usb_1_hsphy: phy@8904000 { > compatible =3D "qcom,qcs8300-usb-hs-phy", > "qcom,usb-snps-hs-7nm-phy";