Re: [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

["Alexandre Courbot" <acourbot@nvidia.com>]

On Wed Jun 10, 2026 at 11:57 PM JST, Nanonej Dev wrote:
> Oh! Didn't think to add this extra tag since your review, sorry! 
>
> Can we add it now? Should I do a V3 to add it? Or not that much of a big deal this time, but should think about it for the next time? 

Don't worry, you did nothing wrong.

This is just the (rudimentary) process by which we state that we have
processed a patch in some way: just reply with the tags carrying our
name/email that we want to stick to the patch [1]. In this case, I've
reviewed it, so I signaled that by giving my `Reviewed-by`.

Since I hadn't given it by the time you sent this patch, there was no
way for you to add it.

The common practice is to collect the tags you received on vN and carry
them onto vN+1 (unless the patch has significantly changed), but in this
case this wasn't necessary since Danilo applied the patch and added the
tags [2].

All this to say that this was a perfectly normal kernel patch review and
there was nothing more for you to do.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
[2] https://gitlab.freedesktop.org/drm/rust/kernel/-/commit/3e4bac7b8ca7688fb3aa9c0bf005a5a4256ad578

>
> Anyway let me know and thanks for the feedback!
>
> Also, I check for Proton Mail, as I understand they don't support `format=flowed` so except using there "uservoice" service to ask them to implement  it, I had probably nothing else to do. But I found a git-protonmail service dedicated to use proton mail with git send-email, so maybe it will work? I have to try as I don't know the email protocol well enough to understand on which layer the patch get mangled and if this tool can proxy around the Proton implementation.

Normally `git send-email` or `b4` should do the right thing, but after a
quick search there seems to be recurring server-side mangling issues
with Protonmail, so you might need to use another service to send
patches. B4's web endpoint might be an option [3].

[3] https://b4.docs.kernel.org/en/latest/contributor/send.html