From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB7D25B090 for ; Thu, 11 Jun 2026 10:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781172978; cv=none; b=QwJlz1D+SeO8UvSKVu/rp7k6Q+zlNcDMImI4XxwiZ2q739QEc69d4zGycmCgOtPia/s+JevXs8Lz6thXM5tbxl6HNYYCX2ial+BbqqISdqXFt5jGgAZJvXczEYOrJUd+BpvhyFUQJzJ6g9dw8VLs1JcdlqV0FdcTnkSR1FygerI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781172978; c=relaxed/simple; bh=rnRpWmG4J48ZICobw97cnDsqPP732sbLJJ65tkBqeIA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=QGYgjCZJv7LnhVtNylrJENZ1dlZg82Gj72/zqWeyCwV+oxnRjRkFJqIRMb8cpaDADfTaPXutJ1H4Z71We3CoxlM85+xcQeF2MyavJR5XoH0SFRN2rJW3vam+mvG30LKVnZDL8/WRQtLTg/+ksQmYt5jeBnOXMGk3a6xWpBhK77w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=G69zae+J; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="G69zae+J" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-68d233bf083so11195873a12.1 for ; Thu, 11 Jun 2026 03:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1781172974; x=1781777774; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PhJd7zCUXuRcUedlV9DBkM4yrOANKOlgS/yqDuehskQ=; b=G69zae+Ju4pHWOEwD23d1mRyH38is151jX/CezTDqRVv3gOUkTnhdclFRM6XeRHpix w6g+APpYd1G+cXckv2l0Z0+KFgmvnZ8cZNkzCswJ3ksYOGTMKHA6ylxgnvLLVznzmEAz +7q7hqpINdptlgQnv4LU+HTPHnS9anEQjpN5f0D3iz8u5ZclpgdgNtLsnqKH1+j3vVrP 23JqOqtGeNW5Ef7isjufuKrq6P/qS5p9qTix63+uEDiM5y0icnOr0QeLI4OZDMRUAov4 8yq7Hb7HniZTFKh1piEsTwpAr+xsVjjGcdJYopiXeTp/QcD9TH0+f7Iym9wAxiHGUkMG bqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781172974; x=1781777774; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PhJd7zCUXuRcUedlV9DBkM4yrOANKOlgS/yqDuehskQ=; b=UyVfJfRIyS9DmB+QinJuXEUZXLTtaFx48BXrbLads9lgYbXfAXKOqtQCfsgHGY74jA skeMkMqCsgy5uCJZZAfM4wCZmXZSpZaK9b+75GKfvpsQr/vKm6WOwzetSPImppOEr15d Pz5IHGAbEd9J5oWaCDJ7dRDTxAIieaqk3Yr0oS4v0T0MYXUg1HA4np8zxbJh7u9O5CPy IO89GbASTnhGxrF4I9Ke6y5dbjam6h3L0DARr/oeOLh257mb3KLbSje7YyGJp+aGqjkR YY0rI3OHPssWFhRcFft8tH1yAD+9SRz6IAEpkOey64Z/Etxe8WnM7/1pAUv+A9sPrSJ4 8CGQ== X-Forwarded-Encrypted: i=1; AFNElJ8dv2vpartGqnd07giQIkEnqhaLD+83vdkATcRhhY0cKtPW83rms/ycrfKTFIsgwFvGTK9oZiYGg9pSg2k=@vger.kernel.org X-Gm-Message-State: AOJu0YwyeYjeVtSOcEbz0WWf+NpLs7klNfL/NkP3Ui13MlTClLJK4DlQ EzeS1ciZFG+P5cC02d95mmLQWlQiYPcIz+5mmbc2OnIVDXFvDi+0JiZDjQRB1wJ+j8I= X-Gm-Gg: Acq92OGX2iMixabtprCx9lJZhlfPayOrmoL4P1AmtLkCwfmctvYfllsH0xt1tGh8fEM wRkRLnUB1IBymUYQmXSI72cYEHfatnyXKBppMnUlBxMbbZktcSHTSOktddb6/HASUjPghp7TdKG T1rqLNQ5ZWXEErXsmKLxaNBd6fmrFxUkyPa2TvZK//DKVuL+kAT3sm4wMo9AlDMvVo0GiSgTtKh TfKFA3LRDmVejL6ZA4HIFjApVBTQ7+V/g7FTL8fuJ8pMt/HAZGQOGNrUHuCt5p/WYEoY3RPHcOL ra77JCbsVj3GTmAF0IpkaECppad4AQYfTku1a4slKQ21un8PaU2cFqdh6xwEF87ls6QmdjPXGar DmivRFh/58OZu4B0zxOyzIF4M4DZSZAKcRp7oODKt1xihYRLPAhtZ7PsoljkJkvAQsHRQVvj2Lh 0W2A0roOObBR+EsvLZfC8CuzpN3mURyBrgqDe3m3cR9J7H9+07FGXZpkRkYyF3EXVM5m3r/omaq xcVaDY= X-Received: by 2002:a05:6402:4405:b0:692:4761:989e with SMTP id 4fb4d7f45d1cf-6930e2e5988mr1051968a12.13.1781172973893; Thu, 11 Jun 2026 03:16:13 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65851786sm10571626a12.17.2026.06.11.03.16.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 03:16:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Jun 2026 12:16:12 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH] ASoC: codecs: lpass-va-macro: Fix LPASS Codec Version for SC7280 From: "Luca Weiss" To: "Srinivas Kandagatla" , "Luca Weiss" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Jaroslav Kysela" , "Takashi Iwai" , "Dmitry Baryshkov" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260526-sc7280-va-macro-2-0-v1-1-2c1b572fa388@fairphone.com> <311ceabf-23ff-471b-9553-797c7d76af74@oss.qualcomm.com> In-Reply-To: <311ceabf-23ff-471b-9553-797c7d76af74@oss.qualcomm.com> On Wed Jun 10, 2026 at 12:52 PM CEST, Srinivas Kandagatla wrote: > > Thanks Luca for the patch, > > On 5/26/26 4:03 PM, Luca Weiss wrote: >> According to both the static definition in downstream... >>=20 >> yupik-audio-overlay.dtsi: qcom,bolero-version =3D <4>; >> #define BOLERO_VERSION_2_0 0x0004) >>=20 >> and the runtime detection: >>=20 >> CDC_VA_TOP_CSR_CORE_ID_0=3D0x1 >> CDC_VA_TOP_CSR_CORE_ID_1=3D0xf >>=20 >> SC7280 has LPASS Codec Version 2.0 and not, as declared with >> sm8250_va_data LPASS_CODEC_VERSION_1_0. >>=20 >> Create new va_macro_data with .version not set to use the runtime >> detection and correctly get .version =3D LPASS_CODEC_VERSION_2_0. >>=20 >> Fixes: 77212f300bfd ("ASoC: codecs: lpass-va-macro: set the default code= c version for sm8250") > > Can you help me understand if this change was fixing any issue, if so > can you pl add CC stable I'm pretty sure that just came around because I was looking at the different parts of the audio stack and trying to figure out if there's something wrong somewhere, and how the different versions floating around downstream & upstream & documentation match up. I'm not aware of a situation where this change makes a difference - apart from the dev_dbg() print. > >> Signed-off-by: Luca Weiss >> --- >> I'm fairly confident this is correct, but please someone double check >> this if they can. > > Yes, you are correct, this is actually Bolero 1.1.0 Version where things > have changed in codec. if you read major number it will be 1 > This has been artificially tagged as 2.0 in the driver. > So the change that you are doing is correct. > > Reviewed-by: Srinivas Kandagatla Thanks a lot for checking! Opens even more questions in my mind, why 1.1.0 =3D=3D 2.0 but somebody somewhere decided that at some point I guess. Regards Luca