From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155264071C5 for ; Mon, 15 Jun 2026 15:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538760; cv=none; b=f4ry2qAFHpPP4ruirKkSInpHiJlPQ0LvvHI+yZSh9diEGqDe1C0P6gO3XvbLHy+q8VDsg0JYdsN+ulvkWh7peIDnXpaEePUXDFDrpUihpTjJ4bTh5u3HDPALZ3ZFkUYBnLs3q/UNYKF15balMUUTO2Ij8/PJlp0HFZJkp6Knch0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538760; c=relaxed/simple; bh=gVCzstdGdJHforHW4RhCYTTN0c3nLSAJ9c8rWzvGcUU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=XdbfvunpuPVxzL+wSprupF+HfDRg6wyhMPlpv5pbLzuil1oklKE8oZPURIeFQdVmmhgqNG/deBLVIhSEv7tXtf1zzYb4u3A8Z41mvusIWthhDEKho2HAbeuUqg0oWijrhV81dk9PlEFRJK+KDZ4SMVxxQZ9jQOkGLE7lA4VPqak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cHfTa2SK; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHfTa2SK" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7e718d46a6aso2062393a34.0 for ; Mon, 15 Jun 2026 08:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781538757; x=1782143557; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gVCzstdGdJHforHW4RhCYTTN0c3nLSAJ9c8rWzvGcUU=; b=cHfTa2SKBJW/DuvPVURpMajouETppdl6WJG0b2biQgyyT9yj58FkG0H2Hvnr9bN6Qj 3iwNKzisS2/7s4XM3quSi0MldqVmMN4OwqWFwQI677UqZU0oZPA+oChwuTefNrUI1Qe1 LXq443/4yXO9qpY6+g+GTKdgB3QZxzRUz6yE6sBJ66z9T7R3iu6CFRUKt4gKjc8Dk61T ki0ketiUmvWzkQ0ZPBaMdOfG3wZ2EXyBKeO7jXBciuGkJRhtAKbkeEV9vuICYpe8dT/4 s7JNvUYr+tdhCrlxOF11xVpGTkK7DWyHsFqId9rqXcrMtytk3atT9ir1vgjrVyDxLj57 xDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781538757; x=1782143557; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gVCzstdGdJHforHW4RhCYTTN0c3nLSAJ9c8rWzvGcUU=; b=CaBsRSiciYgbJRVM6vIw8H6f+NtOL2jG6ulocRDEuAxnsSqCSRGattHMhVEjNrjD4F A92JHxkTQ4qERKxO4wRtB1s/nI6w4Y6XpG88lVSfX9TZMJz+GrOrrVhc8lKCLAgGU57s +MtU2mu5KRsbWzKaXVe/Z9+493uaF9XTaC4R2HG9p1gSeOnOsNu7NB2P4qZWfbvD9a89 HyMv1Af29C0RiYrb48WOq7UT8Er+rzfndvvrqu9O0GkAoHxtfvDOHZy8+WTINv3WSdtQ 8/TMNsY7t9XFaQ/uKHGNwcuzEP2QiOz79SRuztxhTwBlk+k2sxub/TUBhcZrBRXUKGIR aL3w== X-Forwarded-Encrypted: i=1; AFNElJ9UVF7HmDEV7lRbbCeFZE7QbwhwmNORzVMbCaKRzy6yMAy8PTS7sTm1pDUQewiYUt5e7LQfPULTtZQQ6sc=@vger.kernel.org X-Gm-Message-State: AOJu0YyNzNi+jr/jD16+9EBX6EYbaN7d5izGXYp7hh4uX/Y+q3bTl41n KeN/qQwCZZCClxYHlJwSAt5D3eTe8g2BYXOnH0hl0hWQsUKjUTN+cHDe X-Gm-Gg: Acq92OGvp/h2VEkul7frMU3IP/WK9iR350P8ZVyU79dk7WrRuu78l04vfqcJ2Ct1S4h kviqOvXbNYBRsw5abWsZD1k6brgkbL9ohRV/p3mw4fKzaQtQr/fJ8q9dFjJnGca4bmhu3QbVvKp 6NINI5vqi9rhFkElm+dMEp3SGyqZS96Mzit6Bsm/z5MSdNfL5sR8Xcej0xvNwHWyPC6OTqh10j/ HzZkaLVprgARj5AggA9jbSYHA/EGmCXfFBaI1s3HonQ6sQ7X2FKscVo/sRML6GZteIEkaoWIktx //znE2oI9m0NRlGSekllqDSUo9P5BeTiXp/d3/j4azrShSp/aiiXhctR1ojNIwnyIf58FkyvQa6 EAmQg/r9bdGdWQHv+RXE01tpiFbCROcUJD5LsTyO9DoKQEMkp0oUC033rvK8dTt4+LL49TOeHtP AxtzQFtxo0Y8jp2gjHRgAAG8Yfqv3+dtYvYpxHlRc+iAWVNu4xYmIW/ZdYXV/zVuyGOrMjPirFa 77B6NhWnJxHhhZomg== X-Received: by 2002:a05:6830:3c0d:b0:7e4:163:49cc with SMTP id 46e09a7af769-7e784660540mr10242231a34.7.1781538756976; Mon, 15 Jun 2026 08:52:36 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:54::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e79f6dfde9sm4374723a34.24.2026.06.15.08.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 08:52:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 15 Jun 2026 08:52:35 -0700 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "Emil Tsalapatis" , "John Fastabend" , "Shuah Khan" , , Subject: Re: [PATCH bpf v3 1/2] bpf: Fix packet pointer invalidation for skb dynptr writes From: "Alexei Starovoitov" To: "Yiyang Chen" , X-Mailer: aerc References: In-Reply-To: On Mon Jun 15, 2026 at 7:14 AM PDT, Yiyang Chen wrote: > skb-backed dynptr writer kfuncs can mutate packet data, but the verifier > leaves checked direct packet pointers usable after kfunc calls. > The bpf_dynptr_write() helper already invalidates packet pointers > through clear_all_pkt_pointers(). Make skb dynptr writer kfuncs > follow the same rule. > > Keep two verifier predicates for this. CFG analysis runs before register > states are available, so conservatively mark dynptr writer kfuncs as > packet-changing for subprogram summaries. The normal verifier path uses > the checked dynptr argument and invalidates only when the written dynptr > is, or may be, skb-backed. > > Global subprogram dynptr arguments are prepared as unspecialized local > dynptr pointers, so treat CONST_PTR_TO_DYNPTR local dynptr writer > destinations as possibly packet-backed. This keeps packet pointer > invalidation sound both after global subprogram calls and inside global > subprogram bodies. > > Fixes: daec295a7094 ("bpf/helpers: Introduce bpf_dynptr_copy kfunc") > Fixes: a498ee7576de ("bpf: Implement dynptr copy kfuncs") > Fixes: 5fc5d8fded57 ("bpf: Add bpf_dynptr_memset() kfunc") > Signed-off-by: Yiyang Chen nack. pw-bot: cr