From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1CAD3BB699 for ; Wed, 17 Jun 2026 07:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781680985; cv=none; b=Fn8Ego+KXMoazcdvcsdggrJo+Yck4NTJtUZb6bSd4RIflrjfIAiF1BQ0wWTteBZwkwNk8zv230itNLs3TDfCRWkfZgJWj+swO+4zG7sKODRErBhAVFMMjt2bm2YuEdGtF/rXTyBI0AfESFc0WW2QZsW1whvaGaeF7ueEi+HcmQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781680985; c=relaxed/simple; bh=r8xBKlipwM2cVdr5+5sYdSIIXr1ecXhF0buFVvm84nk=; h=From:Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject: References:In-Reply-To; b=CSQ1exlxO1CKetty8TRajIm6xREwm/EoMxDoabsdwFi8onEY4Q/Tv/W/HXg6g3e9yWvWSGcbe7Hz9tHcrknKYEtBrEFGKi78p+KW/nvZMr9iYmI8cY6u8bBYw4Ij30VKiqzQET0E8+o7rEvkoZqsjd5WHGvPu3GBqz2TIVooaHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OvywwmTX; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OvywwmTX" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso68190715e9.2 for ; Wed, 17 Jun 2026 00:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781680981; x=1782285781; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:from:to:cc:subject:date :message-id:reply-to; bh=ghmwQhSHkDAwTSRuYuaKDBBMN6CrvQZmZ4OsEVLYBP4=; b=OvywwmTXjb4/Rin1JHZI5IvRYyr/sDyE/MDH3p+H56en3FJbTNZH+gyyh9CsXd8nS0 oHv8jx8DjA45JbeRWYBkwr3Pxyr9NTdYuo8vqJ6jrP6gmYydYLfh5xqzv/RhYzC4OXh/ 6IgP0mGd0ErrJ6Dnv3+cTR8iv+Xv/Esn6skUfZGwfECj5BCMFmlE+IhO94ve7ukmHnrR BHvStNa3qCZY7I38jNGCUSs/l0XD9mxv9Yhjq+7yQ3iP7ne9WYM56SIjy0XpNo4zbHTM I/x8Tz5WUJSidYqbykAq/4DQZQ1Yd/K8AM+ZaZW0/N1LjvUZeI0QV9M4F3Uy1VS7s1Tv Rixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781680981; x=1782285781; h=in-reply-to:references:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ghmwQhSHkDAwTSRuYuaKDBBMN6CrvQZmZ4OsEVLYBP4=; b=izEMah4D+1hTWsMDBRxy5QPujF2j79CAIuux2YtlGnYAf5lyUaXLG6WZ3SCFqtey0M o1rck8k/sAOU4wR4GjdhJ3WD5P9/yEazDVWgT1uOf8KF4Dm5QS8cE2Y9levMJf7S1an/ N6Jon1XkrvwXOM37Ex/oRfcTDsYv9LPIIuVWVYWTkSAtff+4LFxrGixNzmmt2rsVTOVR lIuJqNp7X75rQGJwvhcMzdi4OZNpe2ryhUFtARHqBi55tqD+N33lB131W4J7y6KpAtLU ryUe0JFxDJzWHAkVc7djwDN79jabWxQq4g2yORI46YKBvSZEcW/08qMOnEsUzyLYAx0h 3AIw== X-Forwarded-Encrypted: i=1; AFNElJ+sS9cIHX4A+rbIGJJotCuzZDKtaWgL7K0flRjkO70/GI16myVMUBLh5P6osB+nTGSKQ0Tu9EjxyAHBj0k=@vger.kernel.org X-Gm-Message-State: AOJu0YxUdhzoz+dHQq0nr+aYv0SUHkM8uG+MFsqXzNdHXCSzu25RvP+K 4FT3K91c0hV8jOb9qZXnDNJ3TEPTz+MbeI400TcmgA9ucFJ9FarZZhg5S4n6c6p2Lvk= X-Gm-Gg: Acq92OE0yVoKVa1ay+yW1LSNpjtmZvl/5fF5FkBzDCgwAWXxRmnE7I5JuPzqxuQcnd3 YKrej4Z6llkPl31KA79cLVjQaOjjg4kYjvFZ3yAEvLm5udq5L6YnoNj6AOtHYMKqszCOzEjlvIg nisrpDnxzxmXhLBF7e1oIKDARouSWnnNYFGVhV6BF6avRj9+bMN3/QY0DoVR1+ZD716zgH0EtKP fa57MdavrvoCr+hp2jonfvLe0dk2TinFPcpuxTAf1YnTYZyu63muwIBeKwNzNtdQV1rGbTAD3gW 4uvWabqJ1YhQ4bm4IKvrOef0F/otVjoNSiX+vcL/8BwR7ywWoqziCB6cIB2U1YOH2P7KLKh8XXR Ng/bUwqjnrXiyZQQo+Ynq8NrboPNqqnzRqUL1T/UN053V2bkyFNY+RvNLT2KPc/wRAvHmdmeBLB tRIMDwP8atR2xj X-Received: by 2002:a05:600c:c08b:b0:490:5057:f5f7 with SMTP id 5b1f17b1804b1-492333aa58cmr32166525e9.11.1781680981087; Wed, 17 Jun 2026 00:23:01 -0700 (PDT) Received: from localhost ([2a01:11:8f11:bb70:dddc:c199:bb35:7cb0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a0e9e4sm122794975e9.0.2026.06.17.00.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 00:23:00 -0700 (PDT) From: Rui Miguel Silva X-Google-Original-From: "Rui Miguel Silva" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Jun 2026 08:22:59 +0100 Message-Id: To: "Tomasz Unger" , "Rui Miguel Silva" , "Johan Hovold" , "Alex Elder" , "Greg Kroah-Hartman" Cc: , , Subject: Re: [PATCH] staging: greybus: power_supply: remove unnecessary parentheses in return References: <20260615-greybus-power-supply-return-parens-v1-1-dcad9dabfe79.ref@yahoo.pl> <20260615-greybus-power-supply-return-parens-v1-1-dcad9dabfe79@yahoo.pl> In-Reply-To: <20260615-greybus-power-supply-return-parens-v1-1-dcad9dabfe79@yahoo.pl> Hi Tomasz, Thanks for the patch. On Mon Jun 15, 2026 at 1:13 PM WEST, Tomasz Unger wrote: > return is not a function, so the parentheses around the returned > expressions are not needed. Remove them to follow kernel coding > style and silence checkpatch.pl RETURN_PARENTHESES warnings. > > Verified with checkpatch.pl - no errors or warnings. > Compiled the power_supply object successfully. > > Signed-off-by: Tomasz Unger LGTM, Acked-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/greybus/power_supply.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/gre= ybus/power_supply.c > index 33b7a63979d6..44bd8a72fa50 100644 > --- a/drivers/staging/greybus/power_supply.c > +++ b/drivers/staging/greybus/power_supply.c > @@ -336,7 +336,7 @@ static int is_psy_prop_writeable(struct gb_power_supp= ly *gbpsy, > =20 > static int is_prop_valint(enum power_supply_property psp) > { > - return ((psp < POWER_SUPPLY_PROP_MODEL_NAME) ? 1 : 0); > + return (psp < POWER_SUPPLY_PROP_MODEL_NAME) ? 1 : 0; > } > =20 > static void next_interval(struct gb_power_supply *gbpsy) > @@ -423,7 +423,7 @@ static void check_changed(struct gb_power_supply *gbp= sy, > static int total_props(struct gb_power_supply *gbpsy) > { > /* this return the intval plus the strval properties */ > - return (gbpsy->properties_count + gbpsy->properties_count_str); > + return gbpsy->properties_count + gbpsy->properties_count_str; > } > =20 > static void prop_append(struct gb_power_supply *gbpsy, > > --- > base-commit: 7cb1c5b32a2bfde961fff8d5204526b609bcb30a > change-id: 20260615-greybus-power-supply-return-parens-b3dd9f4a87c7 > > Best regards, > -- =20 > Tomasz Unger