From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D942E7364 for ; Wed, 17 Jun 2026 19:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781725689; cv=none; b=WnFyF6rdcoS/na2lIoklLVz6nJM/sxNAnhUIFZFlA+nn7/pJBthf23+ZjapCmgbo+OgSkk86Mv16t/tCQwsh5GS46JouKDr5Cn9zrq1soTgX1osm85nnwacMti2hvoK/5N/mSNe7NBzVlNglIouOwOmoQgzT/i1QkjlSi+5DT1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781725689; c=relaxed/simple; bh=y8KRxlDydnlMB4bwe8rA8Q24TwjQ3h3dXz9QHSatshI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=tuoMANA3pnTvR/apeGvxxi93/Bfp4lZh6PmHinJj7HQe0o+qRaCZrkE8GuisN69XDrGxKuVOsnu5EI2InpDcWXKTy83dtMkoFhE836TBVD4t81urkIRXcFX2WirI1NBl1xDxrpzmnIysQ/mkmEXvYt0blTy7Zwsej8IO5eR9fo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=xiDvOEcV; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="xiDvOEcV" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-30bcdf8232fso450891eec.0 for ; Wed, 17 Jun 2026 12:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1781725686; x=1782330486; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZvTFCUrAoOsfyHTDvUm1jrIbxnzSI3LZ0klwZ9TVDcQ=; b=xiDvOEcV+6F840UNP2zKOmtsqTNFTt9unV11MwI/pheJydIgEcypNMebLsObyk4Y6a z6FNgI9lSJY/3rBW8Hg4DwKOyR7t9CIsDp7caA9P5i8SENhEEAj38EgUPLg559kMN6sz 3tphZzQYKa43AixN2KG0pM/1NWKjmwKHu7wnnfRLZtXPgUZ+wXOeuJxdkCcqCNwO3jmG OouWs8kEHVBtj10pC/3J+XoqSQEdbCMzCPCyhSdXZNDX7g+y0V9IN3KEJRQNAwoMBanD ucLLUs2XhGXFmuWazgw9+uVFX3sDO0/1KLmNEYx//7OZk4J14lCxISDM2XE0nnZzmHoz LLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781725686; x=1782330486; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZvTFCUrAoOsfyHTDvUm1jrIbxnzSI3LZ0klwZ9TVDcQ=; b=E/6OICuNtctmaUUvg2tyhks0TSRUtfhsMBq8buxbRv5gFNlJItr654SQspm1h6zech SgDYTerUVQ7PxXU4EPi9h1yONNKA5/2tKL8PsbomthfwCy1ZYgvyNy2HacCJ89wnw3Su k31gkz//iGe97KXlQHWii28gd/mxiy0+VXsrnCv5Yarbcf2WW+vIycIxh9U6GW5mA9nt hIEbPxHjs4uZja6OqB4mtx4Mum7XzkHHhMCEnwXJKNmUn9awjRDq52iOxbfEwG/McZba UdMzy146aOAkZv1f0K3jiNTtlf0SsNp+oBc0PZCKZJKR0nU69qw23GUcHfnrP3GE9hJZ DzKg== X-Gm-Message-State: AOJu0YwKoyqXqsUZpwgTRaP7khJA1jX3qeWlRdS90TAcpVO8DQLqUujF s1FT/KEJBsV4Td6gATwG66o6GWWmlwSK1PsUPWNFbvXEBRry/WDz4RWfGl9ks5mSvf9u4lQ53kT uXNwjBy5zMA== X-Gm-Gg: AfdE7cleoTd1kCRIsi7FVvXBWuHJ2PCUha0vrhaJjwqvcYafV1f1pdMcTSU5zGrMlly as9ydjxMSPUnz72toqKm513aMhL1wQuh3tGjKVi1605N1JTJ/+4RltExRq65Uoq1ge1dp1IV/8h CjiOSmF6kPqtUOifHDVYmaEn0Pwya2rKEvzBvlngQyj1rHBEMidEFtSPnGu1l5ueMcSTK85zeFU kI7Fsf1/7NqKAhdD4qq0sjZdkg/D45uDeJSRwEW2GhuvZGwCNulKvdq5WF2aQHeNeO3wfJET2OJ oL41xrqRll6ydfkd/G/63tNHNUz0cpQ89A7mUKTYuqvdHh1oMOZEwpCYEaucC/HmpB1DdSDepnR Wxc6W9+IzadGVL5kt198cGdpDjzfBFMGKvcuDv0Kktz/tPYYWngXQZJCMT5vfPynRwPpDzQ== X-Received: by 2002:a05:693c:2d8d:b0:304:d14b:b706 with SMTP id 5a478bee46e88-30bca08297fmr3459406eec.27.1781725686243; Wed, 17 Jun 2026 12:48:06 -0700 (PDT) Received: from localhost ([2620:10d:c090:600::4852]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e4898c0sm24671774eec.3.2026.06.17.12.48.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 12:48:05 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Jun 2026 15:48:03 -0400 Message-Id: Cc: "LKML" , Subject: Re: [PATCH] bpf: Use common error handling code in bpf_is_state_visited() From: "Emil Tsalapatis" To: "Markus Elfring" , , "Alexei Starovoitov" , "Andrii Nakryiko" , "Daniel Borkmann" , "Eduard Zingerman" , "Jiri Olsa" , "Kumar Kartikeya Dwivedi" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: In-Reply-To: On Wed Jun 17, 2026 at 3:30 PM EDT, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Jun 2026 21:15:08 +0200 > > Use an additional label so that a bit of exception handling can be better > reused at the end of this function implementation. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Emil Tsalapatis Can you resend with [PATCH bpf-next] in the title? Right now it's not celar which tree this is targeting so Patchwork is treating this as a netdev patch. > --- > kernel/bpf/states.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/kernel/bpf/states.c b/kernel/bpf/states.c > index 5945956a7573..09f87e2bb1e6 100644 > --- a/kernel/bpf/states.c > +++ b/kernel/bpf/states.c > @@ -1566,21 +1566,16 @@ int bpf_is_state_visited(struct bpf_verifier_env = *env, int insn_idx) > /* add new state to the head of linked list */ > new =3D &new_sl->state; > err =3D bpf_copy_verifier_state(new, cur); > - if (err) { > - bpf_free_verifier_state(new, false); > - kfree(new_sl); > - return err; > - } > + if (err) > + goto free_verifier_state; > + > new->insn_idx =3D insn_idx; > verifier_bug_if(new->branches !=3D 1, env, > "%s:branches_to_explore=3D%d insn %d", > __func__, new->branches, insn_idx); > err =3D maybe_enter_scc(env, new); > - if (err) { > - bpf_free_verifier_state(new, false); > - kfree(new_sl); > - return err; > - } > + if (err) > + goto free_verifier_state; > =20 > cur->parent =3D new; > cur->first_insn_idx =3D insn_idx; > @@ -1588,4 +1583,9 @@ int bpf_is_state_visited(struct bpf_verifier_env *e= nv, int insn_idx) > bpf_clear_jmp_history(cur); > list_add(&new_sl->node, head); > return 0; > + > +free_verifier_state: > + bpf_free_verifier_state(new, false); > + kfree(new_sl); > + return err; > }