From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D9D19CD1B for ; Sat, 20 Jun 2026 17:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781977649; cv=none; b=IpUQFZydzgzeLf8SaovP2lVbamY3rQ92/xlYUW0vpOQvBerDXL3+djkgsG8nB8RmuF9pG4zArbqnQ4eZFMhtUjAgdw9EXZgf54PfDeIWBls1pfg1Wbx4LiPg8/zDviWKp5fRAcdPcdgInCq2BX2h9gyg6NZHP1bEq4U+zJpCh78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781977649; c=relaxed/simple; bh=mz9O4NhXNnSqCz/PQBwbu/ZRdHDjGfKV+23fwcNV5g0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=RTCELEEB4ZtGPL3BXLXj2MfnunzkRaYqnW0lNTGab69R0Ku69ci7V8OL+eehp2CjZ83gCQnVoxuyuSSjoDP1u3RP1/SNjPuCDvtLCMo7X/4GAsxMg4/9KtfwdwXvr6oLHAoH4nRlLJZDVz5lbh2KRCvqIIYmk3+C6qhlqsZkHHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h++Ux8jz; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h++Ux8jz" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-43f5927e70aso1142289fac.1 for ; Sat, 20 Jun 2026 10:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781977648; x=1782582448; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ek8DQr9nJ3BPznx4klyAIQIxgUfOyaW6fbrOfQf2ozQ=; b=h++Ux8jzA4FjEEn/KmeQWkJpHtJ2HwyT/NXi45/if/S4SaRRE/lVXcjWZy4U6VYsG2 aDVCYTlKt6PmMzW39vLfqmQ8T15RaIAJKuAh/v/aMS6qBNBHSUOPWR/QSMRMvYjgw8FU MyRsLgs97XUIHYl7VIN2e0WXKNgHY6INIa2A724yu8jiDssjrl6DyUEU84X6veAN/l1/ A0Zwx09BS/4v9gIHhPnHTFKUPf3lcFxWE4Q1xosLw+aXc4xZ5txkFANDxpx88/kPhG6I XruaAe2ayk4I+dbUJ2CGTb0AcjpfjUpJuwvBlf9l2e4FXDXhdWzVfM75a49JMbwOa3eY gjxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781977648; x=1782582448; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ek8DQr9nJ3BPznx4klyAIQIxgUfOyaW6fbrOfQf2ozQ=; b=Fb+fPQzcSjwAeMCgWLBfy5f3+PUK360RIft2rghJTOqHsV55AXDkwITbeLs9YaxM5f 2iAFLQIVt/nIVVN4rciA7Cy0uqkoLDG2mSjAsZS23J5vFKiKxv1eu3L6xdJE8E+vOzws YSJTpuKjFIlqHZ52Mg65uR7vTqckPoOjIq2g8AB4n1tquAYh+rJJyFIueliRHqEKDqO+ VgOywpDV4XxFibavbjjcd3+g1o3K/XmTxwPRwPv5BipI45i5dFD/Rr2hGFikUa5C7aRj 44Jy0bsjEqUnyigp6ScP4b6x+Iu3//APTEFvpXLoeQcar0P0sgdGD77CnRZnSiYp8BH5 gi0Q== X-Forwarded-Encrypted: i=1; AFNElJ84eqA/6CKPR+oHrlWW2Dsdms3ggWZ9cCeBJJ5whj08fBPZHBrMHH3gmUc8XqEbcHcZXRfM2i57n9Sgilo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0rjMNSihkFOo5aR9qdh81GUGkT1RQb08HpxpCbZlJY+gCb8YT CqdkFWh0T1vRpVYzf6dLrMSGEKWvbLtfUKA2JvhD43XUmI7enwggBUPV X-Gm-Gg: AfdE7cmDYauNlLiZ/iyRzlMKp45brQtK98YL7MACQ0YQ+nAE13fHeGeWvk2mPZxdpUj YJO8pdEdzb0DCTJxDTKabLzXaz/gThA8+4H3iX63tTGUK/PxDDQlrz3Ya8+UEQzSMrnRW4no8bb ltwSsWXzsKw903Bxzy+vuZhmSXIdAZjCgKCtpbaE7yVOxPaso8iSQBc27170gm3UCHWchpXp1Va ITwAUA5gpvVCt2UJ+7avnjPro8GFqK1snRTE3zi9nTHy1uZXNLEzjZGecr1ePWk0F6b3Ci4oS2L KA65DubYmmlP4wQb8FlZO+HxuHw79YpFd0BgI5Fx31jIDcR5LIHD/b/DRGhC+6B9igz2p4B9Lzo 3iwDSvbUKI8wuF2l/vJwLo+5YUAUzZvUC986keHA1IbpFNzye7eua0SV6CZrvV+sLpvegFOxmP+ CqsF9ssjD3YEqQW4MdrUWhv7ydJlgeiBd84+Ln8oGBi4h9INzVY6JNIWilA6aZu+sh41uyPq9k+ 8zrkc0= X-Received: by 2002:a05:6871:147:b0:43d:30c1:6573 with SMTP id 586e51a60fabf-44716a6ddc6mr5057538fac.6.1781977647499; Sat, 20 Jun 2026 10:47:27 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:70::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4472ec52815sm2489338fac.1.2026.06.20.10.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2026 10:47:26 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 20 Jun 2026 10:47:26 -0700 Message-Id: Subject: Re: [PATCH bpf 1/2] bpf: Mark bpf_get_kmem_cache() as nullable From: "Alexei Starovoitov" To: "Nuoqi Gui" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" Cc: "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "Shuah Khan" , , , X-Mailer: aerc References: <20260620-f01-16-kmem-cache-ret-null-v1-0-c146154a2816@mails.tsinghua.edu.cn> <20260620-f01-16-kmem-cache-ret-null-v1-1-c146154a2816@mails.tsinghua.edu.cn> In-Reply-To: <20260620-f01-16-kmem-cache-ret-null-v1-1-c146154a2816@mails.tsinghua.edu.cn> On Sat Jun 20, 2026 at 8:47 AM PDT, Nuoqi Gui wrote: > bpf_get_kmem_cache() returns NULL when virt_addr_valid() rejects the > address or when virt_to_slab() does not find a slab. The verifier uses > KF_RET_NULL to add PTR_MAYBE_NULL to kfunc return registers, but the > registration currently lacks that flag. > > Add KF_RET_NULL so callers have to prove that the returned kmem_cache > pointer is non-NULL before dereferencing fields. > > Fixes: a992d7a397912 ("mm/bpf: Add bpf_get_kmem_cache() kfunc") > Signed-off-by: Nuoqi Gui > --- > kernel/bpf/helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index b5314c9fed3cf..57a6ab72ae3cc 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -4817,7 +4817,7 @@ BTF_ID_FLAGS(func, bpf_iter_bits_next, KF_ITER_NEXT= | KF_RET_NULL) > BTF_ID_FLAGS(func, bpf_iter_bits_destroy, KF_ITER_DESTROY) > BTF_ID_FLAGS(func, bpf_copy_from_user_str, KF_SLEEPABLE) > BTF_ID_FLAGS(func, bpf_copy_from_user_task_str, KF_SLEEPABLE) > -BTF_ID_FLAGS(func, bpf_get_kmem_cache) > +BTF_ID_FLAGS(func, bpf_get_kmem_cache, KF_RET_NULL) This is wrong. Nothing to fix. It works as designed. Instead of sending broken patches do your home work. You're saying commit a992d7a397912 is buggy. Read its commit log, selftest and the email thread and see why this patch is wrong. Such poor quality patches undermine your other legitimate fixes. You have to step up in quality. pw-bot: cr