From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403AD38F65D for ; Mon, 22 Jun 2026 08:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782116628; cv=none; b=XLxWcq2KWAJsjsm6MLrBsTTlINGAoVqB5HoNOith07BZLAUIcT5FS8OZ3u33Fw4yiTjvLi/0PbrNv6tXCDXE9BXHkH8J/BdsEsZPbM5jzX3verwicyJyKHv/gQ9VL9w4mIJF30c2jmvCM19sIYiNktUuJBt4pSb+6u9m7VKpXEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782116628; c=relaxed/simple; bh=QayaNVYMdk0y95PRvg6tdQ2LISbdzw2ou3QRiLXOzkc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ndSZarN13RFpFFoSUc4kd9tCqH/o3w5fyS5rKuW77GyuHmWG+xSTsuM9fUkg2m5rR5TmN1dlOnyZYcks3A1fuwbqug7iJk1Mz0FS8hQKa60U5HV9B60FmVRqGNFbAkHeWf7vbDToTvd5QgUURDl0m0TUDDJv9E+xXvhlyGqGguM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=tJlpr39N; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="tJlpr39N" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c0c41ff84a6so257616266b.1 for ; Mon, 22 Jun 2026 01:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1782116626; x=1782721426; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QayaNVYMdk0y95PRvg6tdQ2LISbdzw2ou3QRiLXOzkc=; b=tJlpr39NE7yGwJMaIA+4fM/aUP1Hj/FhwSsW4fmioS66ZE3OOwUcuWDkxxKVorhLis ZMgOkPIMXJQe+NTG5ZYUFKC1TkiBSBqKtGC7VCVYnihn2NP+AObCyhcwr0k99YRahxiN Ut8EEBIEMisEfVkXJO51acgdZVEq5FvPCJIR11zF6xQfdRy6LBjqUIw6qH2RoIglLiIF FqgRTlmv6E9iS5OQu8dskQDGJ+6Gp4luIohKuR30FITZCi48YwX3TgPH/IQ2nMW2uXcJ 1DfMYK0YHbESilAQa+voh/KPbAutCuxeBgfUBsg9UNj/I5+5DrwJvBlGwqm7pL/rbVom oesA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782116626; x=1782721426; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QayaNVYMdk0y95PRvg6tdQ2LISbdzw2ou3QRiLXOzkc=; b=XELIuFm/P6IUcOkMt4WQcZ9KNSxpyXCMhb7EIiEvoAbGuVqWrEiLG+nXq/cSr3o6Gv KUfJ3qchICzIe5ekC7+0hlFZ/80mo4hbSPJVxhd8mtYNIeTLPJlRD2j+UFOHevDkjudf BMkWQhrAfeSrDi2n/Z7aT9BrJXVPjzistLOWPXx1Ai5XOVt+3GB3oIYaakiSLykvRT5g zxCnjl5BfL3hULP/s3BkO1qJ2IhTCwTUVZKLrK5D2je9bVylIrN001VK9WMIboTfpjtL FNTEc5sbbhIWPpx9z2nhV+arHdgtn3isRv4EgTENhCXAF+ubkNvp73PYf+Z3oZFD/4iS e1MQ== X-Forwarded-Encrypted: i=1; AFNElJ+1rWUNMwvVvrb5bxKuQ07UHgn4GOyrlNki9h3OHDcyU4XJdgwBl3eRtSGg7HThTAULzHtT8Tug09lmvBc=@vger.kernel.org X-Gm-Message-State: AOJu0YwUBgsxT5c6TPUhVAyv5HTsO443nwLNWmzAY7AoC/W7DYBw+yiD D7yopSN9Z2qTqkZGuoQwdbPTXwk5uR21FQv2SqngGa8DqBIVG+gzrTp/9PdftNqsWlc= X-Gm-Gg: AfdE7cl1W7SDXt8PwkZEhev1qCub8vivWjnXp5EXCVKzIWo2zqYZ1tyfaiGyPvsVXgL gjDqyYQdBkltwzdw/ga0mR7zH44GQjTn3SUWWgHuZ2g/0QcruSuHt6gzSLGewIgPOSPup7BSr29 RgcipXd7EszUsn68wX9PLZsgTrCoRqcbGqSsdrmmpw7ZeeLJzBBS9DKAOZB8nVkr7jlHuSfRhal Qp5q/FghtVrHQwcHshLEO8HMZTzfnoY0nJFMyMQOSAefInTe0uQQsnuRM0cGjAwCNKQ32sIaU/B vf978xhjcIq7gteCmT1YeEIhYKNQt4FhrXgWK6s6fhl00ZOHN8DNqbNYrH8yl7aD3xbQLJG98fa 33lN53mPdVqce5UksZ5SkCnbWUvjSe5Jt7rF+PxHCwt+znwIW9UQ/7i0s/LXVSHB/LFsHLsc8DQ 6IjHl0uLGbzBUiouA/RDpcl5/yEj8wytZgSni/AQFjaaGBCA+BO9TwMpzI2VPShBvOUphKAHG+H nnPG6m7DPWtb4u7vhvhC/d6PRY= X-Received: by 2002:a17:907:3e9a:b0:bfe:ed74:524 with SMTP id a640c23a62f3a-c098f33a0f1mr679421766b.51.1782116625717; Mon, 22 Jun 2026 01:23:45 -0700 (PDT) Received: from localhost (2001-1c00-3b89-c600-b4d0-bc9f-f60e-913a.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b89:c600:b4d0:bc9f:f60e:913a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c60ac97aesm310087666b.30.2026.06.22.01.23.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 01:23:45 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 22 Jun 2026 10:23:44 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH] arm64: dts: qcom: kodiak: Elite-ify LPASS macros From: "Luca Weiss" To: "Konrad Dybcio" , "Luca Weiss" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260522-kodiak-elite-macros-v1-1-487661ac1270@fairphone.com> In-Reply-To: On Wed Jun 17, 2026 at 12:05 PM CEST, Konrad Dybcio wrote: > On 5/22/26 4:46 PM, Luca Weiss wrote: >> Due to initial kodiak/sc7280 bringup being done for Chrome platforms, >> some Chrome-specific bits still remain in kodiak.dtsi, like the clocks >> and power-domains for the LPASS RX/TX/WSA/VA macros. >>=20 >> Move them to sc7280-chrome-common.dtsi and put Elite (q6afecc) >> equivalents in its place. The qcs6490-audioreach.dtsi file can also drop >> deletion of power-domains properties then. >>=20 >> This follows previous commits moving Chrome-specific configuration to >> the correct file, leaving kodiak.dtsi for Elite and >> qcs6490-audioreach.dtsi for AudioReach. >>=20 >> No functional change intended. The clock-output-names property will now >> exist for both Chrome and AudioReach devices but this shouldn't have any >> relevant effect. And WSA macro clocks weren't added to Chrome because I >> don't believe this would've ever worked given it already referenced >> q6afecc and the nodes were originally added during AudioReach bringup. > > I think it's better to keep them, if only to make sure that the result > of dtx_diff isn't outside the expectation of a commit that claims to > only reshuffle data for these platforms I documented this in the commit message for this purpose. But I'd argue not putting (likely incorrect) wsa_macro overrides there is the better thing to do. Probably somebody should've taken care of the Chrome platforms when adding the wsa nodes in the first place. > > It looks OK as-is for Elite and Audioreach platforms (for the record, I > checked rb3gen2 and FP5) Thanks! Regards Luca