From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012040.outbound.protection.outlook.com [52.101.53.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B253B2D0A for ; Mon, 22 Jun 2026 15:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.40 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782142378; cv=fail; b=VxhbmOSoN68EbRIHDugYt5rX0XXynb+puN8+ypqy9SnG+WeTZcZHpfTqM6JEnqwlEYrMiOHPGW9NjZOH6C4z+2AREsjyPHyS7OEfr38yWI7AxPsf0U7/KMtu36WgweLXI4z6CTCWMhRRBgxRPD8h3CIqBBktEuNlceTajoKfoew= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782142378; c=relaxed/simple; bh=pJkS3lWtz18HWU/XOZYTNYQn+y0XmLvfsCfb5Hdl0u4=; h=Content-Type:Date:Message-Id:Subject:Cc:To:From:References: In-Reply-To:MIME-Version; b=Zw7ZIOcfcQyvn0XItyUTssMoxtXei/xI/ZhVU4eBMTSHRJ80CX4wh7JSRD6N/GWMaSZ0d+xpsM0OETEusMKIPzq72M48+R5Ka/ToZTuEpDy9O0m1kREcjhXzV/UMKKJIXqwMK8aiyYd5c6wkVM6t5LBx0bwUQy08RcsBdaNsL7I= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fZ1w5Nbl; arc=fail smtp.client-ip=52.101.53.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fZ1w5Nbl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RxhN8AWziSGEoZosbqPT1K9X7zzYCTCkEwwdWb71Xnce2uPGiiP3Pnphzjajg9lO71pxYAWEkxS5CUGgo7NwTitwS0MgxihV6hmec6Z/TjLs7KpEysxhkzHn9oi63R9124uWVlD8KhES0SVddUAHMUWKxc/olnHcljEmBqyPh5jhPx4qzrJ2RIYlp+XfbkC3eMjcoPB3+hWYDaO0YCgnJC5BfNlyIFxtpG1kq4vUofPSi669FezpQtSYkAR45BFS31SDW7/Vo3KZS0/iq/oC5ouRcPZDCWAceLY6UJpU8kX1V5FgR0rlzM2UwmRU9rSTisf8X3yLKurUT6Zpd1am6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=27FTpVNmsrAGKj3FyC1TMfaT+RpmXRWa30jDYiMxIPc=; b=FaO7vjOA33EThIQRiEjBHamvoves/8zl6CKlM5CtfWPWPpiXOLkG/c/BOG02nXbAaXHKB0hE8wH7bu8sDJlnwht23zKATYOjsdmqCAzaQ7qBAVuPxkX4TO3NL4T3a4zsC/doIYHOkwQEtBnWYP7j+I7hZkkaTYOeghoiH027Qrj2ONgxJbHcuPYSTnWB2jFegjeGazqOyn4RrSvWNSm4I4gA1oodatjvLn7IjG3BVtuV2sUAY9VjJsCV1VJIpaclE1mLdMBYKVQohAMjzuO0ORk61XMZ+JAXA/B2je3s3O4IvkjPdM6kpeCAWZ2f5YYwUCnzKxwslxEc89j+yVZsCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=27FTpVNmsrAGKj3FyC1TMfaT+RpmXRWa30jDYiMxIPc=; b=fZ1w5Nbl6W5JJGXwNsCNPzV58tKCEcgR3dXOXOl9yN9NY1YppS1hEkxnaWgVu+Mw1xaIN7gG+ifC/lQM5TcdtSjA13qTSInQCxcxgVGSO2rN4Uy1abLAAnMB3N6dxWmRh2E2ERq2youayDSFthvBzprWkI79/Lg5u6eOtaZmDl5BngiAeGOWyFQnSrsOrzUDbA5DFPbWG57NbxLfQUwGURyPh+rIIFAm6t7T5g9tLTWVRsvypxMLonp+zeC9LxLWnMoY6QKM4wwx80slie7vt9RTHl3dqqKMC5/lenL7A2n8dOu+1H0/ClgcHZVEqvN4CT0VUL/oQSLIrvHczzRyBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH8PR12MB7207.namprd12.prod.outlook.com (2603:10b6:510:225::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 15:32:43 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0139.018; Mon, 22 Jun 2026 15:32:43 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 22 Jun 2026 11:32:40 -0400 Message-Id: Subject: Re: [PATCH v5 1/4] mm/page_alloc: only free healthy pages in high-order has_hwpoisoned folio Cc: "Miaohe Lin" , , , , , , , , , , , , , , , , , , , , , , , , , , , , To: "Vlastimil Babka (SUSE)" , "Jiaqi Yan" From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <20260531055829.3636554-1-jiaqiyan@google.com> <20260531055829.3636554-2-jiaqiyan@google.com> <84a0b176-8534-e03a-9e6e-400c74ddab0b@huawei.com> <45290F97-B8BD-4A9B-934E-0A122A5F3A80@nvidia.com> In-Reply-To: X-ClientProxiedBy: CH0PR03CA0023.namprd03.prod.outlook.com (2603:10b6:610:b0::28) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH8PR12MB7207:EE_ X-MS-Office365-Filtering-Correlation-Id: 05f69afc-cd25-4e08-1ffd-08ded07380ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|7416014|376014|18002099003|22082099003|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: j0krYmD1t0DE84WxmRqYfNA/D0oQTgSMGigITZZSfAARbvdrlNnxEaAtA8/+aqLmdQ2T+wD4O8xMVe3w+PC9gFJ6fb7x27Q0f5lC2RFGoA1aeHqFojiR/s6FmYPWMTrTTM8ziV15Ljlc0UaB3V5bOSKhLE/BpdPrQmTBaDO+neJqgx/wWWole0kA81yux6qv3uH3kzGsJD7R3Li4DXXQTS4+5E5dQZ+Di8y9tCyVCa92e51zK6nA5iu5nyllJd55T98g2imvNJJ4k8medmkvK1QZlabMBW900Z7oBSshgmljnycKXKpMqh7p6sxq5ZQfxwsdhNwuob64nwF5c91fkmiLvH+ESNAKdkbPhL5rX7gEANfSb/MkJFldgV11HuTSevHrEQKwjRTTWqd7U0VHdvyb8gXOYEBghFAmk8fIVBn+3rOBT423PjEG6RUt7QGgNpm905Qna7zi5gXDoamSufpIuFkXPL6saMcDoz7638itappflbubBTAw+r95xYhnrC8qjLYsNEoyquUtAuazo3l48NWgeae7fuhr8WIOrlviijJENmIJEPKRBFFHC54YVMHFp5UY9Q4EbuyWkYxOUi5Ja2WBjl5sPJqB/s17L4vPeJvuPP9YJCgnfkt29Om1taVtp5HqWgfASlmINE+hkSOucUBfyTVYNdgfBSRDnuU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(7416014)(376014)(18002099003)(22082099003)(11063799006)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3R6d0NnR21CcVhzNy9GOFNpUXhkZnEvWnhDMzI2V055NXppcENtVEJPbXc4?= =?utf-8?B?RnlzaitEQ3FCbUpnQkdxd3M5bjVqVEE4YXlvSGdNeUdDcUlKMkduUE5pREhR?= =?utf-8?B?SDhUdkplV0tiT2o3ZUdGd282ZWxydDdpZ0NqRmR5KzlZbnpZeU1xT0JtNUhY?= =?utf-8?B?YnB5UEZDT2J0R01yY2VwZXc3cFI5eUhScVJadlBRRE04Vk1XNlJMa1J5VElB?= =?utf-8?B?OXQyTjl2eEdjZHk5TkRvTkM0QXZKQkN5bUhURDFZaS9BNmtyOW16MWFZMVVB?= =?utf-8?B?cENCblVrNU5ZN2R6MXluc3NjU2JmU1lOZzJlUHhqV3M2TTE4bVpkdTk0UFYw?= =?utf-8?B?ODNkaUtHUmVpUXEvS0w3bXZPdFJ6NTNUK3RYbHlSeDErbVNmRHNmZDg5emY2?= =?utf-8?B?a0Izb0g1cTFBWWpkSldlcktwSE1BQ2tVbTE2dkVGVjd4cWE1cmJ1Z2w1TVVV?= =?utf-8?B?enRkNlY4czJ3SGs1QlRZRDJaaE1vT2tCUEFoUGE3MkhQaE04dVllL2NXTU5G?= =?utf-8?B?TWhheXpkSjk3MUZhcG9sRkVXOHFUbnNvRFAzTUtockg0UE9tV1ZMUzFyU0sy?= =?utf-8?B?aUFnMVhyeVM2ZEwzRW9qclVWVjVHVFhKVTNONGtDMnllRCthOW5remIrOFFW?= =?utf-8?B?Rkg2YkpUaHVHczdnUFlYWEtmWWtnMlVvOWpxaUxKYjhCR25UYys1NGlmRHph?= =?utf-8?B?RW1mbXRMZWY2S3lxZkpuYUhncGk0Q1VwM2c1YjJidnI5Vyt2TThYa0JaSERv?= =?utf-8?B?NHU0eW5INU1yYi9JNmJ3L2tZTTMzdnVOVU9mc3FneHE0T0xFRk1WS1oxZHUz?= =?utf-8?B?TE16QTRWTWZyaEN3eVV2MWtuVEdQYy9sMUYrNVNtUnJicmhkeU4wdmlFTkpD?= =?utf-8?B?NjIzZE44b0VKSHJ2WlZkb3NOOU1ybzlQdXRqSDBFanpzamlGdDRBVnBDODd6?= =?utf-8?B?SkNmWThxT3NYblJlM202L1JhUnVMenZXZEV6bmo1dG1Ob0FrRVpvNk43bmkw?= =?utf-8?B?cDNWT0YzQlhtcmF4MFFpUC9rTEs0WVJ4Q2dIM1htTjEyUE9TRXpwZThsMkQw?= =?utf-8?B?QWV0ZzhUZ0xuVDIzUWZRU0pkb1E3NFhXUjV6dDVXNUZheXo1cE1KQkt1TGIv?= =?utf-8?B?M3BBeWdkbkpoNHZhMEVCQ08xd2hGcFcwYXd5bCtOOE9MUXlzL2kvaG1MUWYr?= =?utf-8?B?ak9jUU1Tc1VuUnFkTEF0Vk9YVnl4NENmT3RPb01OaVBCcjA1VWkvU2JvN1NF?= =?utf-8?B?Uk9rRkhaNmJOaWFHYVZyN3hhQ3dHVVI3ZU9NbG4wYkZBOCt1SXZnR2ZaWlVI?= =?utf-8?B?LzZpT1RCeEpFZnJPOURvdFZwWTBrMUs2M3NRVDhhNXZXWUJFcldpcjBadk1H?= =?utf-8?B?UFVSYjNuSTNWeEgzNHZBa1B3NWlLZytORjdkdEc5SGcwbzU5RVBDUWFxV3Vr?= =?utf-8?B?N2ZValpJOUlxcnRHWWdzT2Z2MWJRNTBRQUxPUm1odlQxdWFIMHhuL1pqU2N1?= =?utf-8?B?ME5LSnlJTDBJdWVhTnZyRStnNGRHeHR5emRXYWRzVCtXQUhycDFPOFU1eXZ5?= =?utf-8?B?UHYxWThlTkNhUkdxcFZBa0JpeTJuMy9HczFkTnpNYWYxNTgreFVZaDNTQndN?= =?utf-8?B?NGgrMVRnV2ZndkVPbVVmeldCMjY4YW5NbzlkamNjaEVsVlU5R1lmUFNMVEpx?= =?utf-8?B?bGVidjNrajlPK3hqR2ZoY2hkRzdvU0hqVEdSVU1mUTRIZEM3SUlSUHB1c3ds?= =?utf-8?B?S2VlY3JkTVBEak5rUnU0VU44UGF6U0wrOHRESnpXUmp1enA2UFVoZm5Ybnli?= =?utf-8?B?OCtLVEc1T1ZGTFNna3BmV3ZRNEUxNWdrMVZPOFFYaU5LR2Q3R3ByYmo0RDh1?= =?utf-8?B?QWJjQTltekJsQ2pnMUVoaHRUWHZVWGFSU0diSGJlWFRLcnQ0bUQzVHViSm5J?= =?utf-8?B?aC9hblhaOFdYK29xVWJlSFpGVFRMOWZVMjNhOXUvMEVxck1Wbnc2alZ2UXpX?= =?utf-8?B?NmJiV2srRVhsckxzRU1wNlJrcjRsQXhJWlVXOUpUVGt2aVR3ckppZWIzSHho?= =?utf-8?B?Q2F6WDJDUlJSMTY0Vnp3TVd3WEdrQ2tYL2xRMHVnMFp4aURncllmczVHd1pk?= =?utf-8?B?WFJ4R1MwMFo1RVlXa0I0YS9JclI0TVBCUS9lZ21rOWRsNmdnT2lKckE2RFlr?= =?utf-8?B?c2M0Tjd3dERuMU9nVGZvb2hyQVk4RDA0YUt1UlRrd2ZwbEtQK1ExWWh3TEp6?= =?utf-8?B?akV1M2JxOXU4WCtnZFFvTlZXRkNUd1g1UmswcUxWVDNFWGZyc3dIQnRNcWht?= =?utf-8?Q?Geo2g5ehW04Oi+kdRv?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05f69afc-cd25-4e08-1ffd-08ded07380ce X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 15:32:43.5085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kX1oRo6gm6dFQwKLkMZ5v+dHE/LtWzUMOvCDObH/t4MYRer/9XLtTq5jW91frCgj X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7207 On Mon Jun 22, 2026 at 11:20 AM EDT, Zi Yan wrote: > On Mon Jun 22, 2026 at 4:35 AM EDT, Vlastimil Babka (SUSE) wrote: >> On 6/22/26 03:13, Jiaqi Yan wrote: >>> On Thu, Jun 18, 2026 at 9:04=E2=80=AFAM Zi Yan wrote: >>>> >> when copy fails with EHWPOISON), the next list_add() is going to ca= use >>>> > >>>> > I think we should fix compaction_free() (as a separate patch precedi= ng this >>>> > one) to not proceed if prepare returns false. It could in theory alr= eady >>>> > happen before this patch due to a random memory corruption of struct= page >>>> > causing some of the existing checks to fail. >>>> >>>> Something like below should do the job, plus >>>> Fixes: 733aea0b3a7bb ("mm/compaction: add support for >0 order folio m= emory compaction.") >>>> >>>> diff --git a/mm/compaction.c b/mm/compaction.c >>>> index b776f35ad0200..b2104cbe63477 100644 >>>> --- a/mm/compaction.c >>>> +++ b/mm/compaction.c >>>> @@ -1876,10 +1876,12 @@ static void compaction_free(struct folio *dst,= unsigned long data) >>>> struct page *page =3D &dst->page; >>>> >>>> if (folio_put_testzero(dst)) { >>>> - free_pages_prepare(page, order); >>>> + if (!free_pages_prepare(page, order)) >>>=20 >>> ... for other cases that free_pages_prepare() fails, this is >>> absolutely necessary for correctness. Do you mind sending it out for >>> formal review (I will be happy to help review). >> >> I think it would be faster if you just added it to your series with a >> Suggested-by: or something? Unless Zi objects. The change is straightfor= ward. > > Let me send it as a hotfix separately, since Andrew prefers to have a > standalone hotfix to avoid splitting a series. > >> >> I'd perhaps do just a >> >> if (folio_put_testzero(dst) && free_pages_prepare(page, order)) >> >> to avoid the goto? > > Will do. >> >>>> + goto skip; >>>> list_add(&dst->lru, &cc->freepages[order]); >>>> cc->nr_freepages +=3D 1 << order; >>>> } >>>> +skip: >>>> cc->nr_migratepages +=3D 1 << order; >>>> /* >>>> * someone else has referenced the page, we cannot take it bac= k to our >> >> Maybe in the comment here add also the possibility that _prepare failed(= ). > > Sure. Done. Link: https://lore.kernel.org/linux-mm/20260622-handle_free_pages_prepare_i= n_compaction_free-v1-1-fcf3b14abcf7@nvidia.com/ --=20 Best Regards, Yan, Zi