From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B0D234973 for ; Thu, 25 Jun 2026 16:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782405865; cv=none; b=aXYPayTQipqZLP61fNDa35nBotg6UinfZt8s6Mlaxn6XRWAMAvGYRjbxqsNxzVNmNB5Q8BPZexKNNBGtfy+IMAcITDlDY1D/Flya+0FiwQBo8tQfuonyOqHkpfDXx4OLOQUG9TlvI7UAolgPQDakIcD46HzPU0nq69bv8lbKHPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782405865; c=relaxed/simple; bh=P2+ReacPCeqU/fKo9jBbrql6rfmKkcgJUzlpxwAN/o8=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=ZiPnUEJaRY9EwftckMZOJjlgWIJaR0zd3+cqgZ7n1wlxYlH/6kdLQ/40hvIcQzwulC/W+HjXZLjnECQ5CH0SZSAHSAgX6l/NIKYad7cKhN+hengvFl3coSdQLXg2WE7TkBfEixPNMV5GSqUI2QEaDWqeeg00YScV/kqkz3c7Uh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EMJMIzE6; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EMJMIzE6" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-6a0e4f0342aso8285eaf.3 for ; Thu, 25 Jun 2026 09:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782405863; x=1783010663; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t7W/ggTwnqmzWBnV2WV1SHqoLx9vAqZSkSoEPfkHk5g=; b=EMJMIzE6YZ9QJzbgGckgqJ4BcvpUQQv61rNrBh7KyGzS+927hCTboE4mKXsWuZpPwv yZs2FP+wZpxxmf7LMIduAZXhhj9SezF4VF4DXQPFZg369DINm2bK74N1FgmCHQq+ULkl qp+wXlYwzLgNlfO4TssOI9PbeSTqds5WFxxx9WBkrpPF/xw6HaFabsm10Lmu2hQ3jp72 NlueDYdo9Czm17ifriUAc+FqLgdiUxI+tQQRyZkDodGl9JDKHbLmcrOBeB5fO2LHRGAQ iIKtd8/u4CD1NEKyRAX61Jd2d7mYv6egWzzHD9qDe53TPjClS13YhGUJQncRLmXp+a6N SfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782405863; x=1783010663; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t7W/ggTwnqmzWBnV2WV1SHqoLx9vAqZSkSoEPfkHk5g=; b=JeV841flU2vLqaUdHQsWCRr7u7dx38tIhSxqxHqbfDd4Plr004aPfYPOEInVaQI0fR kz/vg867ZdBX4I9tB4UNjudQWiNHQULqrsgoI3Z85wXvegWcuE4UhAnn37Fp95RDWc7r 2aKdCUcqC31cuICcrRBnEeezsPDuTu94pQUWv9u15clIljKnQZv45QJ4uawX4hZse7B8 PSW+tzOo0kZIPkwElwfKEkVom2AlsPZf3p8KXZtPiqNF79lcyJHmOnSK748os92FVcum bxvLNljWbtjkCNdMHvrAJGegCuW2Ahy0S4jxLU7RNVW/rDnnfnDSH7/ToiO/dq4qSeD4 a8PQ== X-Forwarded-Encrypted: i=1; AFNElJ+I4pdBbs6FdNwdDYRWyCfdu4OBc3uuWyBE2afT+EsgnAdmEucxDdQVTMncwGB3UZ6CYZym++NLN4KY5do=@vger.kernel.org X-Gm-Message-State: AOJu0YzyNz7h/pxuDdgVHFEh8HJwYYoWezdkWrZzuFKO6ayojbUGjGeD ddN5Sjxbn+W2te3AxeCIq8Xv7BAQCpaGuS9P9Vr8rAT3o7YkqJzKi+im X-Gm-Gg: AfdE7cliakwLk856U9BTqZoAaAqPQc/MWL/ToMQMia7GY8/4qJ8vacyLTTTvB2RiZ8p Q8lJqKXywfcLwwYKig6DlrSYeoTk0LJ713b7UoFbJPhwruHU+vPIE1s2xq3XOTpOfNvmrk7duos qKQaXFAwOMqnBm+kTN3jj+Y8JrgWQpuBMGmaeSQLqHxwcKNlEdXrOLmjtsgm4KNMTftyZ9Gaicr o7BzmrT6BWzkYgqqEj8dZJlCy1xF37cdWRYhtpSFic03OZNXh78dB9WaelL8j3f9XdjHnA/uKI8 z4MYUk06kfCaGa7xuj5ZylNNZzWnshL6zTeCuw4uJZEvZrve+nsdhMfXSi4N1MQxnZ3SGX+gIQV Jl0fpmhU5K4D4POCezI0/BVfqQ5zHGlME67jrzc3siVqGVwLpA8b5gY5/0lQ+R0W+6Efy40DnoF ajsYo71s+LgaMRQ6WNoyOP66drNIZszHu6AG2z6pKY5eAy+iMUyOqulEnHdP3zJm3FA7GJH/x7U Vp9mLeD2MZ0uXKdTA== X-Received: by 2002:a05:6820:814:b0:69e:ab0:3f4e with SMTP id 006d021491bc7-6a13522493amr2720037eaf.46.1782405863009; Thu, 25 Jun 2026 09:44:23 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:10::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a0ea0c378csm10370966eaf.10.2026.06.25.09.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 09:44:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 25 Jun 2026 09:44:21 -0700 Message-Id: From: "Alexei Starovoitov" To: "Jakub Kicinski" , "Siddharth C" Cc: , , , , , , Subject: Re: [PATCH 1/2] bpf: preserve rx_queue_index across XDP redirects X-Mailer: aerc References: <20260620121321.45227-1-siddharthcibi@icloud.com> <20260620121321.45227-2-siddharthcibi@icloud.com> <20260624185432.32d90aa8@kernel.org> In-Reply-To: <20260624185432.32d90aa8@kernel.org> On Wed Jun 24, 2026 at 6:54 PM PDT, Jakub Kicinski wrote: > On Sat, 20 Jun 2026 12:13:13 +0000 Siddharth C wrote: >> diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c >> index 5e59ab896f05..8f2d7013620f 100644 >> --- a/kernel/bpf/cpumap.c >> +++ b/kernel/bpf/cpumap.c >> @@ -197,7 +197,7 @@ static int cpu_map_bpf_prog_run_xdp(struct bpf_cpu_m= ap_entry *rcpu, >> =20 >> rxq.dev =3D xdpf->dev_rx; >> rxq.mem.type =3D xdpf->mem_type; >> - /* TODO: report queue_index to xdp_rxq_info */ >> + rxq.queue_index =3D xdpf->rx_queue_index; > > Do you actually need this or you're just trying to address the TODO? It's a 3rd if not 4th attempt from various "people" to address this TODO. We should just remove this line instead.