From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011031.outbound.protection.outlook.com [40.93.194.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1CC93BADB4 for ; Fri, 26 Jun 2026 18:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.31 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782500129; cv=fail; b=YVU3WyWzjdOv22j2+751nBYNgCGmZtmMuxlXhmlVGY/MUpA29/PX203JAqbnsp7nOOGIB/Ma4YxMANT8zcJVrFMoRFNX5OnLX1WRxM/9SxEbjMil3kIuF/S+uPfk1P7jcsuOch+G82UbJGuspPqxL29ZnJOj/R5bYWLLloExwXo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782500129; c=relaxed/simple; bh=eSlNQ7zk0J/uNb7K/VsV+YYEUonkbKUf6k7TD9XxwB8=; h=Content-Type:Date:Message-Id:Cc:To:From:Subject:References: In-Reply-To:MIME-Version; b=cHozOiTd50XrQ8T3o+7lSQdkRtD1fiRlG/MbL6bGbvcRkxeLZb6JPdrY3op0mVpmfj8CEIHe22j6Dl5Mb1T8Rk9iU5amtGZnvru82bM5U/9yJweecqG9o7mtq0R9VQSifMpCcJ5wI5ImVkREYazJ0Wr2BI4BEV+gEj6ehR/0ALo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NnzswM86; arc=fail smtp.client-ip=40.93.194.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NnzswM86" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pdpwcoMIbOhdu5KTw+vU2qN/5Ad/UR1mlCaNqGv5oGiXJyLP2J3JeZkpztNubSKbreohWIBzt74L4KaFcx14NAB8N23BFRTkzjrIjhHpq6Py5WA74Q4BGmthYB0AtJeT0lFMcrc3C2AA7h349DW9ZMS5LBYbHmOkl5qJc84wOp+O/JcDVXWXY8U3PS2+wzOBjrzXa3NcLDhIzWD/MAEsZDGprGdCnJDvxfkZNJTu1PZH1b+UCvaDx03iTbZVMZZDpLK5QxqCiqjrXNz/MokohfVdVT5ohGBZwGQjGckkUrwt/+YYX7bkLi0ckAL305in1CAZQVFmfk3WCRvnk5c/tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qxMJ66EDdCVl2db7nIoMhA5hb6CbzRj9Xriwtb/40A=; b=kfXoo7bxbKZkJf6OwnNCtrl2srMLdVW2735WyqADMk+NaBZ2tWFVm0RBlQsImtErOAad4e1ih1sfs2FTbFgkihm+Qp7yHeq2WWRlm6evQKKGH9rPj5c9Ozpaf4HuQRoFxoKkv4BI2s3o5oAgBI2RiiGAI7p59YyfiW3RucM8tRY7TkCIUzjoqfGg75la+eCLn/K3JW2skZKUn+XHN87s3ifp5kgTGVPwspP2XEOC/NqKKteuMuK7j7Q/CjAY9w+t3ogOELi19QlEEvrwB1QPEAJjeW/JP+fABHvqXmccs+cQpZ/9wwTYQfB/QhDLK8595lvl1ro8jTUIDfjyeGem4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qxMJ66EDdCVl2db7nIoMhA5hb6CbzRj9Xriwtb/40A=; b=NnzswM86R5u2FSIFEIn9BQmaNK0NHAefkASIRzKSvYlnpvwUVcMKu7l865x/Stj13ehqqRGdABJgQa2bIH8EcT7QKja7jmRh3PBAoBwhjyP44TWylH4i/35rwH35xZfBtlXhslVOW7d6r0os4VL0WCSZtqJbY1slPIRMob/hln4a1AFDXnV/fUVqiuOQuFpFOWAAUNa5LhqOisVfOS8XlsyPxvPn6w0OT9sK4jm0zhH1tdFDAHuON42uT4t9taaAnBoWSINYIzQEHSOACQSk7dlyST9ax/fg5uC13hjUm8FWZI2nuGAjwnG7NmhC3w0CaS1KhYXQC3dBH8olNASVwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by LV8PR12MB9109.namprd12.prod.outlook.com (2603:10b6:408:18a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.16; Fri, 26 Jun 2026 18:55:17 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0159.016; Fri, 26 Jun 2026 18:55:17 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 26 Jun 2026 14:55:16 -0400 Message-Id: Cc: "Suren Baghdasaryan" , "Michal Hocko" , "Brendan Jackman" , "Johannes Weiner" , , To: "Ye Liu" , "Andrew Morton" , "Vlastimil Babka" From: "Zi Yan" Subject: Re: [PATCH v2 5/6] mm/page_owner: move free_ts_nsec output to free section in __dump_page_owner() X-Mailer: aerc 0.21.0 References: <20260626024550.25677-1-ye.liu@linux.dev> <20260626024550.25677-6-ye.liu@linux.dev> In-Reply-To: <20260626024550.25677-6-ye.liu@linux.dev> X-ClientProxiedBy: IA4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:558::8) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|LV8PR12MB9109:EE_ X-MS-Office365-Filtering-Correlation-Id: 58281d25-9b33-4667-b190-08ded3b476d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|3023799007|18002099003|56012099006|6133799003|4143699003|22082099003|11063799006; X-Microsoft-Antispam-Message-Info: ZcY4PtaWZQGLkaj7ezqkhp/XQchPXu7IzUNEGKg+QHPNn1hnam7hZk7vvrv6TDRMSEuXRt49K04wzW/JZ7qJbi/c2OmRmFjLEcCAUwsBlRvEh2lkCnHf38jB+2R3s1a82hXlK+0NXTWwz/rtG/CH2HL6DLwHQvxXP2/Pd9VHPweSIRrmUT/q8x+Q1Uke+ZzzuKk9FvQJVzCV5/0mt02r619V4Qm+pItyuznZKKmLkZuL9h7gKvSFKtQBEZP0eenggrKmqm0fZVSJuSVpsg5qz3w9QxF3Wleir1hT0tR7wBqSLdTJS8jJpY63axD1aaMNyaJxPiKp7ZE8/4AuR8MDm1sqklJzRnRQMo97bCAKBrNnqFbH0tL7iQeFFqtgxoZAbRX5vk0NOAQEEDOq/xnYzEiIy09Np3yhwSDQLpvi+FqhQI4AkLDeIdFIvdfiJ42akJz7mQsNci/Kn6t/vcvgeJ0i+avxvT0yJwrUgzNjq1FFLRhkyPg1gMQnZBjxrVjLZVov3ZOIR5sH6svNOGrNjWvvcaBKdLxSH2tOhlmqku5OWkwHWONgf47Beaqs28aG2f7IVWlIrvW6uNTxdtQxPK1PuQUgDvHeExWg5ypWH7xO/A9FK2jePfY6atj+3R28njNZaQwfhV9bmGaovm7/PWjwZv82EMXB7KLZe7HNsoc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(3023799007)(18002099003)(56012099006)(6133799003)(4143699003)(22082099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHIyRHZnWkRoaVpMbmR0OTcyR0V2UzhhNUFZQ25GL2M5RnU3N2NENGpNbzN2?= =?utf-8?B?LzJZQmZIWFRoM3lYM2Y4NzZXUmVycHd0WEM5Vi9zWTZOYll6UXJQV3RzeC9G?= =?utf-8?B?V1U3dFk1S25TZ2NMQjlhMlNURkx3QWd4bjBNKys0cTY0OU1yWGo0L3gwL0Ro?= =?utf-8?B?UE5oT0xkaTZ3dGxwcTZ0aU81dEVZVUtOV3M3Y1VNVUpObW5ORDYwRzNxeFlF?= =?utf-8?B?Ky9FclFCbHZYOS8zbHd6RzRhcGNjM1VOc0R6dUg2alVodDNEd2c0SmJ6bWRN?= =?utf-8?B?M20xL3czQjEzZW1BTlF3dEE1bDdqY1ZWc3ArM0ZEK0xqUTNKL3ZJTEZsM1RS?= =?utf-8?B?Y2dQL3dibUtuaG1uWnhNRzZWN1doV2VjU2toNlpvT3Rjb3VMdUU5YW5lam5G?= =?utf-8?B?WTVrUGQ2aHlhSUpKSGhYUFY5ZjN0YlRyakJIcGRSa2VweXlFWDFDRkEvODh1?= =?utf-8?B?dEdTNHh4ODl3QkVrNlMwdXYxZlhYNDB6RHIwSlRDT0JqYmZQZXVhQ0dZbVZU?= =?utf-8?B?R3NuRmJiN0VESUY3NmZZb0l2bEJlMVkzOGQxTUNGQmpkd01iekV6Ym1aUEpv?= =?utf-8?B?b1lFK2pjdjNGdDVBeWpQb1EvQWFyZGZhTzJ6M04rV1F3WGw2blFOQ2ZMTjR5?= =?utf-8?B?ck82VUY2dS9ubWJsZVVhbUF6TUt6bUFXL0wrU0Q3NFdkWTBENVA4cDJGUjl2?= =?utf-8?B?SGVkSVRjZCs5dFZGYnN6blBvVk9SakhQbEIxWGJsWHFlakU2TnBZbDFYUURj?= =?utf-8?B?a1kzcWNVMmJOWU9LWXZhcW5tSmR2Qm11TDNUVTcxMDFSYjdjaHd1a0xkak9i?= =?utf-8?B?c3pQL2E4bXUyUEZaWnlQQmx0Zkd5N3VHeFFTNTdZSFF3M1NsTy96bTRIS21S?= =?utf-8?B?dlE0RXp3Q2QwYTAvcFROTW1kZkRyVFA2UFZKOXI4TkR3R3R2cnRlNGRYY0FI?= =?utf-8?B?OEtBWE5ZN2NEdEkzcFZLY1d1TWdSOTV5TzN6QUxmSElhaEtaNFpxYXNMcG1Y?= =?utf-8?B?d3BqR2xWL2xKbUduemlLR0x5Rld2RzhxM2RoeHYyenBIZmpva3NWSGUyUk5U?= =?utf-8?B?U0xjQnVweXVOWG4xS3Nsd0dqMkVRckVnZk1rNWNsS0h4WXR3cGlFL2xidXAw?= =?utf-8?B?TjhjZFJjQTdjQzUvSmJvckRtdlZwOFpQQ0x2UGdFK3RpalVRb2tvTUI3Sy9w?= =?utf-8?B?RmIvU0FBM1VvdnBIalJYQlRkZ0tZcEZCSll2TjBGMnc5VmZJa2hvaHZEMHE1?= =?utf-8?B?VmozTjRidVBxS1c1MWc1dnFuYzZ5N2FGWXZWZXZjY1FpTHZVOUVKaS9DWmRx?= =?utf-8?B?Z2RKdStKbDQ3OGZhQlBFTWFuTWhYTXNKVW5laC82L1VGaFhGOTRPNFc3U05E?= =?utf-8?B?dmpTZVlEb0NQT09lcTVhQitIZTlZTThZdFVESlJ5SG5hQzVrc2g5M1ZWaXhM?= =?utf-8?B?RVNGNkpReTI0M3JqWGk0TW9TeTZxWms4N3YvbFJKL3hnMlovd2tyN09JTFVL?= =?utf-8?B?cDhjRUtyZ0wwZnY0MjhLRlNKSGU5VUVUUmp1WlJ4TWFnbEc3c0Y5Unc3VlV0?= =?utf-8?B?azR6elhHN2QwZll0UldoVU1EelhpRmlNQWVNYnVtZFVhRjMxZ3Jpa29lZGdo?= =?utf-8?B?cDFMTjhLS3hKbDhlQy8vMmEzWm5YYlNYbnY0d1ZiZWtuRDYwRHpuTTR1anMx?= =?utf-8?B?RWRSaGdkMDhXS3gvMGNYN0UwUS9uekpJZUhVTXMwVHhBelNhUWw2MkRiUE9j?= =?utf-8?B?RlErUTRGZmtObFVwV0QybnN2Tk5SeGE3YnFFbzgwN3BTS2dvZlNGNHBOQkR1?= =?utf-8?B?NFE3NDFhd25hdU95Y3Jzdm4vbGNucUhlTVFxalVQeU9nQ0JVeCsrbUpsa0tK?= =?utf-8?B?NHZxN1lPTVlwbDFhMUg5TWJPOWtJM1k2QkpCQnJBNlRPWkIzNEovb0Y3MG4y?= =?utf-8?B?V056b3dhcVFJeXgvN0FQN2hrVFdEeTFKRTNUTjRjYXRwc08za2x5b2xPcHZT?= =?utf-8?B?ZW54SnJhc1FTYmlxMGxHZVNMei9SNzJ0Yy9aWlNlMWpYcS91QkdudDRaVWg4?= =?utf-8?B?aitCTFpxcjN2TFgxdTdYcUFsMkhMeWFsaWY1bEVFcFFGUEhVN0VZTzBSazRi?= =?utf-8?B?bTVrMm5ISU4vSUY4RzdaMkVMaUFkMHR4YVg4VFdqU09ROU0wNmZ2cW9lenph?= =?utf-8?B?SFV0M0NxYm5rOC96UGhKVHlsRmkrbWZBSUh4YU9Bcm1tQzc3Smw1TlYzbjZt?= =?utf-8?B?ZTloMFd6YzFaWUFTWFliRXBDZXVVUkdRMVNCcytrTVVGKzVXdW1hdEk1Q2Nu?= =?utf-8?Q?pxSX374Ja8wuSmsHXI?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58281d25-9b33-4667-b190-08ded3b476d0 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2026 18:55:17.5304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AGaVr7l/WShfxQBQKPUnIKVFV5ttIgijrE0Q9MgXZWHD0wr0ZuUCXUJEfaWQ9g0S X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9109 On Thu Jun 25, 2026 at 10:45 PM EDT, Ye Liu wrote: > The free_ts_nsec field is a free-event timestamp, but it was printed > in the allocation summary line alongside ts_nsec (allocation time). > Move it to the free section where it logically belongs, together with > free_pid and free_tgid. This also makes __dump_page_owner() consistent > with print_page_owner(), which only prints ts_nsec in the allocation > summary. > > The output now groups all free-related information (pid, tgid, > timestamp, stack trace) in one place. > > No functional change except output formatting. > > Signed-off-by: Ye Liu > --- > mm/page_owner.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 958151ccb587..eaccff355cb4 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -660,10 +660,10 @@ void __dump_page_owner(const struct page *page) > else > pr_alert("page_owner tracks the page as freed\n"); > =20 > - pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#= x(%pGg), pid %d, tgid %d (%s), ts %llu, free_ts %llu\n", > + pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#= x(%pGg), pid %d, tgid %d (%s), ts %llu\n", Is it going to break existing programs parsing this information? This is under debugfs, so probably does not matter? > page_owner->order, migratetype_names[mt], gfp_mask, &gfp_mask, > page_owner->pid, page_owner->tgid, page_owner->comm, > - page_owner->ts_nsec, page_owner->free_ts_nsec); > + page_owner->ts_nsec); > =20 > handle =3D READ_ONCE(page_owner->handle); > if (!handle) > @@ -675,8 +675,9 @@ void __dump_page_owner(const struct page *page) > if (!handle) { > pr_alert("page_owner free stack trace missing\n"); > } else { > - pr_alert("page last free pid %d tgid %d stack trace:\n", > - page_owner->free_pid, page_owner->free_tgid); > + pr_alert("page last free pid %d tgid %d ts %llu stack trace:\n", > + page_owner->free_pid, page_owner->free_tgid, > + page_owner->free_ts_nsec); > stack_depot_print(handle); > } > =20 --=20 Best Regards, Yan, Zi