From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010047.outbound.protection.outlook.com [52.101.85.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBA2C366557 for ; Tue, 30 Jun 2026 01:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782783475; cv=fail; b=AZufjTrr7iDP0v9c4hzTINiWVWjJhx0PUG2pFHu8AfRLcQtBUa2O8VUqlg5mD1aoVzMlpxncLCiR1dayFmjEnAwC4UFyiywtYk2uP9jqrz9A5ioNWTC6KJq6YcGqmtH+E3XDUwePpo9VJxToz4lu6fhNBH97ui7pPp5rx4bVyp0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782783475; c=relaxed/simple; bh=zEkb3K909qffGzuYTogtFYdizurjMEgRvboLUKmH3Eo=; h=Content-Type:Date:Message-Id:To:From:Subject:Cc:References: In-Reply-To:MIME-Version; b=j7AbFTygLhsyeu/YGJvopzjWHxeNoSNP5GwPxk/ccpiq7fOnNnOAPrFUOLU5tl8x7oWdKInllK236NphYBQX4JtOWoN7D+UJF/TDWuN0hk/OhGJj6hFg3gu556wQIqLRVzhY12uSGkr3SeEzAbrJhDGsSY6VHurr7WAnnW6h8ZQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VJrxZ5gR; arc=fail smtp.client-ip=52.101.85.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VJrxZ5gR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qUhZfmf6KsHSbZ+6c+r4NJiu4xqjE9T2U7rK+ppLYPjoO7v2Xu7vviH+kEopgj4p1LLi3AKQIJievtbccB0kA3/NvULyx4yAvGMRzWm2MA+2I01moE0uAkF2r15n6cSZje2XN1N+2M1BXIvlMm5dtZ03eyXRFSa8vD+tqQTMzy2ZwrHVwngTS6Khdy5CGDxr4mm5l6ZZ1o8KijlbedrhVZTPQ3woZFktl7kaksCyR8lNbCFmfbst7ll95EcCfXl38hD9189javzFp4warUIUpiHO/OtpaRBIg6crtaLWz3MBqE6Rt5EgFNM/xEPZ3D6QmRLRz/u0MknRx/FCNk1Ykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zEkb3K909qffGzuYTogtFYdizurjMEgRvboLUKmH3Eo=; b=UrW+jizb2aT3CKGyAsU0E1o+97aSnKTlyZUADTIKN3oQyDWc/TyB9dx9wt/LTcwOLx5PujFo4YjjgH57KdDYidJcrDNWDpyQHbLvnhQ3vJzrAkoUZLPJLasce/jLJU1O8WXudDWs85h/Yf3JFiHnEypxJwyA0yaC7j7RgvEt/XhFre8fDRAhTgtbrVfmdXCz/w/M/zI4xdO8ajJYTxO21h0e+bgbVx9L0RshCd6jsc4cqxZo7HwgH8z1hIP2cF469HEQ+cR+29Irb24nyn1rDCPRFQr9E6VQoGKTPEXQ/wSI1HUQhWqn3MkQPozKM2a3SrzPe4c77dJIV9l1S9dXOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zEkb3K909qffGzuYTogtFYdizurjMEgRvboLUKmH3Eo=; b=VJrxZ5gRa8e/3ShT5fIosRajxGP5dugRqk8MZnmw9r6dmep+YxG+5NfBvLr98yF8OnmP2BnUAhMREyFZXx+e0StnFbKHThfeH1af0hl2OXoIcotVe/MePL5J4aX8PKGfeXAO9Dk39Fx6fLHwoi2pqPO4XI6UfyDWtaZeOefNHCvPZ19/LmdnQVNP81CvzGRCgSEF4Fnp9Nroi7Qz5Nx9zMgXeIBT4dtVXaONNMo/i8TLMUJv88CzKJmqd+YSDPyENTkzC/9h0gHSjfh59vdgZYyztvw9et/z9UfPIJt9pvCMl8enqr/xkWNzZetlx9uaqJYVrGF6JcCQL4j+uMXB6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CYYPR12MB8871.namprd12.prod.outlook.com (2603:10b6:930:c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Tue, 30 Jun 2026 01:37:48 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0159.018; Tue, 30 Jun 2026 01:37:48 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 29 Jun 2026 21:37:46 -0400 Message-Id: To: "Baolin Wang" , "Andrew Morton" , "Vlastimil Babka" , "Suren Baghdasaryan" , "Michal Hocko" , "Brendan Jackman" , "Johannes Weiner" , "David Hildenbrand" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Mike Rapoport" From: "Zi Yan" Subject: Re: [PATCH 1/4] mm/compaction: stop recording free page order in page->private Cc: , X-Mailer: aerc 0.21.0 References: <20260628-keep-subpage-private-zero-at-free-v1-0-f4ce3930d10f@nvidia.com> <20260628-keep-subpage-private-zero-at-free-v1-1-f4ce3930d10f@nvidia.com> <4154c23d-faac-4d84-990e-a9a0aec5ed46@linux.alibaba.com> In-Reply-To: <4154c23d-faac-4d84-990e-a9a0aec5ed46@linux.alibaba.com> X-ClientProxiedBy: YQBP288CA0034.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9d::21) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CYYPR12MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a6d4d16-a1da-4ecd-2994-08ded64830f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|23010399003|1800799024|921020|22082099003|18002099003|4143699003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: mCSy007LtfRXG7KX++VEHEpQZ17LpWlx0TfgqzV+XGe43NA9KjZdNgIVkzfbJ974K0uflwqaDPA8sX6K1a/PiUivRdSL1T3CXDg4X9vLJj3eLTau50wJyLbgNBzwPu9mdBaXbZb//n/+Y4T+7hdgTZpVcsM+P0PW15o+ccEEt7XRP9GjmUTWLx0qzCTFN+CnL0Z/WGincxidAY/GRsYpFo08rVUJ810+yG29aBLH8835ShVcIOGty3zdIFvobCe+zPFOpsHKNJ437pHrUsgozCpPKlxfONauYVGBhJ+P30E6zS2UtwbjIrHJq5sAxm2gzKbAUCrMZBS175oxMiNzVF2gyisWuK6JQ664P17oCJ9hBJJZQDLgt1nn11NfY+fBG1ZSSsjRL7ex3lnRygzgI2Z5t49HeOMqlW79Lh1pL7eB+YgZkWrH8iGqFE4V9BUFnjaBGpiQp89PKiPYKeJ+exCQgGTWz/5MOATV7E1GzNi7uS3Nab51Z6TvktuZcfJf9P2vGbR2+B6MU0UQv51Z3kvXmwjpmtde8/MR87ve7jBGLRJdEO9mqcTJ2b0uWhCsT6Sic/blFV+snKIwQcMGu+SlITxsK/Rqmt0a6ava6y+1TcZjJJhf/aIsAqDb5rOGO373cOLh1wJJr+vqz7kKPBY/UzoDcVUGeyz985wkhcQgxYabV33OVoiQFSW0al8KIbK44mGpa3IwEbvEMsUk1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(23010399003)(1800799024)(921020)(22082099003)(18002099003)(4143699003)(6133799003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cityd1F2WWdwOG0vV1F0WWd1dWsxSDJVVTlwNWFvZTFtNGM3RXF1d3hFWERC?= =?utf-8?B?QlUvNnAzck9ZQlZCVTR5YjkyWXh3RHVKOWxBWkhNa3Z4S0Q0eW9TMWpHTjJN?= =?utf-8?B?cE5yVUdoa0tLYzdtd0FmOHh2ZmlTalQ0YVpHNG5WTjBxdjRXMmJ3SDE1KzNK?= =?utf-8?B?YWRZSlVwU2JucUJoKzM2dDZ2VXI2STB6ZkFSdk1wenkydGJIWWlPWGFaMXdQ?= =?utf-8?B?eGhycFdoRjZvM1ZuTDhhMzhVWnBwenh6QU8vemczRXpsU3JVcjRMY2t3WXJ4?= =?utf-8?B?aWVmS0RkRGxHYkdGUlAvQTFjWi9HeUt6Rk1QWmJ2a3FLRnRZTmFSWnB5elpp?= =?utf-8?B?SUdpVjlvYVgyRFJ2ZnltVk5PcGg3ZkJEYzloWjMwR2hqK0F2ZHdoV1dLLzha?= =?utf-8?B?b1F1VzcvaFdEL2lVTVpWL3JROW9vbHNDZ0FwR2hnbE8wWmVDR0gvNm0vSDN4?= =?utf-8?B?V3N2R2dYWWdib042c1NQU09kR2ZjaTcvOStIQ1hjeGpxclA2SUthYnF2VGZp?= =?utf-8?B?SHhnYWppcUxFRUkraUpMTkpmUnYzNXpJMVFPYU45Yk9KV1pxY094dDF5TDBI?= =?utf-8?B?NDZ6L2V0amdOT09NTnRLTEdiZWNBMXBYancwc05KL3RsTWlWSlkvSWt2VGF1?= =?utf-8?B?YlYzQ3ZpN0NzaWQzSWg3RENEQVl6cmYxVk9obWRDS0V1TjgzSm92VkdnV1ds?= =?utf-8?B?TWFWNjRqaHRiazQ4OWNhS3JzdUVwZHppaG0waVBDblZXbjVOUTh6cWU3cEht?= =?utf-8?B?VE8xQ0hWc0dzVkc1cytYVmVGOHNhQnJLTjFXUzRjbktVNVVDSWpmQndqTjV2?= =?utf-8?B?NE4yQmVNb0QrZWRDS2hKU3BZUDdaWG16WHQ3TnA1MGxNOGFpS2RCS0dlNEdh?= =?utf-8?B?YzI5WTNFcm8zWlJETFRWR0pXL0xWRVBxWktoeTV5aW1OVXNDMVJPUVhlTEVO?= =?utf-8?B?dXJSbHNuSWpHcGR5clgwUEVqWGVIL2w3WVE5anZiL2FNWHZOOEF3N0pnL1gv?= =?utf-8?B?eXIvWXJKK3JvaTh5andKejN4MndESEsrK1g0Y2tyM3BqMWRCckZOTmoxaDl0?= =?utf-8?B?WmFUNHU5M1E3T3lkZmQrSG12RGdYMTBZL1VGQVZuS1dNOFZrbTVDTnJKYWlx?= =?utf-8?B?cTRxSDRtRVhTQkd0dEVvcDluby90UzVLZzRQNWl5RWptRXd1S3JYZ3Q2MW84?= =?utf-8?B?M1c0ZjJ4WHUxKzdqRFhSKzliVmdrWmNZc3RyWi9sWHM4Wk9lOXVvOSthYXl4?= =?utf-8?B?Q2tqMGxwODM5RmJxZXV2eHdhVXB1TVVWSlRETWVoaXJjVUNLRmZGVWtUeXJq?= =?utf-8?B?S1JmbXVSS2lEc0tWWldCU1FuVzZpNnNPbk9oQk53TExuVVFSMllsZHB3R1Zl?= =?utf-8?B?aFRtMXpWbHFpRUJtVEtLcnhsNUVCMnpxM3FoQVJ6bGZrMlhRRGZNa3J5YzFY?= =?utf-8?B?Uzh4MldlZkFHUFZwbGU1d2R5blFJWkFPTDB0aG9QaUJsV0pDS2Qyd3V3eXov?= =?utf-8?B?NE1ReDhPbjhWb1pWQXgxOXg0WTR4UDh2b0d4VHRiZkdzOXdnU3o0NzNIVklQ?= =?utf-8?B?bzdBMXljMHN3bzlZMGMxSmhPLzFIVHdhOHQwK1pMZVZOZ2piR0lHSHRHbk9m?= =?utf-8?B?b2ZuRE9UTUlUMnRISjgxMjVWT2syMFQ1L3FZdXRlMXNHaVc4SXY0SVBtekdU?= =?utf-8?B?TFBQcUR5R3A5cHlNaEEyR0VFdm9lSVdYM1FMRmhkMjlISHV5YmtraVBidmdR?= =?utf-8?B?QXQwWWpJc0JMR1dDbkk2SExiKzJzaUQ1VnNqdlV3SG0zVlUzc1FxaWk2TXI2?= =?utf-8?B?dlRQQ1A4NHFLVGYrdnN3cFoxak5qZElwRy9RaDlMWHRORUlva0tBTGFQYXJ6?= =?utf-8?B?WjlwTDdmR2JNa0F4K2t2YmhRSEx1QkpoWE9GNlNVQnYwdWpkUmY5NWw4MFc3?= =?utf-8?B?RGw1Y2J1c1d3RGhsMjlKNlZMKzFxdy9rTFNGRUNUNXBYV3Ntd3Vya1M0TU13?= =?utf-8?B?Vi85aDJnT3QxcGtGaDMxRFNadndwVGY1Mnk2ck9WamVZd1VWWiswMFlHWTlj?= =?utf-8?B?VnpTa2NBSXBEbjhaR0VIbTVITXNNQlZEbTJGNmdhZ1pKZ1FMbmFXM01NTDlv?= =?utf-8?B?cmwwZzJXT0JyTVM3S0szYSt5S3RTMUIrdU1DVkIwQ2p0RjFhSU1QZXY5T1po?= =?utf-8?B?dEE5L0wzaDV0UkFXblFvd0xWQmN1THBXb2x6aUx6Ulhsci9xeGc3RHZsODJt?= =?utf-8?B?aUk5R2dQMjJ5a2pCOWtIeTRiTGFLWHNUeHJsYjJONGN1TGVyODBjR2pTTmRE?= =?utf-8?Q?JwUPf1FNQASE0vxhwg?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a6d4d16-a1da-4ecd-2994-08ded64830f0 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2026 01:37:48.3501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IRV9Qlz2hwjHiry4L9NiviQ1pR+PqyXq2cbpCsGSNbegyMz1dYImHVM1cWNboEiQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8871 On Mon Jun 29, 2026 at 9:32 PM EDT, Baolin Wang wrote: > > > On 6/29/26 10:56 AM, Zi Yan wrote: >> Commit 733aea0b3a7bb ("mm/compaction: add support for >0 order folio >> memory compaction.") stores isolated free pages in an array indexed by f= ree >> page orders, it is no longer needed to store the order in each page's >> ->private field. And there is no code using the stored order. Stop doing >> that. >>=20 >> It also prepares for an upcoming change that ensures subpage->private is > > I noticed that people tend to avoid using the term "subpage" now, though= =20 > I understand what you mean by it here. :) > > [1] https://lore.kernel.org/all/20260623125723.2503832-1-dev.jain@arm.com= / Thanks. I was confused which to use subpage or tail page. Now I know tail page is the way to go. > >> zero at page free time and the removal of set_page_private(0) from >> prep_compound_tail(). In alloc_contig_frozen_range_noprof(), >> isolate_freepages_range() is used to grab free pages from buddy allocato= r >> and it leaves the aforementioned page->private set until >> either split_free_frozen_pages() or prep_new_page() is called. That >> triggers the upcoming subpage->private nonzero check along once >> set_page_private(0) is removed from prep_compound_tail(), which is calle= d >> via prep_new_page(). >>=20 >> Signed-off-by: Zi Yan >> --- > > LGTM. > Reviewed-by: Baolin Wang Thanks. --=20 Best Regards, Yan, Zi