From: "Piotr Masłowski" <piotr@maslowski.xyz>
To: "Janne Grunau" <j@jannau.net>
Cc: "Sven Peter" <sven@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Linus Walleij" <linusw@kernel.org>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Sasha Finkelstein" <k@chaosmail.tech>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 08/11] dt-bindings: i2c: apple,i2c: Add t6030 and t6031 compatibles
Date: Fri, 10 Jul 2026 01:17:39 +0200 [thread overview]
Message-ID: <DJUFA03SIN5C.1A8B6N89448P0@maslowski.xyz> (raw)
In-Reply-To: <20260709-apple-t603x-initial-devices-v1-8-55b305833123@jannau.net>
Hello. This is the tiniest possible nitpick, but it could
throw somebody off when grepping through commit messages so:
On Thu Jul 9, 2026 at 9:30 AM CEST, Janne Grunau wrote:
> The i2c block on Apple silicon M3 Pro, Max and Ultra SoCs are compatible
> with the t8103 (M1) one. Add "apple,t6030-i2c" for M3 Pro and
> "apple,t6031-i2c" for M3 Max and Ultra as per-S0C compatibles.
You've got a '0' (zero) instead of an 'O' here. ^
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index 9e59200ad37b..d39f5e3f1df4 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -24,6 +24,8 @@ properties:
> - items:
> - enum:
> - apple,t6020-i2c
> + - apple,t6030-i2c
> + - apple,t6031-i2c
> - apple,t8122-i2c
> - const: apple,t8103-i2c
> - items:
Cheers,
Piotr Masłowski
next prev parent reply other threads:[~2026-07-09 23:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 7:30 [PATCH 00/11] Initial Apple M3 Pro, Max and Ultra device trees Janne Grunau
2026-07-09 7:30 ` [PATCH 01/11] dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x) Janne Grunau
2026-07-09 17:47 ` Conor Dooley
2026-07-09 17:50 ` Conor Dooley
2026-07-09 18:05 ` Janne Grunau
2026-07-09 7:30 ` [PATCH 02/11] dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition Janne Grunau
2026-07-09 17:49 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 03/11] dt-bindings: interrupt-controller: apple,aic2: Add apple,t6031-aic3 compatible Janne Grunau
2026-07-09 17:49 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 04/11] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles Janne Grunau
2026-07-09 17:50 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: " Janne Grunau
2026-07-09 17:51 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 06/11] dt-bindings: watchdog: apple,wdt: " Janne Grunau
2026-07-09 17:51 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 07/11] dt-bindings: pinctrl: apple,pinctrl: " Janne Grunau
2026-07-09 17:51 ` Conor Dooley
2026-07-10 19:48 ` Linus Walleij
2026-07-09 7:30 ` [PATCH 08/11] dt-bindings: i2c: apple,i2c: " Janne Grunau
2026-07-09 17:52 ` Conor Dooley
2026-07-09 23:17 ` Piotr Masłowski [this message]
2026-07-09 7:30 ` [PATCH 09/11] dt-bindings: pwm: apple,s5l-fpwm: " Janne Grunau
2026-07-09 17:53 ` Conor Dooley
2026-07-09 7:30 ` [PATCH 10/11] arm64: dts: apple: Initial T603[124] (M3 Max and Ultra) device trees Janne Grunau
2026-07-09 7:30 ` [PATCH 11/11] arm64: dts: apple: Initial T6030 (M3 Pro) " Janne Grunau
2026-07-09 12:57 ` [PATCH 00/11] Initial Apple M3 Pro, Max and Ultra " Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJUFA03SIN5C.1A8B6N89448P0@maslowski.xyz \
--to=piotr@maslowski.xyz \
--cc=andi.shyti@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=k@chaosmail.tech \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
--cc=tglx@kernel.org \
--cc=ukleinek@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox