From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FDB2365A00 for ; Mon, 13 Jul 2026 06:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783925514; cv=none; b=DW5/Iz4EwW4KzHzfJ+Mopopjnss1dix5yBAA7hil6vXP+cCnFvw/zNsMu3LDgrDaEENBMr5y+t57POuvzp/NkbrhFOmht78yO2E1NmQr9XtPSbiJlql7s5z1DLzZkQbrfn4ts5YjPoTktxmRFxHa50lSgHaukiSGi6HICDfHqSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783925514; c=relaxed/simple; bh=3UZr+s7uzcW8h1DHN6h7imM0CeaJ4iWPF13rcXL8v6o=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=jl3bQIJSoj+wUtdWEzb17Eun08bUdFr1tXzH1Doy9icLUBAJ8MUPfP7RrIcsrHrWfakRKjkmhh2/FQwhHalJW1DIJSmRoKvs0TRCBJfjo0zpF8mzz/mRwnizR4+PPGy0HuhkUPnAuyV6qcxQPn9imeLsANwWA6PyN/GsWImWEEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=fuhYrbj0; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="fuhYrbj0" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c15ec1da77aso318071366b.2 for ; Sun, 12 Jul 2026 23:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1783925511; x=1784530311; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=YzKzbPipk5HuR++dvISXo/Dbcil94rLYMkCRdCOQ1zY=; b=fuhYrbj0oakAvtO4aXV2tIokazuHogcH+ITiZ21to9rLb+7IUFQDRVVFjefh0+RKIl 5ipMT82FDUneFmpyCaRK0+Mi6ZiynOJ8G01m3nphF1RMj1zUf4EJqc7BcRGPuMXB3nXA sHB9fXzbh8l09CueEimIyrnmrjIOb9+CkgQn4dMODaWbXWUaKlrNS70DXhWQfdv1a4fU ETk0s1noQuYcpPJFPNAJT8QI+78iRLi2r8+L9BFgOoN0VjenmsVEtgqT+5T48mTeFZWg q6jF8epVeWIeI/A4Yod33vAnGg2fDAQkoK63odf9KXlwNud9H5sWgdkauVEOkeqprA6a yibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783925511; x=1784530311; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YzKzbPipk5HuR++dvISXo/Dbcil94rLYMkCRdCOQ1zY=; b=WxFTyo3BzvgL1TtaRPbwbO2HWe4iA+2MXSIcSrq9NDkMiKu0a+5eoC47Fyp0KeQa74 lt2FoQO5QRul/RhLzSBIsMnc4HTcn6X7lCsKMF/FJVJEohPsj0OGLKi+YV6bvZY/c2Ma qvwch+dFL6laDlk78KSX3C8S+eOci8Z7F21e8yxX6VPT3XAyKtNAWDTdTvhk55Mh+ujm uyr7ejvCq39TWxDwjm8x6Rca+XsdsJ6+fNNDU0pvtX3nTnwEzYTaM+DUVf8rMKg0h4rJ AZyX9BnVgOKNE/u65CSDR+5ycOPBYmkN0v9AFfriwRGo2qB5Cds2spr8UnpX/3FbWU3K vakA== X-Forwarded-Encrypted: i=1; AHgh+Rp0AjlbPwq2Nfb4PgSH5PjTcC2KI8VKj8jgIsRykYAzIznCEiQ4T6DtHt+ruAp3QD7OrSKJi8obVcFKW00=@vger.kernel.org X-Gm-Message-State: AOJu0YyJtQi5gdAQhjaw3wtCyEGahl0fRSDuRWhe6CeS2Eo8zl5VV1JM gQ5EH2AcpzgsEFt0LLALDFJeutieTTbXCBdiBjzEaiIBXp24qUv1dA4QmNmlilYDQtM= X-Gm-Gg: AfdE7cmzTA3ES+Jnd5LlgVfb/fSM61wksKTaHurjeg0VLu/YyZVeGktt5AaJxZqrgId l/9mBuLxwX92RpLDYskJzCKGfGSY8zSKjSqt0tx9ps+bApIyIKVLaR6Svs/v1K0ckOkm9dWihiG 0De7yu+RP4onh/AtIAukC7XE8gFHrGqBSoNfdPFZBMh7KV98v9zs3HJrCtFDMD2xoW2Ju10+VaL NV+HOLjJmpCVMXrRiZEj3hWronYkzdvqP5fdB4Qdpbs2cNW7E4WaFjzigtBAIdlmRJa1de4Lj4o qx30HlX+pmqZcxM/7ri0+JkXYjv6He9w3a+rgWAOensoxl0uyyJiO/99gUrHrEuvhj2fIfSVC4U nYvJQvpmFM4BSyw39MWuo9G6dnM3GzHe4wPO7mCq5Mlr9kl9SBmFste6nfou1K0zHzFhTmRM/gA dpx98xbPyrMLviQsO98Qd99Jtky02cePhV09GvopJdf/x1pruWQMchWKzGW7N9W5Z8Atox X-Received: by 2002:a17:907:9b8c:b0:c12:1dd4:13ea with SMTP id a640c23a62f3a-c161e9db95dmr250567966b.30.1783925510861; Sun, 12 Jul 2026 23:51:50 -0700 (PDT) Received: from localhost (144-178-202-142.static.ef-service.nl. [144.178.202.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15bc428775sm870313466b.6.2026.07.12.23.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2026 23:51:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Jul 2026 08:51:49 +0200 Message-Id: To: "Bjorn Andersson" , "Luca Weiss" Cc: "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Dmitry Baryshkov" , <~postmarketos/upstreaming@lists.sr.ht>, , "Konrad Dybcio" , , , Subject: Re: [PATCH] arm64: dts: qcom: milos: Add reset for sdhc_2 From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260710-milos-sdhc2-reset-v1-1-c7a155a517ba@fairphone.com> In-Reply-To: On Sun Jul 12, 2026 at 5:05 PM CEST, Bjorn Andersson wrote: > On Fri, Jul 10, 2026 at 11:53:57AM +0200, Luca Weiss wrote: >> Add the missing reset (BCR) for sdhc_2. > > Don't be afraid of tell the world why a particular change is needed... I didn't see any issue without this on my device, but usually the SDCC2 BCR is referenced in the devicetree so that the driver can reset the controller. No other special reasons I didn't mention :) Thanks for applying! Regards Luca > > Regards, > Bjorn > >>=20 >> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi") >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/qcom/milos.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/q= com/milos.dtsi >> index 8c9232988953..262fa8801256 100644 >> --- a/arch/arm64/boot/dts/qcom/milos.dtsi >> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi >> @@ -1724,6 +1724,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >> =20 >> iommus =3D <&apps_smmu 0x540 0>; >> =20 >> + resets =3D <&gcc GCC_SDCC2_BCR>; >> + >> bus-width =3D <4>; >> =20 >> qcom,dll-config =3D <0x0007442c>; >>=20 >> --- >> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda >> change-id: 20260710-milos-sdhc2-reset-8e61165cc5b8 >>=20 >> Best regards, >> -- =20 >> Luca Weiss >>=20