From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011038.outbound.protection.outlook.com [52.101.52.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4D5189F43 for ; Wed, 15 Jul 2026 01:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.38 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784077829; cv=fail; b=MRq9KDPc5C7fveS+kuXX6qIzv6NXXusUdndbR1V9bhfsYwBLOBdqo/HZ1vtq/5+wg347vDICc3SgV//Kc8vNA6/ppiy8jriSvJhtDzYzVvrHaIcU26dV4i4XSJuDsKJQqc9bZu8sCg72xGs8k+fLmEYsMIsJY4As2c4jM2Zfs5c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784077829; c=relaxed/simple; bh=eUy9ULnpccnUyC0Jn9GFb6Ws4VrK/IipkKRxe3khPKY=; h=Content-Type:Date:Message-Id:Subject:Cc:To:From:References: In-Reply-To:MIME-Version; b=k3dh62y6pisN4Lxt+QDEqCext09htxIzBAC7Ficc1sXUShUT3dUAHSv0V7bZ5auNxMyOxUm6RNkcVWt5elCGRYsKQVLd/WJnj8UbTr+hee17KW5aQpCejIYbtyIB/6VNGEZcR43kI4Uzralz0H3SajGNOXuFkBSCXLuJqh4M8DE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VjIl36oY; arc=fail smtp.client-ip=52.101.52.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VjIl36oY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RjFKlffGOmQ2IBaOfLxbUss0uLn2hK1JI9JlzStB/PPqHfWSX9p+QeyLKEgzCjfHNSoj9DXljUZboJr9yj+YMpzyjdzTCJRDSesjHMGTn7GcXZ5aB/T8vYuXMf3OWQyDrLcg3f/1wiiFSmH+xdaSW5EuGno6vv+cE9QoRaDZ2X7SJS+lCY1ukmhHtjzG3XeEFzkIyHt9lJ7yKDVvbG4JcsUuBKCAUA5oNnmI8KvT53d4UgUewCsnIo/frf3OkpkserTa2OxJ/J6nxcnbSO9HyzLm6IWNu4OgGqRUC/928ploJHXGBxdMy72wDCqBX66miy9e5NRPE96++XDyTHMG/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=irrhMPqVPwrh5x5VRg6r8rJ+6Opi6M71v8CmHv7AoHI=; b=jowT9Jn6M9tMPJO3tZA4rwveUkNGutvkPYpBl3KCVCqxlvzhCWBFYzWV9bs+fpM9rtJyBK0XWPLGYEEmVZNbMtVdnWm/VZZPkzjgvmoLpNeEHAqWQb7X1LN0kuW8LlkJko88OeCmYJzlfeoAvFvnW6iRWo1r7A1UqAW1aIozdMThjWnrSI1PbCLY7T82E67e3HQwS3ukcyYlnT8s+NrJdlm4RC0hK2Daw1Z0hgbOv5V5XkwBl4JPo5ZWtrSbQjYdA8iq6DaqYivCZG6ykPbzRIyeDNgHsmnZ8L1CilMNPnteel8vlo8FcpsfkA/VQ4GLkWlRG6HX+by+4TukodC1Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=irrhMPqVPwrh5x5VRg6r8rJ+6Opi6M71v8CmHv7AoHI=; b=VjIl36oYnmLW+lFtBZ+di+6CuCxLstetrYZzn55u4fMObaLJ/1JWcwxrd2Pq0DWqlA5hhLRhIkFxsA15SKo9XV90FRkE9pP7zeDHBPd/N9JJY2jfTzn24H+fz51TnmQssU4Wev6WKN5FhmrDLqsdGskH3qhjHd7oJCKr0EWPOoNrkbXPiRMYlFTG53XTomWTK+L7dwRcPyIspRQykeOdjaQcDetgiVQpPrxR2GQkI2LMwvhi8uIrWipv/PfXupK4/Aiic8eDMydauKEMZ/1LjPi7X4/3+dkLp0ijR1oG7dphc00BwZM+Qt27R2KjSBYkSFyD3WnPB4jj7CKO+obJYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by LV2PR12MB5751.namprd12.prod.outlook.com (2603:10b6:408:17d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.10; Wed, 15 Jul 2026 01:10:20 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0223.008; Wed, 15 Jul 2026 01:10:16 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Jul 2026 21:10:15 -0400 Message-Id: Subject: Re: [PATCH v3 2/2] mm/mm_slot.h: add comments for mm_slot_lookup/insert Cc: , , To: , , , , , , , , , , , , From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <202607140924549782dUh3YBPmy8g1NDMK2zIW@zte.com.cn> <20260714092815120Wv-CFDlLKtsTmda--97Qw@zte.com.cn> In-Reply-To: <20260714092815120Wv-CFDlLKtsTmda--97Qw@zte.com.cn> X-ClientProxiedBy: MN0P223CA0004.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:52b::14) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|LV2PR12MB5751:EE_ X-MS-Office365-Filtering-Correlation-Id: ac5baf75-4b13-4cca-5b50-08dee20dd46e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|7416014|18002099003|22082099003|56012099006|11063799006|6133799003|4143699003|921020; X-Microsoft-Antispam-Message-Info: /1VYjAwaD4hYOzyIXEm8CG0aOpEqdvyZy2wZ/lSbOLHw05DEyou4GfRz1lQbD8SBwKJ9yXyvmXVGzyM0DAmnQaTwu1WKyFmmbifX10F5OErgCxneEAACT+CELOIOA98DkORw9k/ElVTZ1OLJ3Zma+NR1aY9/yJFrL3CqHt7xNAetF4iWNZFvWYMg38TsuFFJeCA1y9qpH1VoVpGyexK1lG0nCI1NPm+DJd3dzS1kJb7HvTCO4cxZUb9LfbE6WlBUdJkJvSgxJncQSX2xGgR9fzJx73qEc1UbAQjpHF74alZD16XdHkks1jTba/LQ6rfoBILhJevoQwfIe3t6U+Xp1XJrpBc7uW0nSJCAvqZzxGPEQQL3dgj5lHFlN8f9Jxb3+2nzym9mnqku73I5BS4vSwJlrnqcyARTCxR2JrLO21nkdBw/7l0LF5QgQMD+F+Em+sT7zKYniC6bzx3O529dQ1NBCwlrUvmtuOW8dmn1K9LrdXlOk1GG58tMVXCi1wv/0lrGyIwvBpOl+Hz5OhKC+wchh5582NOHIY8H/Et/UUkUMfEoDjDJYE1pU+AWE6AIVKzFNb+AStfiYXkY3LVxz7WwkLjNZgx3m8P0Ob5T/fWuSFlDEXIROVv+NM5IjGR6ySLPVIDnmbm44DpPvM5OU+ZT0ERL2Gzu7XurlthAGKYVErJp+p9ByKBDDNsmxD61zmfBn6MMVxQ6KX00i9C/dw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006)(6133799003)(4143699003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHNXTVV6N09ZRnNvUjNLNjlVM2ZsYnhoRjJCOEJFVlU0V210Nk9CL3N1UGln?= =?utf-8?B?RDhTVXhia1V6b2lFMVB0bkozditnY1pPZXpsNWs0a2lLWHZTUmFXeDVab01u?= =?utf-8?B?SGNiams0Uy96SHlmTERHdm5iMG1ZWFZJSGxndkRINDIrVFlqcnhkYmRMd3kz?= =?utf-8?B?QmhVNGloNEprNENWenA3YVV0M1ZGdTNYNDJWTFVudm1nUDZvNnRQNXFjUmlh?= =?utf-8?B?VVpMalB5VGxGeHJCdDQxdktRR3g0L3J5aTVVR3NydHplQmxVZ2hYZ1NnWlg2?= =?utf-8?B?bmFkY095WEE2a0wvTHYwa2tWSjFaZGgwWnc0SWsyNHVsREJ3STRSVHlZRGtG?= =?utf-8?B?WU5EcDZUUW9YaVpjOHBpUzc3ZS9meW4rdjBhcXhvYmdtUzc2NTRmQjRPUUZy?= =?utf-8?B?Q0VvU0xqY3pIU3Y2ejdydEtCb3lQckdTY2lmZzhMeDU5YTd0WVlHMlN0Y0xY?= =?utf-8?B?SExrVEdUdmpWWmhOdWdOY3A3WmhWN3JGMVhsRUZKRVgyNHBXN01RKzZoWG1Z?= =?utf-8?B?RXlZZVhXNjJsNGpjQnBQMmN1UlZCcWY4YjdGbTRUWHozZ1BmcWUrbFdnUDBq?= =?utf-8?B?NSthWHE4T0RvSEMvOC9VSFZqRWZMaENPWlcxdkNuZFhrU1lDcEtpY0dmYTFt?= =?utf-8?B?QWEvWlFEQ2xZcDZDRllVb3J6aEZYcStUdjVTWnJrdTcrMUNpUEZFa0dQa2Zp?= =?utf-8?B?MVRnWk05emVWVFN3Y2d6MHUrRGZuZHRrT1diQldKcVR5aElCTEpTNVhoTnlU?= =?utf-8?B?c3lOb2tmdGt5SjJXdXFWVXZyN3hJTjBDaEdpTEwyZkpDUk5vL2Fac1huQ1ZB?= =?utf-8?B?bnFQMmdHUWxMWEZYZlU5S2lGVG53bXdLbUxOUSszWHFzcE10YzlQUUJtYUhL?= =?utf-8?B?MFRHY1dsbW5TQVI2NHFGNXJ6QjA2UU13ektZWVoxbWIrb2JseXcvZUdDdnNV?= =?utf-8?B?V2J3ZDhMZXF3SVFLUE51WEloeWlpM0RzLzJQaXJxQVdyMll2dSt2Mk12WWph?= =?utf-8?B?Z011ajcrUWNIMDFyWDJrUjBleHNxUUMybkVwU1pBbjVkL1B1eCtOaW1aa2Zr?= =?utf-8?B?ZmJLamh0Q1BBVmp0L3ZuQlJGeGtSMHFZYUlxYUtXMk55bEZMbWJMaHRNYSsz?= =?utf-8?B?bXVVV0xCR3ZyT2RTMC81Sm53T0ovVFpVQWtHemRFTlFiMzlJY2NNRkV4Nzht?= =?utf-8?B?ekZCY2UrVEF5bkJFTklhQ3U3VjRWV21hd0pVVXo1eTA5UDJYWHh2T09GcW9L?= =?utf-8?B?dDBSbHRRNnJjdmhhdjViZUxmamhvRkFURFNCTjVSd2VhQzgrRHBqYkNGTnJH?= =?utf-8?B?VHB0VTJhQmQwQjZxbUtrNGVBejBpSlRxUzRtUkxkRGhUSDh3M2NibzFWVGpr?= =?utf-8?B?R0FsZENVaFhhd3NlcFdiZ1dRQkx6NlAreHRSV09Uc0VXQVBaK2c2NFBMTWxk?= =?utf-8?B?VXpBejRXMjUrS0JuVnpLc2c3MzBUbVR3US9TQXdHZW5HekhHeVB1dzcvU1B0?= =?utf-8?B?cUszNGxFZkZ5MlFDWlVMWlpJT1BzOHhmaG5hbWZpdC9lYXpwdzdDMUZSVzIx?= =?utf-8?B?SUVSZjY0bDAwaVY0ZXFSRXJQaFZ2N2p4V2NNY3p4Z0hraHFiUG1YZVVOS0Qy?= =?utf-8?B?dE03cndUcXhpSkYrVUR6L3JMUGEyQ2VpMmMwNnE3QXRCL3hjeHRCTStldkxr?= =?utf-8?B?WG5qbmtVS1VxY3ZkY3A3bW0vU0N0R1lsUDAvMnBUYmIwQ1VXb0xLUUNTVURh?= =?utf-8?B?K1Jud1VDVHZqRlh5T0pvdEFsKzliQ1c2eHlKSEM0ckw5Q2t1NVkzeVRnbHhy?= =?utf-8?B?ZGM3WHdVY3BZSHVUY0FJbUU5NXMrY0I2TjhYTGdndTBhSE5HY1M1c2lPTmZm?= =?utf-8?B?TnlpbVRwWGp4VWdXTW9GcEVlVnpSN0dSQU9qQVRoMTJTZHJYY2VlalNVbUE4?= =?utf-8?B?K2IvdjBmM3RZcEVhcE1YOUtWcU54enhYSGhrTVpNREZuRkMwWFlyU0dwOXEw?= =?utf-8?B?MkVwa3lzdzNMemlUUjJubkJNemFDQmNOSHNsRHcrSmpkblNBQ3RGQ213VW1R?= =?utf-8?B?NDlFNjlPWlNhSHp2aGZwN1lqWDF0YmtBL1hIczhpYUE2R050aXl2MXFiQS9R?= =?utf-8?B?STlrRENITHpYa2NDNlFKdUFsR3A5QlVlajQwU0FFRnVnalU2eERoL3B4RW0v?= =?utf-8?B?VUVZV1hGSmlvNnlrSXpFWFlLUGVRQXJPRkFNdHFnQTFVeTVoVitYNTVPdzF1?= =?utf-8?B?MG9kOGsvNTRZeUlnQjVTNmRQOVZTOE5IRnVCemJNVmpKRHV3WjNxaHFFZGtX?= =?utf-8?Q?m/7LxF18QEhe59QmHv?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac5baf75-4b13-4cca-5b50-08dee20dd46e X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 01:10:16.0648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZZZ8GFV1Y9KSZPYGcUkbtQGTjml64D6KEzgU1lJ4yQe0j4FV+44gGmy7U6D/wVAa X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5751 On Mon Jul 13, 2026 at 9:28 PM EDT, wrote: > From: xu xin > > mm_slot_lookup() and mm_slot_insert() are the only helpers in > this header that are implemented as macros rather than static inline > functions. This may look inconsistent without explanation. > > Explain they must be macros because hash_for_each_possible() > needs the table as an array (for sizeof), not a pointer. > > Signed-off-by: xu xin > --- > mm/mm_slot.h | 6 ++++++ > 1 file changed, 6 insertions(+) > LGTM. Thanks. Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi