From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BAA82F7AD2 for ; Fri, 17 Jul 2026 05:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264935; cv=none; b=POpCeyxHsieHnjmknSXCsHkgCPpwAEHcaNII//sdoOPhLR2nEzex6s8BazxYOjDXaK/wPz0OBjEjuEx0kas1wbQcyEsZJ56LEjRFCEGET2ULna9UbZM9CBJhXLyWEBkAkTHzhSuDBDd6gaVQu8sjf0t0kpc2+4ZpIN5C9hjAQdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784264935; c=relaxed/simple; bh=y8ra6iNrqOySRVd8TSKzMCECDm6NutDHBWQ2nV8+r/A=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=UUNm5nrbFo3aMmdjL4euqTkq5rd3s/30tqmXrkgfwS3lTAwjNQS+rbO2I/eeLQGXB3BCc984++KLcd6EQQS0djYWCBuUWULDVrWHMMZc6reRiGg8NyxkR0govItkeun5B/MIGEu3weEAX14eBnwKgvoykLirFzyaf87x6wSBLZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=h2/JWY6w; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="h2/JWY6w" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-848595b338cso8591430b3a.0 for ; Thu, 16 Jul 2026 22:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1784264931; x=1784869731; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3Kk0LSnTy6u9JE2Hs6bboN5a228uN9ZkdsFyoBfZC18=; b=h2/JWY6wyhsu0t1/kEfIGs3hanmDpW9uxt+roIer0HQTD4/nWDRWrEBL06STnPqjuL lIntOnvO3RmVYG/UKWYvxhzSd7KwaZYST6oz34n/2E/HX/e63KV3nU/1o31XloxuH1hR HtMOf4PDWglmXR5ZwrzEOGcRisKFO71YtBI9/CKR8b9d1GTjTf1oZARCYMdPaC+t64DF fgiWIEaWX3ht9s5vO3t8DmpKfwsetkFluEoZEI8SkvCh7hZt5TcuE5DWXM+oeePuFSGV nD6Yp5mnfvkYcq+1S9t2zuMcIkmumuP0ZMURe+XDgm5iQC6QxuFpZrn6mnydEDQqtuqI GOSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784264931; x=1784869731; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3Kk0LSnTy6u9JE2Hs6bboN5a228uN9ZkdsFyoBfZC18=; b=XtnLhOaEkphvQm/HDAR10Hh4nB1HwEw34HvcNmWjrmBjliZUre5a14egOYGsHKEA4A 3NxLv3satGNcUnGd8pMUtmsB7mljjd7YHGRpr927gG44GJraFIkh5zXC1z2goDz+rTg1 00UUqzapxRm2eVAYeXuID6eDBtazdprPGr7OALPkTmeve9ICGe98deoDgXrgp4vZiwu4 uS0f+L22xzqDptRqR5iRNkyBIvxzjhNu9tzV1PlfVml8kpSi6e+66hovop2RVNG5+P69 17uJmceC36zQbn5nQ04Pd7rgkuEJ6fSCve6xkTE6eTj+HjscJ/xCxFu5t48rjDJ6zxZg MTpA== X-Forwarded-Encrypted: i=1; AHgh+RpiebQ1is+CBvV5UyBGuYrpG4E2f5mJim8lShtyEra1ZM/1Hj/kxoDdccXKPkK1xOrHbcaZaCApvva3bCc=@vger.kernel.org X-Gm-Message-State: AOJu0YymkSLG2O7TYTqQxbnGHJHneqjIT+zdiALChjQ8CRMPD1Gnjy4i FYroiB645oOYj7e/G9NuJ/nDEmPjK33TyPNSqzB20ryxZSasrOt8TVm4qf9JNYpUpyw= X-Gm-Gg: AfdE7cmK6XWoHcaYg3mPV1y8GsJjxEMNfPfDiFRRPzGQGN0kaT71nnLonstoPPp/mRF TMmR3pnxp+exSXovYbhSS30B4Y50jx7aIvEn0V+wb3R7U5OAcQVorW6hFF+Ssg69hvT1CshQqiG mEWvpk1GSq/gHrCtoN/DnEmtzua36XTJLxHQf1aRLBnYq23Iu+CJiDztZ9DZx2Ds/f3ZkfbX3Jk L1IZK3z83D+7vb6gKxJ2iwmvPwZHO6oYvDzX2ePZKPA3h71w0CghXb2YsamWq9AcUISZmcZt/Ta 2x/yu7+W06viW6YgFR7Iq65IvHusjCJQA7M1D/IZnSJHNPmODsRlbgfNnIf/n47sL7M2ir/YhmH Jcsk4LFCqy24W4wvfK6B1GnW8ehFBI0iUBfC+7kIr/oH01Exub9jaARCvDnkfe9Rp1kL0J/GU2u 7NPvce0B0fy2SGRqS6sIEbRODL2tyTxr8HYpvlvS35wA== X-Received: by 2002:a05:6a00:400b:b0:845:bda6:574b with SMTP id d2e1a72fcca58-84c292a0f41mr1060179b3a.5.1784264931283; Thu, 16 Jul 2026 22:08:51 -0700 (PDT) Received: from localhost (107-190-31-17.cpe.teksavvy.com. [107.190.31.17]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af6e48csm248690b3a.45.2026.07.16.22.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 22:08:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jul 2026 01:08:49 -0400 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "John Fastabend" , "Quentin Monnet" , "Shuah Khan" , , , Subject: Re: [PATCH bpf-next v10 1/9] bpf: Drop duplicate blank lines in verifier From: "Emil Tsalapatis" To: "Leon Hwang" , X-Mailer: aerc 0.20.1 References: <20260715153254.92010-1-leon.hwang@linux.dev> <20260715153254.92010-2-leon.hwang@linux.dev> In-Reply-To: <20260715153254.92010-2-leon.hwang@linux.dev> On Wed Jul 15, 2026 at 11:32 AM EDT, Leon Hwang wrote: > There are many adjacent blank lines in the verifier that have accumulated > over time. > > Drop them for cleanup. > > No functional changes intended. Reviewed-by: Emil Tsalapatis What about the files we factored out of the verifier? E.g., backtrack.c also has the same issue. > > Signed-off-by: Leon Hwang > --- > kernel/bpf/verifier.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index de816063ae63..e1244a721194 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -634,7 +634,6 @@ static void __mark_dynptr_reg(struct bpf_reg_state *r= eg, > enum bpf_dynptr_type type, > bool first_slot, int id, int parent_id); > =20 > - > static void mark_dynptr_stack_regs(struct bpf_verifier_env *env, > struct bpf_reg_state *sreg1, > struct bpf_reg_state *sreg2, > @@ -1671,7 +1670,6 @@ static bool same_callsites(struct bpf_verifier_stat= e *a, struct bpf_verifier_sta > return true; > } > =20 > - > void bpf_free_backedges(struct bpf_scc_visit *visit) > { > struct bpf_scc_backedge *backedge, *next; > @@ -2291,7 +2289,6 @@ static struct bpf_verifier_state *push_async_cb(str= uct bpf_verifier_env *env, > return &elem->st; > } > =20 > - > static int cmp_subprogs(const void *a, const void *b) > { > return ((struct bpf_subprog_info *)a)->start - > @@ -4044,7 +4041,6 @@ static int check_stack_read(struct bpf_verifier_env= *env, > return err; > } > =20 > - > /* check_stack_write dispatches to check_stack_write_fixed_off or > * check_stack_write_var_off. > * > @@ -4840,7 +4836,6 @@ static int check_sock_access(struct bpf_verifier_en= v *env, int insn_idx, > valid =3D false; > } > =20 > - > if (valid) { > env->insn_aux_data[insn_idx].ctx_field_size =3D > info.ctx_field_size; > @@ -6683,7 +6678,6 @@ static int check_stack_range_initialized( > if (err) > return err; > =20 > - > if (tnum_is_const(reg->var_off)) { > min_off =3D max_off =3D reg->var_off.value + off; > } else { > @@ -7404,7 +7398,6 @@ static bool is_iter_new_kfunc(struct bpf_call_arg_m= eta *meta) > return meta->kfunc_flags & KF_ITER_NEW; > } > =20 > - > static bool is_iter_destroy_kfunc(struct bpf_call_arg_meta *meta) > { > return meta->kfunc_flags & KF_ITER_DESTROY; > @@ -11539,7 +11532,6 @@ static int process_irq_flag(struct bpf_verifier_e= nv *env, struct bpf_reg_state * > return 0; > } > =20 > - > static int ref_set_non_owning(struct bpf_verifier_env *env, struct bpf_r= eg_state *reg) > { > struct btf_record *rec =3D reg_btf_record(reg); > @@ -16421,7 +16413,6 @@ static int check_ld_abs(struct bpf_verifier_env *= env, struct bpf_insn *insn) > return 0; > } > =20 > - > static bool return_retval_range(struct bpf_verifier_env *env, struct bpf= _retval_range *range) > { > enum bpf_prog_type prog_type =3D resolve_prog_type(env->prog); > @@ -18363,8 +18354,6 @@ static void release_insn_arrays(struct bpf_verifi= er_env *env) > bpf_insn_array_release(env->insn_array_maps[i]); > } > =20 > - > - > /* The verifier does more data flow analysis than llvm and will not > * explore branches that are dead at run time. Malicious programs can > * have dead code too. Therefore replace all dead at-run-time code > @@ -18392,8 +18381,6 @@ static void sanitize_dead_code(struct bpf_verifie= r_env *env) > } > } > =20 > - > - > static void free_states(struct bpf_verifier_env *env) > { > struct bpf_verifier_state_list *sl; > @@ -18675,7 +18662,6 @@ static int do_check_main(struct bpf_verifier_env = *env) > return ret; > } > =20 > - > static void print_verification_stats(struct bpf_verifier_env *env) > { > /* Skip over hidden subprogs which are not verified. */