From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE763009E2 for ; Fri, 17 Jul 2026 17:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784307780; cv=none; b=i/DejqIXcpGzc79950tbVMuMvUzLrjpyyv7K0bkgtPDO95+Zc/dQII0uXeAVonPsziuBaiN2t13ec7EBCwd4d6V5g90THrjX8J7hBlSczemDvC7vFDBDr1RCxNoX1ES/s7Jl+gcIVLEsSN0KfBPWuIIOMqPJ+QF1wlc1Nynp4qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784307780; c=relaxed/simple; bh=4BZzTWmadIpPgdQresUeVaUcp5DGpz5V6zno6Q4Z1O8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=hPNsgS779jES0wA7SE4AZ+/vyzLEiV0UM0E/iQOtNWdLyl6tyobwb+68JS2kANpRuj7klKNlPqT4DUe3JPzOF32SAMc8FaNlo7n+3AS99lxRYtdkX6XTgl824dB2dmqI+ZVmVw7NaVtHdupdLsMraoCBRLTn9IhCpKCfqPBVpIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=X3hsFQIu; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="X3hsFQIu" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-495437bb891so12635815e9.1 for ; Fri, 17 Jul 2026 10:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784307775; x=1784912575; darn=vger.kernel.org; h=in-reply-to:references:subject:from:to:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Lkj6Un2bLVNZ+vPuAfaPexv3e+Wv8C5O29PKU28JKqQ=; b=X3hsFQIuDdkqW3Oi3cPT+CoYCPPqroxq3JQpI6WjBnzK1pj7GskJtl1Q1RELU73XMT /3Qq04+DPhk5wZa6id5MZE3/7Qs89VYHZ7dEsPr/PvCJ6jBsYRC9FgvIeSbscgfZfflK 6v+r3W0KSwQrxZRDtbZVoMpP2PgyF52/lMHp9Ug7rQT7Igw8hgH3xBfXReb2/Q5AF0oz 95I5hWzN1CRBw02jKCw9W2Pn0lj6ZiL8JC+AnZ/UnfYJ5/67I2AJ7F8A+R/k6EhH8Ep6 cYDGJVmwj5KgFvKGInqBU9tl+ub5UGEn9cdHtDBskzF/cBKODUDGHETK2ezayxIGG0mG 8hqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784307775; x=1784912575; h=in-reply-to:references:subject:from:to:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Lkj6Un2bLVNZ+vPuAfaPexv3e+Wv8C5O29PKU28JKqQ=; b=VVe3Ts/enf9j39FWngVNj9extinaREP1tPE+gyX1R4aKZpG7sPi+VGGT0KWAh3Wv82 9MTZO44quWO/PvzFpN4XpDD4N3eDl2P4ARudDCOKVJc9dghIhkCok3HT85Q0Jt8fV7s2 dmg3i6yJVEPgbWsG7zxbn8kdWVLwJsfp2Yn8Tl43/Y+6MNkthwXFfKuB+AB/kX3wqagA AEVWYj1GgH2EENTrGi8LHaYEsOsCy5Tjczi/VPATdZM7OkFZtnKdnHeN93MaFiTjGt3T 2kV/KB80JYTzSjZ7igSis3stJBuAEu9A7rCqKihfNowor190eXnm2nFs6s7RAotRzoFy kEsA== X-Forwarded-Encrypted: i=1; AHgh+Rqjt/ugxdMldKA0USO8PFBuZEO1n++6sUX2MTQ6LHVQdMeY+OrU5fg2gORgf0lwKdY8N6m2MTUGkHleRdw=@vger.kernel.org X-Gm-Message-State: AOJu0YzH9GMxgdup8fbA2/YP7I8eS3L3p+QNF/78TX04HyefjKfVqAuh TcdPiwGbvb4vFQk27oG7zJO+FIbjPt1H/Pd26UhK7HVZk1M8MbLn0SLyV4UWEn3d7v4= X-Gm-Gg: AfdE7cmeRNSqSk3aloM71bxFZ+04/baTbqi2C/tum+lEizEiadvqbsDmjMQSk8YqM3t gkdHvjxYT4C4K4Xmj7uWtjM2G4kfQhw+bJtnmV/naz4Y7+jXVl4NARsh+A/pMP4BLxRbn+fyQYd 9U4Zr7IbUO8aIAAAbaEGiWy+oC1JvfwQPKurY6jhlv7uD/3u2m1/DvJ4lGJv8A3QY2jfsZ04JBz K0/kPPSvI/3Fs3KIT0x/0Af2JTpE34mTw2bGfJ2u81XrmnATVyJQDOFI3gX0oO6M5Z3gfy08Au6 mW5p4th7w03Yq8UShtNvLOVsCJxaXh1CDk0wRy8PD5FgN3v+0zbzfkX9Gx3yENM1QTNjX8lTBiF CDvWRwAZczO0XLrnhkDFdLpYCe4zpSPfSebUJt4I/1Mb6j3+5BITLDe0VFGveoFTx X-Received: by 2002:a05:600c:c050:b0:495:499e:ec37 with SMTP id 5b1f17b1804b1-495499eed36mr34495265e9.18.1784307775060; Fri, 17 Jul 2026 10:02:55 -0700 (PDT) Received: from localhost ([2804:7f0:b765:c3e:eeab:5970:313d:2132]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81ef4275060sm14733597b3.23.2026.07.17.10.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 10:02:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jul 2026 14:02:52 -0300 Message-Id: Cc: , , To: "Ihor Solodrai" , =?utf-8?b?UmljYXJkbyBCLiBNYXJsacOocmU=?= , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "Emil Tsalapatis" , "Shuah Khan" , =?utf-8?b?QWxleGlzIExvdGhvcsOpIChlQlBGIEZvdW5kYXRpb24p?= , "Christian Brauner" From: =?utf-8?b?UmljYXJkbyBCLiBNYXJsacOocmU=?= Subject: Re: [PATCH 2/4] selftests/bpf: Install resolve_btfids.test.o.BTF where the test expects it X-Mailer: aerc 0.21.0-146-g87073a0460e3-dirty References: <20260710-selftests-bpf_fixes-v1-0-aa24dfd6f4f9@suse.com> <20260710-selftests-bpf_fixes-v1-2-aa24dfd6f4f9@suse.com> In-Reply-To: On Thu Jul 16, 2026 at 6:10 PM -03, Ihor Solodrai wrote: > On 7/10/26 3:09 PM, Ricardo B. Marli=C3=A8re wrote: >> prog_tests/resolve_btfids.c looks for "resolve_btfids.test.o.BTF" relati= ve >> to the running test_progs binary. resolve_btfids always writes >> .BTF next to the object it processes, so building >> resolve_btfids.test.o also produces resolve_btfids.test.o.BTF in the bui= ld >> output directory as a side effect. >>=20 >> INSTALL_RULE never carries it over: it is not part of TEST_FILES, >> TEST_GEN_FILES or TRUNNER_EXTRA_FILES, and it is not copied by the *.bpf= .o >> rsync used for TEST_INST_SUBDIRS. After "make install", every flavor of >> test_progs, including the default one, fails with "Failed to load BTF fr= om >> resolve_btfids.test.o.BTF", even though the file built fine and BTF ID >> resolution itself works correctly. >>=20 >> Install it next to the rest of the per-flavor build output, using an >> explicit rsync in INSTALL_RULE like the one already used for bpftool. >>=20 >> Fixes: 522397d05e7d ("resolve_btfids: Change in-place update with raw bi= nary output") >> Signed-off-by: Ricardo B. Marli=C3=A8re >> --- >> tools/testing/selftests/bpf/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>=20 >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selfte= sts/bpf/Makefile >> index 47911c9b4977..7260d672acf7 100644 >> --- a/tools/testing/selftests/bpf/Makefile >> +++ b/tools/testing/selftests/bpf/Makefile >> @@ -1057,10 +1057,11 @@ override define INSTALL_RULE >> $(DEFAULT_INSTALL_RULE) >> @mkdir -p $(INSTALL_PATH)/tools/sbin >> @rsync -a $(if $(PERMISSIVE),--ignore-missing-args) $(TRUNNER_BPFTOOL)= $(INSTALL_PATH)/tools/sbin/ >> + @rsync -a $(if $(PERMISSIVE),--ignore-missing-args) $(OUTPUT)/resolve_= btfids.test.o.BTF $(INSTALL_PATH)/ > > I think you can squash patches #1 and #2 into a single "Fix make > install target" patch. > > pw-bot: cr > > nit: This hardcodes the filename, and even though we only have one > test that needs .BTF currently, you could add *.BTF to the loop: > > $(OUTPUT)/$$DIR/*.bpf.o $(OUTPUT)/$$DIR/*.BTF > > Then any future test that consumes a raw .BTF gets installed for free. Good call! I'll prepare v2. Thanks for the review :) > >> @for DIR in $(TEST_INST_SUBDIRS); do \ >> mkdir -p $(INSTALL_PATH)/$$DIR; \ >> rsync -a $(if $(PERMISSIVE),--ignore-missing-args) \ >> - $(OUTPUT)/$$DIR/*.bpf.o \ >> + $(OUTPUT)/$$DIR/*.bpf.o $(OUTPUT)/$$DIR/resolve_btfids.test.o.BTF \ >> $(INSTALL_PATH)/$$DIR; \ >> done >> endef >>=20