From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C931A3B2FC0 for ; Fri, 17 Jul 2026 23:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784329896; cv=none; b=mxcPHoTPZNJSCJUALJly+wTossFXsCM/QsCLnV5gePxakxYRR2iSvAJaA08WZx7pZlgJp8/rKituvRsx7r9+oixe9TdkzCB2kSF0ZHtzHx3idF+HVhuuMX1PWhg9ZK1AhVnp9XU+/wH6B5jDLLepkEoiXTWY/TIswlurUW946eE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784329896; c=relaxed/simple; bh=H9UBDqh2kye2P4CnU7T5hCf2ZYmDRXhCPHDbQmPuU8E=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=q3JlSi0GGMiuWKrM6/an906/6wQyRmeIODACGTi2VsuebzUumNID37q1SAQqyK8MiUiYJsPqP8Zjq2DpPWOtpkpljAQn9R59F0rvKClcodyE4tc/2c+5RminKYhnQOr1/a4v/HWbEAGYqqCST29pvLwt18eTTSz8pPr8En2/4tQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=rabvkiyb; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="rabvkiyb" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ce7d2adef4so72089655ad.3 for ; Fri, 17 Jul 2026 16:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1784329894; x=1784934694; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WBevWLdm6MxRo3Qt2s9YR+iZOicNvJuxTFHEz0+pwEw=; b=rabvkiyb/qrWXb9pg2utm8nZR8lZ2Bw5oy1pDwBbtde7RiyxyHXwZRgk2gZnl6IQhg PnY+Cu0fx3HGk+SRulA2qS1K1hUpNeVjU4FzpRDBQzaZjgPb5j7Ahr7IkQ59jMOLM4Ef xZg4JkPSoqVriwArVfu3W/AvZLj7WXCb0YPVasM7neTkdM0pdFBp6C0TiD/8WpG40qCG j3RH0Irlw/xIl1j1d1TICdPRY9wn9eFFIyVkIMqeTkPvuBRu6JBmFe+SHWL1GUKIoD+2 qYF7TzknM9Tsto9GC5FAulZ7J2NJg3dwT4c8ZD5T6zaUdPgzAxB+/auVYst90beAwQCG TFKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784329894; x=1784934694; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WBevWLdm6MxRo3Qt2s9YR+iZOicNvJuxTFHEz0+pwEw=; b=oNMkVH4bD+mlOI/KuK+NA2dAwZiX7zRtMiHNDzyqRRaD54q+u+j1ghw+1iFa1jMfJI p3Swp+E5iablZuaeu8pstMbdy6C1pQLyAG9Kb3Gp8SUr3PcoQhQnG5e7H2CFx9yTA0xh fk92DTe03G04zVHtaC8+1DIRuFMkuTvRho0V2N8KJMUVXdyCSIiBz90xwraFtR0aX6dd YrTBreA+4QwlV235EQHzQGiema7SY8Cc4HauWBPEBL4qnN2KgVLsj9zlKA4uvOo31Y5B AH+b+b2ZNXE/NmLoV8p0/qtv0s7WzHHJwCH5J9WlYuaH6Y2I3eOCcbCc2peSyaBwcczM zL1w== X-Forwarded-Encrypted: i=1; AHgh+RqZUgUbm+x/K12WZesSaaMt0+LTaYASSJ5Bm7zNiCaml/SswYOJPKMbxUYexuhbVYkAFve86WObDKx0sf8=@vger.kernel.org X-Gm-Message-State: AOJu0YyhwlD1BbF83+Y3OO0VMobaCGA3/ZySIdfxjlipzAEN4V0HuCfU IZQg2nARTGtDPk6iMHz4Idnn0qNwY5f0I6ANf7L82eg/Xz2O9Fl5OUPIsTgYAt27zCQ= X-Gm-Gg: AfdE7cl5Lq1xhJNq8d7MzVqhcOy7CEW3MTllwzcP6tO/l9Gk0h+NCHLBuvaoXhZ1XtU +6kp+qj61xbkYRXkcyMp2Ug3BvzTEcyjkFTHhoPMNWY+uLN3mTNZ7J47hKoQWga/1zqbuj1BRaL 8QXUC06Eruv/T6xsqmc7/zkNmjRMiBWaG4awwNVV77ZGdgg0fCWO01HMB6AkXP+AMpU1iLc1G5Q cD1uFNvTUujOpLCtNBo/sDBYjAAZoMGvu9WjBUoaGG/LbDpfznHFa0v+lALviq8238Ykds87lWC zt/+t0pj+yaLaa+C5OrtybMKaBUG3l36D1jRi+g9SQBq8rIGKCgbJMauvNfMDFh6SUSeLTSuRW4 neiGORpZGeBAdRfBuR8w1GR5uF+CNspwSYawGYEID4QJLnXoh0Ot8w7Spv5c= X-Received: by 2002:a17:902:ec8e:b0:2c9:e961:d256 with SMTP id d9443c01a7336-2cf3494afcemr48411825ad.27.1784329894026; Fri, 17 Jul 2026 16:11:34 -0700 (PDT) Received: from localhost ([2620:10d:c090:600::f5f9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf34783112sm18615035ad.79.2026.07.17.16.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 16:11:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jul 2026 19:11:29 -0400 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "John Fastabend" , "Quentin Monnet" , "Shuah Khan" , , , Subject: Re: [PATCH bpf-next v10 9/9] selftests/bpf: Verify bpf_iter for global percpu data From: "Emil Tsalapatis" To: "Leon Hwang" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260715153254.92010-1-leon.hwang@linux.dev> <20260715153254.92010-10-leon.hwang@linux.dev> In-Reply-To: <20260715153254.92010-10-leon.hwang@linux.dev> On Wed Jul 15, 2026 at 11:32 AM EDT, Leon Hwang wrote: > Add a test to verify that it is OK to iter the percpu_array map used for > global percpu data. > > Signed-off-by: Leon Hwang Reviewed-by: Emil Tsalapatis > --- > .../bpf/prog_tests/global_data_init.c | 52 +++++++++++++++++++ > .../bpf/progs/test_global_percpu_data.c | 25 +++++++++ > 2 files changed, 77 insertions(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/global_data_init.c b/= tools/testing/selftests/bpf/prog_tests/global_data_init.c > index 598b7dde6581..e5a40ea36ee7 100644 > --- a/tools/testing/selftests/bpf/prog_tests/global_data_init.c > +++ b/tools/testing/selftests/bpf/prog_tests/global_data_init.c > @@ -283,6 +283,56 @@ static void test_global_percpu_data_verifier_log(voi= d) > RUN_TESTS(test_global_percpu_data); > } > =20 > +static void test_global_percpu_data_iter(void) > +{ > + DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); > + struct test_global_percpu_data *skel; > + union bpf_iter_link_info linfo =3D {}; > + struct bpf_link *link =3D NULL; > + int fd, num_cpus, len, err; > + char buf[16]; > + > + num_cpus =3D libbpf_num_possible_cpus(); > + if (!ASSERT_GT(num_cpus, 0, "libbpf_num_possible_cpus")) > + return; > + > + skel =3D test_global_percpu_data__open(); > + if (!ASSERT_OK_PTR(skel, "test_global_percpu_data__open")) > + return; > + > + skel->rodata->num_cpus =3D num_cpus; > + skel->rodata->offsetof_num =3D offsetof(struct test_global_percpu_data_= _percpu, struct_data); > + skel->rodata->offsetof_num +=3D sizeof(skel->percpu->struct_data) - siz= eof(int); > + skel->rodata->elem_sz =3D roundup(sizeof(struct test_global_percpu_data= __percpu), 8); > + skel->percpu->struct_data.nums[6] =3D 0xc0de; > + > + err =3D test_global_percpu_data__load(skel); > + if (!ASSERT_OK(err, "test_global_percpu_data__load")) > + goto out; > + > + linfo.map.map_fd =3D bpf_map__fd(skel->maps.percpu); > + opts.link_info =3D &linfo; > + opts.link_info_len =3D sizeof(linfo); > + link =3D bpf_program__attach_iter(skel->progs.dump_percpu_data, &opts); > + if (!ASSERT_OK_PTR(link, "bpf_program__attach_iter")) > + goto out; > + > + fd =3D bpf_iter_create(bpf_link__fd(link)); > + if (!ASSERT_GE(fd, 0, "bpf_iter_create")) > + goto out; > + > + while ((len =3D read(fd, buf, sizeof(buf))) > 0) > + do { } while (0); > + ASSERT_EQ(len, 0, "read iter"); > + ASSERT_TRUE(skel->bss->run_iter, "run_iter"); > + ASSERT_EQ(skel->bss->percpu_data_sum, 0xc0de * num_cpus, "percpu_data_s= um"); > + > + close(fd); > +out: > + bpf_link__destroy(link); > + test_global_percpu_data__destroy(skel); > +} > + > void test_global_percpu_data(void) > { > if (!feat_supported(NULL, FEAT_PERCPU_DATA)) { > @@ -299,4 +349,6 @@ void test_global_percpu_data(void) > if (test__start_subtest("rdonly_direct_write")) > test_global_percpu_data_rdonly_direct_write(); > test_global_percpu_data_verifier_log(); > + if (test__start_subtest("iter")) > + test_global_percpu_data_iter(); > } > diff --git a/tools/testing/selftests/bpf/progs/test_global_percpu_data.c = b/tools/testing/selftests/bpf/progs/test_global_percpu_data.c > index b852a0b07508..8b1f625017d1 100644 > --- a/tools/testing/selftests/bpf/progs/test_global_percpu_data.c > +++ b/tools/testing/selftests/bpf/progs/test_global_percpu_data.c > @@ -53,4 +53,29 @@ int verifier_snprintf(void *ctx) > return 0; > } > =20 > +volatile const __u32 num_cpus =3D 0; > +volatile const int offsetof_num; > +volatile const int elem_sz; > +__u32 percpu_data_sum =3D 0; > +bool run_iter =3D false; > + > +SEC("iter/bpf_map_elem") > +__auxiliary > +int dump_percpu_data(struct bpf_iter__bpf_map_elem *ctx) > +{ > + void *pptr =3D ctx->value; > + int i; > + > + if (!pptr) > + return 0; > + > + run_iter =3D true; > + > + for (i =3D 0; i < num_cpus; i++) { > + percpu_data_sum +=3D *(int *) (pptr + offsetof_num); > + pptr +=3D elem_sz; > + } > + return 0; > +} > + > char _license[] SEC("license") =3D "GPL";