From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B40104734F9 for ; Thu, 23 Jul 2026 17:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826438; cv=none; b=t3SLJmFipJ3Zb29V25gFEW+YAhcftaFBC6xZ+8XYrB8J9fQyyCNeIWe23xZGVstx+zD6IqUm15UGgiIibBFDmz3i9A0M2Petve44JxG7SSPPJclzD1wFE4wZvRdimXKcndbQSw7nxeHst3dSx6C9l1zerHdltai1PYXRsj9kAow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826438; c=relaxed/simple; bh=9BGi4xPmEW1kSjxVW00UAzBCZsYKa/tallJYYlIDz/E=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:In-Reply-To: References:MIME-Version; b=uaLPEQMKc7ehf5FUIs7bHn7KF6x5Gg6gaQhwEnAiDByPPfej2vWHh2TL0q9Z4+U1+IcmW29Jl3/DaveaD/Xi3ctaABzKKUqOyKEnyFh1+PPKHRmNORAIPvvxWfh60nvB0OAzqtvRCrhKluswhuragmm7/LL201KK2BNlb35qxas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=Ho2rBFns; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="Ho2rBFns" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso803607a91.1 for ; Thu, 23 Jul 2026 10:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1784826425; x=1785431225; darn=vger.kernel.org; h=mime-version:references:in-reply-to:content-transfer-encoding:to :from:subject:cc:message-id:date:content-type:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9+ctXvaIYkWeE2h8F1u4b7HT7VEBp0edXmBTu/xkC8k=; b=Ho2rBFns1MMmYUU2zyO90raF6M+vw8GEZ7vteWyvKpr8ucJUlKOJ2/+ScyQt1ayHRB 0zasGDVEzoYAfCBri27RQ+kFOmxnEYMLUpFrsFWYayzx5RM/CFtBprTeT/7teDsHwlhR o9ndSI1f5cRSQpy52wOYDD6gSRSFn0eoETqVc/1jYxyPvvY4SciIL/bzsmNa/osMbuhq txETkEI/3WSlxsXQukchf9uvprqDjiztRTXWDZWiD/AcVeR9pXFbNJjP2a8veFBQGLgL h73LSn1hFmeydxEMAUWnmNbWqYvrEEYYXmzYPLYZ3YqDmBvKnbEgoRma0geFahPdCSkx BPWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784826426; x=1785431226; h=mime-version:references:in-reply-to:content-transfer-encoding:to :from:subject:cc:message-id:date:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9+ctXvaIYkWeE2h8F1u4b7HT7VEBp0edXmBTu/xkC8k=; b=IeLtYaYW6pcgrYp3JZCdCgen/UFwLqIv15sJWgbny8WhnhkP7GHy7YTcPwbc0e2sIi LqBAjZZ91HAsr7ZwmyIDfFSL+3ZFCIXYs8oo8CPCz8VOtqA0ZHNBrM2FFis212TXGJAY Nw123lmyYtJEKjXUURVMtWRXuobE+kvE8y1Rb0bxAGQ1PV23GWu3nAF7tlDuWBo+vxhm wrxeGW7BNWufxqkXAAWIVWbq4rbZK0QID1z3mXhOpAtWEZ3sDM4W172pdyQnO9Af2MPd opFyEm9hkaRXAZQDZHFfG0d8meIvLO2L07guhGCqONYODZqKQo4pVN8afSu1UVJiVyqz nfJw== X-Forwarded-Encrypted: i=1; AHgh+RrrUUY5Xn55Fg4XRogLG2ZCWxALY6sI+FQf9bgXCpHgYNdZEEi3gmCPofFBv3PuTn4uQbeLSckXtTaXA2s=@vger.kernel.org X-Gm-Message-State: AOJu0YzprHMUyRqtPE89au95dXPh+kOB/vjrI0BfU00xJjgVVaHOIOba PiQWldBS9M5mXwlxzG+HeMMTovm7+CKMzdFyGzodoIt8obWX4LXYWrAzRsDhKTp1bAE= X-Gm-Gg: AR+sD10tUWG/3hglWCJc65qt+YXyCCMRDHNFoBQs0doaVitrweKAzcyQotdaHVhs5B/ yXa+8bYJsgZB8Iibx2I4RLesPlCrRkMqPD59Yzz5QjM0egE3APmEGmM67uf9HL1X5ooQUEgupWM yB92EObGhB0niON0pCbxJGgR9WZeIL8uL5OjIsZ1n2uzNlMWUEk2MLaf8wCdiNqmLeTud3KcA/X EGxkX4be90CehMHJnE6lxal7Qo+0g1SV0/RKb7GDMu/AEkzFl+GeBQV1rSne3KgAU5Kwyn2vsrw uhrWX9zAmjXhjuxxYPJ7A5ItMPEqm5d8kvOdUH+z2n+Ty4yAx9jX3MKAYZbbOOUcg2B0rMVouZ2 Bk90ihbND5UGANDIz24tC27by2JSk1PJhUw+W/eMT5RqWLBo+n5RwcJ3sH4q4BIPF4rpgHrUHpD ERpA== X-Received: by 2002:a17:90b:568b:b0:38e:7d77:2fbb with SMTP id 98e67ed59e1d1-38ec6631f60mr4017014a91.32.1784826425522; Thu, 23 Jul 2026 10:07:05 -0700 (PDT) Received: from localhost ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f041b8be9sm170294a91.14.2026.07.23.10.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 10:07:04 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Jul 2026 10:07:04 -0700 Message-Id: Cc: , , , , Subject: Re: [PATCH v5 6/9] of/overlay: don't create "//" paths for fragments targeting the root From: "Abdurrahman Hussain" To: Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260723033553.1261D1F000E9@smtp.kernel.org> References: <20260722-nh-of-alias-overlay-v5-0-2abe2bb9cdbc@nexthop.ai> <20260722-nh-of-alias-overlay-v5-6-2abe2bb9cdbc@nexthop.ai> <20260723033553.1261D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue Jul 22, 2026 at 8:35 PM PDT, sashiko-bot wrote: > [Severity: Medium] > When path_tail_len is 0 (i.e. a symbol referencing the root of a > root-targeted overlay fragment), wouldn't unconditionally clearing > target_path_len result in an invalid empty string "" instead of a valid > path? > > If path_tail is empty, should we preserve the root "/" target? Right, a symbol for the __overlay__ node itself of a root-targeted fragment would come out empty instead of "/". The next revision keeps the target path when the tail is empty: if (target_path_len =3D=3D 1 && target_path[0] =3D=3D '/' && path_tail_len= ) target_path_len =3D 0; The other two findings are pre-existing and tracked in the cover letter's open items. Thanks, Abdurrahman