From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FFE74734DF for ; Thu, 23 Jul 2026 17:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826462; cv=none; b=SnPnOaRnQX3Ol7XiIbLMEdnMc0TVlxYyi7QGL6AONi3J/dVMchsUn8tXScAFMeDBBK+EbEC5uzYnJf3wi2i65U5lPDwMft9Taq1C6Ycm5Pk/gFUqxXWp3ounUpbnALJlS6ktMbzR7zfUBcEuSsMlIbMNwi4D7d+ZhePkeP7X+K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784826462; c=relaxed/simple; bh=9oiQXYSZ0TDKNvY/2UoP3cUFNw+jZM1SghiduaEEBnM=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:In-Reply-To: References:MIME-Version; b=olXFYhjwX6FRPNFSKvMvkNWKG0kcE1ZraGctrM91z+lQHK9ucFMTfMVwaNwEy3RU69eEJBOpGqbmvX/W6QcKCAGi12uuA1Dr4wg3u+ucWCeaK/qYEv0XrSfsQlU7e/4lukVJlwgn+JqVlvG165x9aMOwxH1kpEOwRCoUDwYcCVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=OyLIc6+/; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="OyLIc6+/" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca957432c7fso691427a12.1 for ; Thu, 23 Jul 2026 10:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1784826456; x=1785431256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to:to :from:subject:cc:message-id:date:content-type:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9oiQXYSZ0TDKNvY/2UoP3cUFNw+jZM1SghiduaEEBnM=; b=OyLIc6+/YN28I5AylE6qg4fohBXBaAO+CPH0m4tL8qii1xDTEKWyK0VnbZ+KlJqg45 y8kb0GoaJXqWZbVdQaGY3OHwux92zUiyppeh+bJtA5jpJAoVd85CZoCSNPFPPT+qXKvP D0oLpzvGvFabn/FgX3iABs8CkQb1xqt8IbDVCc+LfjRxHNPXklbbx/1n37cfls6Ig2Q1 UQN8Qiex6rT6BHOcbbKY1LLAsI7cmbnnnv1vokabMUhglAlC/OmqmqqOjAqCf13CtX9p eyumx1teChkl78rVCMmLNNsrWOxy9/xqdgUKweVMunXb0yRYKqCV+Vt3wOGWIFYigPwy F/oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784826456; x=1785431256; h=content-transfer-encoding:mime-version:references:in-reply-to:to :from:subject:cc:message-id:date:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9oiQXYSZ0TDKNvY/2UoP3cUFNw+jZM1SghiduaEEBnM=; b=Xv13kvRkqmZTNR2fG0aV2fXjIL4ri5awZvzsyS8wvTV9DmiXecScadPkIGIuCW4gLa bWhdUwN7O9WbHJl9KfTSA4Bu3yHCtCb87eO82WU4obpsoCpJl/dZKedmHdfyC+PC7/By mb4tcDlitjXQJckv6bvU0tZ570VLix0ZCxv4ZKXK0aL8YwohgUYrGRs4tYwkKEIzdXGu SsD0zLN9Bie0du9g1OB7eKoJjrTwGeZNyO9CGW8D5bdes7NH2Ee+YItIm7IFGmHlglO9 nPKwn658A0Tc7N57Xw4IQL1BRgJsJ18ezykSIM0qfb1iVKZdHuuyutsOrVKNkAX7GmLO eN8Q== X-Forwarded-Encrypted: i=1; AHgh+RpnUOPzQ2FPmP8Cn2tffrNEJnHCG2H7tbnCvm+kRaPYaPVHoNXhXIe2JbTzOLzHIRvI+HCGlU5lD0ULR6Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwRulNas8gW7zImGufvtCQOO/FVisvMv71KFF85nBGUdPfGBxCe pQyQfKXHyqVlU/hWP0K8SXiqWP2RxQZg5Ch3ws6YIfvZjEm2ZdhJTSFYG1TmPfAytMg= X-Gm-Gg: AR+sD13MHzfK5Y+f3gA6dR9NoKerEZ1E1KyHo44VhVZi/sOHMpvjDjNyEq8JS9mw+Kc 2ltGTO5KnB6vZFoJ92gqpA6vGpuLfVZYLIqdXTk7JYp9x9Xq9ls7w+DUHpyyj2ksxPEypFuhgOS JGGUHUdCjj5oz/yqYT+VKjst7ZIpjJz5/ETq8MD2xqZte0TEz9cn/cjmPsg1/qg4WT2fYImLWlU 26oOVsCAz+KftwVrxkeuiPs+lswN6xUqE64AXVgD6kkkN8Gk5KZ0KXQdPGdGE58dwZB5eK+n99a cXOEqIpKeGRjS80z9iOjIoV/qXDluGoPPu/9RH7coURuVzAfJtBcnhCsp9+Ms7Lg2xSvbZnwVV0 0wZJQyHQo4EStvdsWwWo4WJRmfyySH4rgV9BwTWiMnE2lafLEHXdXWolKYClDlNDibO9Gk9sWA4 GByw== X-Received: by 2002:a05:6a20:a126:b0:3b4:6a23:6ba with SMTP id adf61e73a8af0-3c44b006725mr4459401637.26.1784826456047; Thu, 23 Jul 2026 10:07:36 -0700 (PDT) Received: from localhost ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm20460272eec.6.2026.07.23.10.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 10:07:35 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Jul 2026 10:07:34 -0700 Message-Id: Cc: , , , , , Subject: Re: [PATCH v5 1/9] of: hold a reference on of_aliases during alias path resolution From: "Abdurrahman Hussain" To: In-Reply-To: <20260723033554.022251F00A3A@smtp.kernel.org> References: <20260722-nh-of-alias-overlay-v5-0-2abe2bb9cdbc@nexthop.ai> <20260722-nh-of-alias-overlay-v5-1-2abe2bb9cdbc@nexthop.ai> <20260723033554.022251F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue Jul 22, 2026 at 8:35 PM PDT, sashiko-bot wrote: > [Severity: High] > This isn't a bug introduced by this patch, but is the description of the > lock-free walk accurate? > > If a concurrent writer (e.g., overlay application) removes a property while > for_each_property_of_node() is iterating over it, won't the reader's next > access of pp->next follow the pointer into the deadprops list? Right, the commit message misstates the mechanism. __of_remove_property() repoints prop->next at the deadprops head, so a racing walker can be diverted into deadprops and miss live properties. What it cannot do is step into freed memory while it holds the node reference: dead properties are only freed at node release. So the conclusion stands (the walk is memory-safe without the lock) but the failure mode is a stale view, the same as every other lock-free property walk in the tree. I'll fix the wording in the next revision. > [Severity: High] > This is a pre-existing issue, but does calling __of_find_node_by_full_path() > while holding devtree_lock further down in this function risk a > sleep-in-atomic bug? Known, and tracked in the cover letter's open items. It affects every OF iterator that puts nodes under devtree_lock and needs a series of its own. Thanks, Abdurrahman