From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012040.outbound.protection.outlook.com [52.101.53.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43DB3431A52 for ; Fri, 24 Jul 2026 14:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.40 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901663; cv=fail; b=CbI4Iabrvqyw/Bc/IyCaigQeMGfIcCwKumuipwCfbKqEXjeatxqN53GcrOYsRf3Q1Pb3LxPzFGbJRuKJitWOBLJJou38Y/p3RVReiO4NWKBl9OKWr74iZz001nh/mfp63afyBeejzOxIdMZ20tzOZWolTWHTx26zkIRAlt55A5U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901663; c=relaxed/simple; bh=cwZ6Us+IXOtAkUTMLd6Ye1/l/qzL0sC7MxAsDWmRvBs=; h=Content-Type:Date:Message-Id:To:From:Subject:Cc:References: In-Reply-To:MIME-Version; b=SJ9HybQ4xqYojszbOPJzva23i4tsQwW5QosKtdS1UedyQCyAdIV4Ku6nskxL31HwUviTC9rUVRJZOJOsCaGhR5oT05DZ24aCYfRgGAw+BSo83xzHPPaT/7TxCzBlwUg7vIPQUsgomfNeFGx2ugAZ9WuHrfbfEknE3RSiCwCLeE4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=EDbsdMqF; arc=fail smtp.client-ip=52.101.53.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="EDbsdMqF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D3jkFCVy272/idZZjMXKvWLOqp9rQifWhzGbB5+F/0rClzMVeXTatKtTPVgNgVeAGxmSpJr6dzoG6HGX0/tE/ulOjTW2NQ/0o7Teheww5IC+61J80llESnSkF0h9n9KGLz3FoX3RKRp+vuD13LWFkso976ml3A3+kgNlYDreXcVP6JjqXcLCNo08ts4mNknXn3jCAjy3e7CFqQwt8zItV9DXlxRrmYNLruJHaBVPJ9idjy1HjlZU7Z+ArcIBfIM+Up17zgWb4f+CmBcwbM5upWiTa7hjCtLk4ILC07O0LXkCwBkR0WtfL6cIbdE/9dxf0bDPvmJPdDy5hH7FBACS5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eg1z7pWgfMsp+JkbtTGcKPBwFWmrAgD7M5gqYlN7Mx8=; b=qmImNb4I9LXEh+2LT1JGNO0FCbB96xd7AzjvREX752W0yVKmc8ECmnpRbgxCp4ziPwoEBeaKMt0rGe6DKBjY8yjgcLoyzsJl4q6Puf1MzUwGof8PZuxLy//LNa1t7kfNA+LRN739NVoruYP1Gorm40irjHqZG5N23Udc3ugAXOzIxwIWTTpBgOARCcebHbmcQiDWpcl3POWFFDmmbOZo32pS6KEshlikWT+HmNujTFq8EeAbOHEW10WmXbtER2jbJwJ44lFSapj1z6TzlSb6ua5Vq4O3PZzLBdSjbHEWk0V9lRCX3UewZfeuTLQ0eXN0Ared255ApKLItxzVP/s6kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eg1z7pWgfMsp+JkbtTGcKPBwFWmrAgD7M5gqYlN7Mx8=; b=EDbsdMqF2iu/5a/pYOrpWWxIMzmaDa39d7YuNUHQZq9aujTObOfDtklIPASDKpauiiiua9J71oYZbYFFALmL3QhBrEcS8f6xHqKZwScYAb2VnMklEDwglwI1A3JHVuNx57tqDtoYa5e2jrZFTODL2P9HscQaGwgrt3IY/v5Z5rYYHwSTucpeNuCmJHmbZ8+CCMyaWz8ng8lsBnUfxhPk30+yNuvUhmLpzAlnEDkpI7AzTmXE2G40m9oQxsbkM8DD8l4CZa612IA+uAR08wpHrW11uDFHuLmExiqW1SFkNP6Q/abzFM+Lq0VpPY1b17IKJvY9Yu4J00vC/FroLkSEzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CY8PR12MB7362.namprd12.prod.outlook.com (2603:10b6:930:52::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 14:00:54 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0245.010; Fri, 24 Jul 2026 14:00:51 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Jul 2026 10:00:50 -0400 Message-Id: To: "Arvind Yadav" , , From: "Zi Yan" Subject: Re: [PATCH v2] mm/migrate_device: Clear stale mapping after freeing swapcache Cc: , , , , , , , , X-Mailer: aerc 0.21.0 References: <20260724082702.2531024-1-arvind.yadav@intel.com> In-Reply-To: <20260724082702.2531024-1-arvind.yadav@intel.com> X-ClientProxiedBy: BL1PR13CA0097.namprd13.prod.outlook.com (2603:10b6:208:2b9::12) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CY8PR12MB7362:EE_ X-MS-Office365-Filtering-Correlation-Id: 45bd385e-1d02-486c-3423-08dee98bf831 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|7416014|366016|1800799024|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: WPFU1GNp7JvzbCJkzTjStHMgAEhN3fJZJfpot3wZfwFzfh1/Em11I2FsxChzsetjco4R7nVy5HeTPw6bkP/gnA+8C1gA9kNFC8FR83Mo2AelJjqM2lgneg8lOyrzTddgrHgSTKljmWkeBmryF1j43UZkpHPfHcqujByd3uDcbuy2mbTOaVfGzgAvYE/S9IuzwgdnOu5+ZBs2qQfGMx0yIKlbBzC+RMT54foAFDiS8EqG4PsW5UvNXlun4yvEOaPN0iYbyBO7v7y3lVZWS2zg8jGGe7SQFK6ARqLLLVSD3DlXbBIhSvJd4FP2FWGt5+7exZvc0xMpm0ThemXFWy6LVZCF+e4L2wIPFUbRqM4SiFyBVf3MqdpA/ebJ9ej1rnTG83EYLTWbT35iowiq65fDSw+Gq70x6D7igBCfxd3uo5Vj4/bpeFktAjXMgRJgOBmd3Ut3wz2sySKLVMPYTM3oL7C3WjUGx5qpMLHBHd5IpD5aW2xKwqDueN8RxYCX069VwttUpnrn9LJ7vxARTilPeeqoGHDSnxvMJpBT5UgegCN37UeZSyBOEa7uZUrdu6BxfLQPkEGHEJIrGReE0rQ8WlAQdbOzWDydADEi1SfB1RVRaHQHQv67dIkVUYMYeC2VtS36zXlb7a9oGUMBKyGSXL1UEqV5Dvspliix92YB/7k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(7416014)(366016)(1800799024)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ri9RYWY0OVZaWVlZM05EWVVQbVVpMDVVV2xoY3lIcFQxV3NQcnMwTWVTcWk3?= =?utf-8?B?ZDN3VmhheTMvT0VYUzdWYkd3aWFjaWFIQ2ZWSkpsVFpjVlFldHVzV3lhUWcv?= =?utf-8?B?SUJjOXoyQTE0aThjV3JualU5Uks1Yk1rVnJhaVBLMkpjV2FmL2VucCt2MlJW?= =?utf-8?B?RWlhREY0U04wVDhlVzRGcElMRkMvb2ZJaWczUGthYTd0R2x1RkdkcW9WbUNK?= =?utf-8?B?aTJqc0dmUStUdXJ3eEtiUVNNeGprWkZzZUNsYkxKM1dTVjZnOXYyQUNQNlo0?= =?utf-8?B?M0k3cU5scmVKRmVyWmNkcEJ2cTQzZi9aSDlyWERtazFBQWdFT1NGbElxQThW?= =?utf-8?B?ajJyT04rQzM2SnBWdCtsWHliS1ZqTDdwWnArSlN5Tis3WGZnRXk0TWp2Wnpv?= =?utf-8?B?YjFKaVY1K1hPUkJLYmxoaXhFK1htOWM2V0wxS2t0UFBVNWZtRzlXMWQ2WmF2?= =?utf-8?B?S1BVMWdyTkE3TXAxLzdSejZIWGs1cVVWdS85UDNwMytHb1B3YjdZaS9WZExj?= =?utf-8?B?cDRPeFlpNEk2alBWczhhcnQ1SHAwV1czR0J6YkpFZEtHT1pFc0Y1cTZBUE94?= =?utf-8?B?VXA5NEhacGgrTjhJaFdoT1VCR0JyM1Y4aFVoLyszeE9US0RGNkg5VXROMHlV?= =?utf-8?B?RlprcTl1cUhzZnhFc0paMlh1UDI2aGdJRHJuTEl1dHo2TFE1akl1a2drTG1Z?= =?utf-8?B?cWlaemVyQ29xazBSR0I5SndJWGVPeS85K2JnTk9OL3htUStEdCtKMFFTZFdr?= =?utf-8?B?Zm1tNXZzWTZsakF1Ukl4Y0YzOGRjTjRmTXpYSWc2MUtncW92emNMdmJadmZt?= =?utf-8?B?TkVudUtLTWp2WHlXQ0wxbUFtMzEydXRIVTIwSlJGUldtQkNDTGZqV0drYkkw?= =?utf-8?B?NVkrRGhHZHVHREl0WkJFUGNnSWlCWW5Bd0NJYWxzcHMzWk1MT1V5TmZKeEkx?= =?utf-8?B?eThGWmEwM1RHdHNkTmlUcmhTT00xSm4vaW5LYlV6VWRrR1VYRmRBeC84ekpV?= =?utf-8?B?ZkREbmRuWjZYazN6VGNhenVkNjNnU0ExVi9WMCt3dlltcktzcGRsYXV1dE1s?= =?utf-8?B?bi96ekFSb0VTVzRRQ1kzdU51UDM4NEtMMENpUlg2Y3NVU0JKVGFsVUZSS0hQ?= =?utf-8?B?MXlFQnhZRVpycHBWWGNObkFabVQxWXZRbkdBdGFLRXUrMXF5d1V3cmk4MHFy?= =?utf-8?B?T1Q1WWQzZ1pVS0FZZkRoN3JMSDBHZTF2SUdUZGdSU1dLalozOGZYMExqNGJM?= =?utf-8?B?cjNtK2ZSc25yYkgrUDZPZVlGTzE0R2NPbE45ZndiRVRqZVl3WFB3UzY5Vjdj?= =?utf-8?B?NVFNWG9sbXVaM21WREp1SHdhRHJxczlXNTFRNWNVckJFQWRKalZwUXF0NmR5?= =?utf-8?B?c3BLRWxpK0QvQXZaRkdJTkQ0eThNOG1GalZja0JpNFkvYngwam5CUUltNWNS?= =?utf-8?B?ejdSd1lYeEZ3UUUzMXBuSWtESy8zeWVaNzR6OFpBQkorV0F5Z2xuNWpGTlFr?= =?utf-8?B?TmppampSVHdmMzRRSXZsTFZjVSs5ZXVrZ1JtNnhEQXZmWWxhOHl2ZlhzTWxC?= =?utf-8?B?aTlxQzBLQzVUeXg3ZllhYjI4cjlVR25CcVNpT3FPYVNSc0JQODh6V2dCa0ZE?= =?utf-8?B?Q0ljTVBEUGFzdE9CM09DR2QzdTBiRUc2T2htMUJaNWFKVUMxRWdQU1NuUzVj?= =?utf-8?B?UXpFaldGaWhCaGNIdW5rWWpKMXJqdXpVMEZSM1YwQlU5VG00dU5IK2hyTk81?= =?utf-8?B?WHBiRG5SS3VPTUtUNXhSYmlGWnhpbFhtUU5xMThSdGE5R1JWbzVhU2xWYVlr?= =?utf-8?B?WkVyMGs4VEFQcUUxdEZtOEpScWFxeWdVdlkyMGhrVDVoZUY4dDhxZzl6T3Fz?= =?utf-8?B?eCs3TGIwUjloa3NtOFFFZXlpZFNKU0h6SHUyUUphWGpYMGxQOWJKcGdEbGUr?= =?utf-8?B?VEFrQkNBV0o3dWtnTUdoYWE1bjRKL0VEVnNMM2UxVXBwRVltaVpSUythWFhu?= =?utf-8?B?eVozS28vcG43SUtGd1JKYmp0UGdMSTh6d0NrK0hKbW53VEJJaVVTVHIxajFx?= =?utf-8?B?NkgvZEZDLzhmZXdmUk9oZytIb3kyckoyM0Zvc1duVGdBM3JZOW1PWFByWlpv?= =?utf-8?B?NWtRK09VUWdjZ2V2SEZCbVphV09QV29sVi91ZEw2Qlp6R2FvZHEwQWdSOFFL?= =?utf-8?B?OHhURmNDYnArOXB4M3hSeHpJRzhtTFZDRUNrYnVmTXlqV1h1Z0swNDNxU0dG?= =?utf-8?B?YmMzT2ozODZDQlFkNHVFSXBHUWgwWGhDemcvU2xVL1B3cmIwTzRsQnRBQTJE?= =?utf-8?Q?mU+NO50tJeJF8pAxfk?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45bd385e-1d02-486c-3423-08dee98bf831 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 14:00:50.9352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: McXwz+YpHFtRT0EQ3dSq8TqeZ1FagXuEfZKz6Hjpq8o3pgZZUMkYIesnqBi9cVAI X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7362 On Fri Jul 24, 2026 at 4:27 AM EDT, Arvind Yadav wrote: > __migrate_device_pages() reads the folio mapping before calling > folio_free_swap(). When folio_free_swap() succeeds, the folio is removed > from the swap cache, but the saved mapping still points to swap_space. > > Passing the stale mapping to folio_migrate_mapping() makes it take the > mapped-folio path after the swapcache reference has been dropped. This ca= n > cause an invalid swap_space lock access followed by a folio reference > count BUG. > > Refresh the saved mapping after folio_free_swap() so the current folio > state is used during migration. > > v2: > - Refresh the mapping using folio_mapping(), as suggested by Zi Yan. > > Fixes: df263d9a7dff ("mm/migrate_device: try to handle swapcache pages") > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Matthew Brost > Cc: Joshua Hahn > Cc: Zi Yan > Cc: Rakie Kim > Cc: Byungchul Park > Cc: Gregory Price > Cc: Ying Huang > Cc: Alistair Popple > Signed-off-by: Arvind Yadav > --- > mm/migrate_device.c | 6 ++++++ > 1 file changed, 6 insertions(+) > LGTM. Thanks. Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi