From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C63745D5FA for ; Tue, 4 Aug 2026 13:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785850012; cv=none; b=fKeubNpk3wEJVzGwNUrDObfUVa1o/H2iZfN2emqV5/PWNln85cRuJeqGb3KBFW8I/9j4PWoiL/sTaX4Kp+dqUBGc/qphyVViXtLIKXBzR1mOOfHUDkv7G88gukxGJGngAJGnwc7byhTOH5BmJfIY/OSWkgTx7F3nHeHyZe68ECE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785850012; c=relaxed/simple; bh=8785ODvlGI+w88nkKpZGop7jNiOSORDnJDRn/cyEcGE=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Pqc2/gFkhWpGAY9YGVtVhr5eNomsNal4n+i1WlWA9JmC/OdkbTNpy+s3qYbUXvv9fmMxlvE9SyKTcnUI29vge2hvWR5Avr6dB97Z4llmJtw7CMc7xqAOANLppjNWDgXpaq+Tmq4RAWlnFaQB2J/3k4W/YsgUSUSSAZktDFcE67I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=5OyAb1cw; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="5OyAb1cw" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-c20363107f4so6912166b.2 for ; Tue, 04 Aug 2026 06:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1785850007; x=1786454807; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=duKCsGugrWDv5g2IiTe0pk9T5MutZ42wqjHedhx9GgE=; b=5OyAb1cwoOCRYTw1td1JQ3zmu9voEsFh/Bvy+TBYnHZevBe+4HNjfyer68lumGws9l nIPbBtDtpb1kdhtzTiMNFOMUr/T28W+vcMUkVDghAR48/Z6yTMDD0MH3iIXJEdN/f5/V BtmBYEtGqYRgE/qsDG6/xPGFsXkozsWiDRK7WqzDfmDIYiQC+Dw6wH/zQjLxQvM7qjtc w1Ig3tHBnYtx01ko1PkUo770Wp2FSP89zrKXA74AMbrgEWkYTj9+jcORxj9thwAD5yqE /l/EBdpKZ+NFy2svkYem8c3NjEd23XS9+YFrIdgjcMkE1z9le1zLFZrCZlK2VfVH58rW FWmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785850007; x=1786454807; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=duKCsGugrWDv5g2IiTe0pk9T5MutZ42wqjHedhx9GgE=; b=O2MNHXJDSXyuUrYgLAa1LHiE9b0ajYObxIWXtGW/gbt85O32w/rHVL5czrMu1AEvOv K7hl7KAx4xHKqe98dZWn0/umK4fK1fCtZTGZIQkHQ1Vf7rsuYxqVXdNt0i8gi2zawHqt JVe81sQJqAanQpJl6FTmo+fo8H9K4nlCzbZ+dxpu2zNHjgyurQMnduJTab6pI82nNDAK b0jijNhKPBUiuUnp74NgD4hYJxSEWXEf59tBcBRneKoA40QYfVIDQ85UFzDY61iaVY7C NwwXtrCHLCDqg9thkstJGz71xBtQi5aSAVpFxHQplyaPYuS1BbHCM+r4iz1PlSh0MWN7 Qquw== X-Forwarded-Encrypted: i=1; AHgh+RrVtGD08LHZAYMA5QQrUxykf/KZFeiBbzsS6K30h3Tazzmg5b0G39Q6JLCDEjcmn/b6wqEi6y4Z/eFDa3I=@vger.kernel.org X-Gm-Message-State: AOJu0YwpurVjj6itUQGnm24REVwk8AtIzgIsvNHnGP92+5517/+MRf2M 69UDaesxbZvhXHUKhZq1mjcfBjEcMIOIeRyx045qZ/CdbKq+5mC4P6z8K4XFMF1OM+c= X-Gm-Gg: AR+sD12n5BlB4feizx7QJFNBkanyjWcil1+gC9JwW8OSgqloN/4DK/3kI95p9KxNumh PT1AK8ZUagR02uz7tb2NuBmu8U+T34qd7lgnE+/egjMeH8blougz+9nSvBnz2iXLSzOwzBahvOG Yfe4uBCww3mKm0wxEHBQUxiCLUOxgbgt2y57rbJ8HB+GCdn2RdC1IV8wz9PfEdDJM5WyNJ+9O1/ RruorZ5Nd2/Jly5BSRxlO04gb6RtXMZMn5h9RVHyqQMmIudoueMbqR9aTwRujr/CeFuY6cGRhED rnZ7Sv95SeRHC3+q8TBhuAKKW2cI84s1L55ULqDxM9CPgZz71X36UIqtlYdX95bnSfxNMovundk E9KDyRmuvLYIyj1iFLZ1vFjsndyulR+u99Svi5sBw2qCuiFi3NKRZ7yfk5Qcoh+lI5BqdjOTaUo GW49vxMYwJUbb2oBEH86DgRtvNwLH1Wf5BK3mULEf1fEaCrdzk5s6MDsIXYA1ppmgeiwIFq5vpO i4d4+00hEFio/h4orN/kfJiw/d2JDI7aC/aLL6QHff5 X-Received: by 2002:a17:906:fe43:b0:c1c:2c32:1163 with SMTP id a640c23a62f3a-c1fe7f4b006mr1435330266b.25.1785850006304; Tue, 04 Aug 2026 06:26:46 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203644c62fsm9811266b.53.2026.08.04.06.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 06:26:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Aug 2026 15:26:44 +0200 Message-Id: Cc: "Konrad Dybcio" , , , , "Krzysztof Kozlowski" , "Krzysztof Kozlowski" , "Manivannan Sadhasivam" Subject: Re: [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies From: "Luca Weiss" To: , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com> <20260803-phy-supply-fix-v1-14-5880630cde3e@oss.qualcomm.com> In-Reply-To: <20260803-phy-supply-fix-v1-14-5880630cde3e@oss.qualcomm.com> On Mon Aug 3, 2026 at 8:34 AM CEST, Manivannan Sadhasivam via B4 Relay wrot= e: > From: Manivannan Sadhasivam > > The QMP PHY expects the vdda-phy supply to be around 0.88V and the > vdda-pll supply to be 1.2V. But these two supplies are swapped for the > USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to > vdda-pll. > > Fix it by swapping the two supplies back. > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairp= hone 4") > Reported-by: Konrad Dybcio > Assisted-by: Claude:opus-4-8 > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm= 64/boot/dts/qcom/sm7225-fairphone-fp4.dts > index 23f950067a08..bea82cbc2c88 100644 > --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > @@ -1247,8 +1247,8 @@ &usb_1_hsphy { > }; > =20 > &usb_1_qmpphy { > - vdda-phy-supply =3D <&vreg_l22a>; > - vdda-pll-supply =3D <&vreg_l16a>; > + vdda-phy-supply =3D <&vreg_l16a>; > + vdda-pll-supply =3D <&vreg_l22a>; Schematics confirm: * VREG_L16A_0P88 <-> VDD_A_USBSSDP_0P9 * VREG_L22A_1P2 <-> VDD_A_USBSSDP_1P2 So this also matches. Reviewed-by: Luca Weiss > =20 > status =3D "okay"; > };