From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE873B0581 for ; Tue, 11 Aug 2026 06:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.201.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786430215; cv=none; b=ekHcHTbvqlp9MNWGfo0C+b5mdhqZcqR33OAZojAj8Chfw4uRPABnBtlXL+lhrPWr7YqyQRf3guWQKQ0n/2wb0BhHvXvuK0tbtp7Mu98qOUVXQUAaK7xVMLcifepUbKf8AH750jBrZmP3Jqq5nkBTV12M9g+Q7vwMirI74Rrjtm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786430215; c=relaxed/simple; bh=zbDX2n8ImO1zHfpw/ffhACwNLUiglY2PzCfx8IFmNnw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=KN9VJjqrgtgq+XZX/p7y3sXV3+wCcPpfdnO1+cFeNPd/kwnJ6pox+pcMvWHvH8KntBxksEZIzRk9ySPs0ikYxAf4YLBn3zJc3AhroYMRDBrOuqtGCZsOJihVvaCimueP4FUHuRDiZn6jl2UjSs+kZjNo5DZnj7pKMQYBpIChg5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=walle.cc; arc=none smtp.client-ip=159.69.201.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=walle.cc Received: from localhost (unknown [IPv6:2a02:810b:4320:1000:4685:ff:fe12:5967]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 74857116; Tue, 11 Aug 2026 08:31:18 +0200 (CEST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 11 Aug 2026 08:31:18 +0200 Message-Id: Subject: Re: [PATCH v3 1/2] mtd: spi-nor: Add support for MX25L12833F and MX25L12845G Cc: , , , "Cheng Ming Lin" From: "Michael Walle" To: "Cheng Ming Lin" , "Pratyush Yadav" , "Takahiro Kuwano" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" X-Mailer: aerc 0.20.0 References: <20260605084837.1875896-1-linchengming884@gmail.com> <20260605084837.1875896-2-linchengming884@gmail.com> In-Reply-To: <20260605084837.1875896-2-linchengming884@gmail.com> On Fri Jun 5, 2026 at 10:48 AM CEST, Cheng Ming Lin wrote: > From: Cheng Ming Lin > > Add support for Macronix MX25L12833F and MX25L12845G SPI NOR flashes. > These parts share the same JEDEC ID (0xc2, 0x20, 0x18) as the legacy > MX25L12805D. > > The newer flashes support SFDP and 1-4-4 Page Program in 3-byte address > mode, but this 4PP capability is not defined in their SFDP tables. > Conversely, the legacy MX25L12805D lacks SFDP support entirely and does > not support 4PP. > > To safely enable 4PP for the newer flashes without breaking the legacy > part, introduce a post_sfdp fixup. Since the legacy MX25L12805D does > not support SFDP, it falls back to static parameters and will never > execute the post_sfdp hook. The newer flashes will successfully parse > the SFDP, trigger the hook, and safely append the SNOR_HWCAPS_PP_1_4_4 > capability. > > Signed-off-by: Cheng Ming Lin Nice! Reviewed-by: Michael Walle