From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010033.outbound.protection.outlook.com [52.101.56.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2250F416844; Tue, 11 Aug 2026 20:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.33 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786481130; cv=fail; b=JmKEpWgjYhN7IWbiZjdSIVxbeEpgwvq4H0pQQvRU08tphYqUh7P+pRjURi58tmw3ZTbybuLRM+X7Zl4ELqBKRSpRk2tjLJ+YR/jIstU30nzkKfMPpzmUf/SeJGUpn5WI50zqj5ZeEKeBb9IDRNNLpaCQGAZHdxezcp1bLy7Wt7g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786481130; c=relaxed/simple; bh=ZrQePkNYuATd/qxt1wfS5xXPvd3P43sbDpgMv57MH0k=; h=Content-Type:Date:Message-Id:Subject:Cc:To:From:References: In-Reply-To:MIME-Version; b=J755oHiusoSRD+BzyNEdnd2TPKxl0hXbBTGU7EANRznXJuQ2ZuKIH7c6+sCkvCDk+118n2aA2B/fuBHj7ix/BLOJc1JWqlVrv/QSf31fhYK/O3dsiPcluxyeZnlrJqLk5C9zigUZSe+Bm2dJvqnmJM6t1etoToIVQH8w+k9mz2E= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Czrvp8BJ; arc=fail smtp.client-ip=52.101.56.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Czrvp8BJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Obtgh+tTxnxWNkwEJZYq5CV5sRkQvONqvWN5+DYTNAknJyKTrhwNvnFR+GSldtt5YypeE1rKUNtyuLaDjoNCUrLQmesAldXZpn+NzM9AmZ061D/qnYIV72/ymKgumacS0N87JSsBRQj+2qe2UrpZuEH0DYUwbIVlJaN8a6YmjiDhnEZBWy/AC3L86/mkLWYDxTsMu1IQnMxeN88oXhT4cE/AL2+Qop6AjVvDTk4+oD3YufTVJK+sZ1GHPR5vX/ZRgpNdsu8uCetBp8TNSyZpgdqCKrCUK8/Zqs8qLM68wUqvKtcfvrmPvZCPXC4R0FvlX5CJmNUvpSD+2TBQSrK5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G7vBUUVyPlhK7EGMCvtgvUsI/ONmOzvcNfbyZLz2ZkA=; b=rDER7pZbiFA/jRa9E6E2QZtc686gY1TbD2szEu31PR2bGebXnTrCPGH90olp0mOo4ON1YnL62Z/fMacLSB+JqCwDrJq9QAGFI8figcWa+GR+HU/s7OaArxYH3ZnuMo57f0w0+BngDs4teXyTd10/MpB1TTlTOkThF6ENQ8KdvzKlCbxwYxqexx7oyyVOoDb5/0HwJBDjPjDi1/+y6Xr6OBxqGFbRVbNwjgGDr9w/SAOOp+heSvSmM+MFdZHf1BTU1nqeQgpjR8EzX7GBhX9xYPxp2Ol2xKNloNrgYbfvTvDNtktTcP6leskknCmhBntEJmK8VGi2oxV8A8ogiiwLrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7vBUUVyPlhK7EGMCvtgvUsI/ONmOzvcNfbyZLz2ZkA=; b=Czrvp8BJg8XI+oqE19e8sG39V2jkBZQleRr7ld37YvVQhC8CoCcti6C14l1rWEjgh5cWGy5sKBDfkY6VvKiY9CSlKf7cxlHd4tMKwJulrvpyG19t0uArMR2adWwMIbScEd0sw6hcc35DzHJ7TRc3howb0lPs7RyPVpe9fER0GpyfFwWWpI20ptszXMV96tMPXQRvQxbFFvbJilGol023HMOXuE7LAasDVNF+ltar/pJcy8I/CmPikUMj3uPbzMbTKYxhWKjTUqzwk1Lk5Tr9rngzCBtniTiDw9Zr6SBOlIeuUhxooyaZaQwBJgB+a3daKwuPSWNahhO5s+V3DI0mvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by DS4PR12MB9612.namprd12.prod.outlook.com (2603:10b6:8:278::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 20:45:17 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0315.011; Tue, 11 Aug 2026 20:45:17 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 11 Aug 2026 16:45:15 -0400 Message-Id: Subject: Re: [PATCH v4 2/7] mm/khugepaged: extract reference check into folio_pte_referenced() helper Cc: "Andrew Morton" , "David Hildenbrand" , "Lorenzo Stoakes" , "Baolin Wang" , "Liam R. Howlett" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Usama Arif" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Jonathan Corbet" , "Shuah Khan" To: "Nico Pache (Red Hat)" , , , From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <20260811-khugepaged_pte_refactor-v4-0-ddac39d61c4a@linux.dev> <20260811-khugepaged_pte_refactor-v4-2-ddac39d61c4a@linux.dev> In-Reply-To: <20260811-khugepaged_pte_refactor-v4-2-ddac39d61c4a@linux.dev> X-ClientProxiedBy: YQZPR01CA0073.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:84::28) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|DS4PR12MB9612:EE_ X-MS-Office365-Filtering-Correlation-Id: f44b79b3-d55b-4c11-60ed-08def7e973bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|366016|1800799024|4143699003|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qqadqeJP6ljRfIS5bhVI3b+0+xS3trHyLFn72tIf08VChnH6eP6NThhO5LM83gRrPe8UkFFF0euIoEEKJ3aTHFbHs4Y4CbE8HAQX9t7S6D8MZ12ivVKr2HiiEkiZxPbYzYpAjSIeIOj00OXeasw0Z3TimEvI8WHWPWQb7UBPSfz2sD0LpNfuDYxnhEG16v/g6Plfp1+O7vaD6E9LmkQB6xg2zZ55ffQblBdKbK4BPtjxEXSwgcYL0iyxO/c17dRDjWrHe6uaHS4yycZ2NZySp6d5dQQ0BOyOAdIaECWEudjpB1FDtviHf9XiP2vP2Tld4zxDyPO5D9b2WwcRjbfn3qRSJI/TN7emo19eCZenE9fKE29ujl2ZVPDkEF711UiY02QpY74ZWc+5OnLkhnUX33jX1SP3mZEhDO1bjbD8vzRqJz08GFrPY/QyW3aSA98O2Gr6TYirhIMg6tpd7bo21JYuZ3FGMhMULenfv/0oxIo3HAlAy3JHZqSaBWthN42on9qWwGh5Hxt4Ilm8z4IWZSMwkwqV7O0S9WIoxVt5ylagpnhha0jjrNi5DR+HoYqJ6JvMx4dHv+2+QHvgT78sd+i214xX1mjKJEVtTvtEnRq1Zg00h+PjqxzLfqh0u8F31putctH65D/NdmrLOcg5MwdtnVIbXbfsqajGeN6cBuk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(366016)(1800799024)(4143699003)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkZ0bjN1eWM4c2dtVUtBemxvb1o1NFdGWlRZV0t2aVorSTgzZ1IwbHJnQ2pB?= =?utf-8?B?VDFnWVR3RzkrRkkyQ3d3VVMzazdOWnZJRGlGZGVxemI5ZDFLcDdBcjVMVUNO?= =?utf-8?B?VmY0MDVKZWcyak8yVkY1ckV0S2FwZCtpRTZNU3pMY1lJc0daSjBna1dFUnFB?= =?utf-8?B?VG1jOVJ5WThKUzBZMi9MT3B5Y2VMY2k3ZSt6bUhvdWZZTHJRb1haOU9nK2gw?= =?utf-8?B?SDd3ZERabHF5TURtOXRXWUNvT3BqN01IZVB5eURxblZwbWR3bWJJWFdOMUNu?= =?utf-8?B?d2swbDlJTFNOdmFqNGpaYXNFWXdoSWZteTQvTkMrWWN1T1phUVZrQzB6SlJq?= =?utf-8?B?cHZLVFp0em5zOWdFeXlKK211c2dvM3laOVRBT2xZZkNMbEJEa0wrOXo5dWcz?= =?utf-8?B?UktQODM5UUV0b2V0Ukw0Q3c4aVFJc3lzc0ZnYWxySVRXaUFyZFNLbllMbnBJ?= =?utf-8?B?WitkTDRxRUJCTmtvTThBN0NLTFFhZzRVTUJNNWFVV3FZdlBOamNWa2ZkaWha?= =?utf-8?B?TGk1Q0ZpdGRnWkJtQ3ljTjNWZjhxQ1RDM0xuOENWZDJXM1ltLzRVdVhXM2tv?= =?utf-8?B?TnBzczg1VkxuQytDV2JyOW42ODNOQTNpSFQzOXgxMld3akpmVUc1b3R3bFNS?= =?utf-8?B?K0NtYVpXeVhnc1ByN1pSV3lkOTAvUHhIemV5aGo3VzVTOVZXN2RmVkNESWJx?= =?utf-8?B?THZPNUE3YUhYSXhxS2xTWkxqeGZCcWZ0ZW1mRkV2dGMrQ2dlci96ZXJDVTdl?= =?utf-8?B?dW41dEpDSXN0NEpxTG1jb2dBSDZFaDU4ZSs0eGJ5a1BQYllJdnN2YlozVWlS?= =?utf-8?B?ODlMWU96YzVySFl6cmo0SGs4MHRJS1BGa0dTVVd3NlBIaUtuUTdETG9YT3Np?= =?utf-8?B?dXJuS3BVRG5HdndzOTNNYkVrc1g4eTl3TmpocVV5SFRrVE5YNm54VGdQZ01F?= =?utf-8?B?U2pJcEpTM2M3YnFpanJFZmcrNjhTWGc5U2I5dmEyYkk0alpLemRUd21qSk1O?= =?utf-8?B?Tm85Tk5LdG01OU01V1JVMDZCTXNMZVAzdy90YXo0bm95eExkK2lmWm91WGhQ?= =?utf-8?B?Qm5qNW8xY0hMTG44NlNjRVBNdUVIOFZwcjBVdzhlRnIvRXVrQUp4RGhRUFg1?= =?utf-8?B?cnRKdXJ5a0k1ek9DMU94ZHBnVStETnArQWM4R0NaL2lqc2VqWnFEYURnQk9s?= =?utf-8?B?WkVRbFI1eTFOSjR5eGd4Slo1aWg1TmM1TmtPS3FIWnBZZ05xazVLdExJMlZQ?= =?utf-8?B?eGxNRDF0dWVlaTIxVmxRU3NHQVQvWDBPd210UUlJMkYzMXFFa2JhVW5VYnZY?= =?utf-8?B?dG05dERTUkNYbGI2bjJ6UXRDcFUwM1kwNVVYV1poeXVGaUpqRXMwa05VZ1hl?= =?utf-8?B?a0lESnFNZmtEK3k2WUFrbVpYV093YjdsSUdyQzhiRlJQNGdjYjZSRGg1ZTVx?= =?utf-8?B?YmRGY042NWdMQTJWZ3FXYkNTTVMwV2ZYam5WdXVteWRaNjlKSE14TDFmTTNS?= =?utf-8?B?NEFpODZqWFBzckpSaGo3bnZob0VTdzlkRmgyV2YzM3JTVzFCQWxqYmdVK1NV?= =?utf-8?B?REJYbWlFaElRamNjVXdWNnlueVpsSjFhWWdyaFdEUjRUT0xySjNuV0E3WWdW?= =?utf-8?B?MllIbnJTSjV5WGtUb3ViTVJwdzQ0MEVLTjNMa1NwckJ2VU1qQTNPMURyZURZ?= =?utf-8?B?N3REZ3kxQ25wdllKRmFZaXJhQUF1dk9LSkd1WTNPcGgwMEZMSHpObDJIQVJD?= =?utf-8?B?WW8yUzFiNU0vUVkyem1UODRkT2hqekpIOE5tVFVkUXJWemZmWHJpUDN6cHl4?= =?utf-8?B?QWZNUDkxWEx6c3NnbitZU0FNeEdRRFpGOHBieHF0Q0M5TEdmc2ZSMFpuUFNr?= =?utf-8?B?WWU2azRoNnVSWkM5aDJ0RGk1eFZkUE5WaWxTYzRqeHU2RVA0aHh0SW1kemlX?= =?utf-8?B?WG93UmVVdFh0QzdNTGF3VkY2MUh5Vk5vZHY2VXNTbTJEWE8xUm9JYSszTGtE?= =?utf-8?B?OXNVTmswN29ONmhKc05yMzFwYkdxeVgxZDVFODFTS1lndjA3c290V0x4bnJP?= =?utf-8?B?Rlg3b3hoTDNzUmlkLzRCU1RmT1ZZdHhBT2xVSDhCWk5Za2dwMGErZDZVSUpr?= =?utf-8?B?bEZsREk5MzJlMTJ2Ulk4VW84em5RWVZsRGFKSmJQc2E2UXhjK2JrSEpGR3NW?= =?utf-8?B?bmh1bHRrdll4Q2E1eG5GQitPcnlRMVBTekc0dUM5RE54RnFRQk1HY2tHWW1V?= =?utf-8?B?ZXJPSjI0NUdSMFhzUVVWSy9ObkFKUGJzeEo1VTRXdVlQRFJ0cU0ybDNFb21u?= =?utf-8?Q?vqCjCtAZlMdsuPKiI/?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f44b79b3-d55b-4c11-60ed-08def7e973bc X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 20:45:17.5577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EELpBBLbwTSt6pxwlH/wDNEmvvzReOa0ZvNmtIUfIYan6Bbi3LjhEt0oXv7m7pkk X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9612 On Tue Aug 11, 2026 at 8:48 AM EDT, Nico Pache (Red Hat) wrote: > This change deduplicates the "is this PTE/folio referenced enough to be > considered for a collapse" condition that was repeated in both > __collapse_huge_page_isolate() and collapse_scan_pmd(), extracting it int= o > a single inline helper function. > > Also move the comment and use it as the function header. While we are at > it, updated the comment to clarify that a young pte is a recently accesse= d > one. > > Acked-by: Usama Arif > Signed-off-by: Nico Pache (Red Hat) > --- > mm/khugepaged.c | 32 ++++++++++++++++++-------------- > 1 file changed, 18 insertions(+), 14 deletions(-) > LGTM. Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi