From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 527503603E0 for ; Thu, 13 Aug 2026 15:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786636008; cv=none; b=REYJgJzSSOdV4CzryuqoadGPgjJ7nQuxYD9SnW9LvXWYDp6v0scWtFwk42QbDnHnXnIIZBurlvz6tetwi0yESjXya8t72JbJkszw2lLGxfn53vmp1IpoMWfECBn1Amo6b6FGACHINzWsqm0nQFm5jXOLB3OGJpG043XAAkM2VpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786636008; c=relaxed/simple; bh=VvvSWU1z6gNgzJq3hKzNJLAXvt5lEZTq3+S78iDvHfo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SRQJFvq8towrUOAs89Q72hTA1+fav4RGqXJebXCtxSekhQHfN/i9ECzvKkW0Ujz4JoKlnXU6yQlRxe705PGRZV4Ywi8DGCtCIg5gB3iRMVT4/6FzFBLPF6Un7NTMa4PtMmibjIVVM+FgyHPX05EFNhlmv9W3gHlup+B56giS8YQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qwiqCVvW; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qwiqCVvW" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=VvvSWU1z6gNgzJq3hKzNJLAXvt5lEZTq3+S78iDvHfo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786636002; v=1; x=1787240802; b=qwiqCVvWtk4b3jpThTjnUMgeW/euGPyxx05hS43njfUfL4ZHpMU6rq/Ey3SLDeIZywHQY3Al lyEjvJ6CYtpS+h5f90Ur5pJyMbd2TI17eI3Pixw0CHO8NPUWSt+eJM76aOmjoGB/7iGggCQ2sJ9 l+EkdG5x+BVVp8p70bzPE/qA= X-Envelope-To: linux-kernel@vger.kernel.org Received: from localhost (77.97.51.77) by smtp.migadu.com with ESMTPS id 834805d10310483a; Thu, 13 Aug 2026 15:46:41 +0000 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 13 Aug 2026 16:46:40 +0100 Message-Id: Cc: "Borislav Petkov" , "Dave Hansen" , "Peter Zijlstra" , "Andrew Morton" , "David Hildenbrand" , "Vlastimil Babka" , "Wei Xu" , "Johannes Weiner" , "Zi Yan" , "Lorenzo Stoakes" , , , , "Sumit Garg" , "Will Deacon" , , "Kalyazin, Nikita" , , "Itazuri, Takahiro" , "Andy Lutomirski" , "David Kaplan" , "Thomas Gleixner" , "Yosry Ahmed" , "Patrick Bellasi" , "Reiji Watanabe" , "Sean Christopherson" Subject: Re: [PATCH v3 04/26] x86/mm: split out preallocate_sub_pgd() From: "Brendan Jackman" To: "Mike Rapoport" , "Brendan Jackman" X-Mailer: aerc 0.21.0 References: <20260726-page_alloc-unmapped-v3-0-6f5729aa9832@google.com> <20260726-page_alloc-unmapped-v3-4-6f5729aa9832@google.com> In-Reply-To: On Sun Aug 2, 2026 at 5:13 PM BST, Mike Rapoport wrote: > On Sun, Jul 26, 2026 at 10:22:37PM +0000, Brendan Jackman wrote: >> This code will be needed elsewhere in a following patch. Split out the >> trivial code move for easy review. >>=20 >> As a side effect, change the logging slightly: instead of directly >> reporting the level of the failure in panic(), show a generic panic >> message, will be preceded by a separate warn that reports the level of >> the failure. This is a simple way to have this helper suit the needs of >> its new user as well as the existing one. >>=20 >> Other than logging, no functional change intended. >>=20 >> Signed-off-by: Brendan Jackman >> --- >> arch/x86/include/asm/pgalloc.h | 3 +++ >> arch/x86/mm/init_64.c | 44 +++++++----------------------------= ------- >> arch/x86/mm/pgtable.c | 38 +++++++++++++++++++++++++++++++++++= + >> 3 files changed, 48 insertions(+), 37 deletions(-) >>=20 >> diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgall= oc.h >> index c88691b15f3c6..2aba6cfabf495 100644 >> --- a/arch/x86/include/asm/pgalloc.h >> +++ b/arch/x86/include/asm/pgalloc.h >> @@ -2,6 +2,7 @@ >> #ifndef _ASM_X86_PGALLOC_H >> #define _ASM_X86_PGALLOC_H >> =20 >> +#include > > I think this should go to arch/x86/mm/pgtable.c. pgalloc.h does not need > printk symbols. Yeah thanks, no idea what I was thinking here.