From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A85A494838 for ; Fri, 14 Aug 2026 17:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786730233; cv=none; b=FGz6JuxTlnZ8gi8l4XCTQb7EXj84OHVXb7g1S8DvmSHydS0DrKOyxihgagL6aE5lXaNdOMUe3Xzl5eS6AffSrW5irR0eDnfu16JSqrWlN3YKUlYVxdguCL6bAFvCja40RqJSCfwb6iSStig7FWX0+Bu1Vk47vCcIBaYHNOqbdsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786730233; c=relaxed/simple; bh=CCsfE2oeXgk17KlO6HGMktCK5aeGy+7VHisTD9GROeU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=o4AcefC7z7wYl5S1rcjzHz9yTjNHkB9nRguD9IMBRpbWTkBsw71JpCclwttZXyRb/anWkHsulNKT0Cb8orbqIdrzsekib9ccQrHedXGg2gum6FJunltCChW+l2F3tSUpTFLu7rTTwnMq5uw/6/I4cEujUucWKSqjeHB8XKWCmmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=OGnOanLr; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="OGnOanLr" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so1463299a91.0 for ; Fri, 14 Aug 2026 10:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1786730231; x=1787335031; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=CCsfE2oeXgk17KlO6HGMktCK5aeGy+7VHisTD9GROeU=; b=OGnOanLrdRC/BUjMOgzkuGCJ38Dcv5or6o6a41dcMDPULxaW73vBUi0NwkUszCJVvz uAzsK96adSI5woV/rUrIAo6TnBIT+7OzQnlA7jAbYE7WzI0iUBwy1ii5/OKT51yN24e/ 4BPFBw6VEkLqiqS1pN/aqVZyIfFGOgb7WKCEyXRgxbz8Sri+IJQIHwjEDupLQPxqEmGK vg1DWH4+00bnekM/J5HVG7osP/KxvBrnFidpOf0QCck2MEDZof5d6lcFkWIUCPccVKit fJUDk8+muLyOhpWFQ2e++/y4yndVBGILtrF7Kg5nOP8w86DiSVgJZoNbJ3IUT2UiVHGa rQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786730231; x=1787335031; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CCsfE2oeXgk17KlO6HGMktCK5aeGy+7VHisTD9GROeU=; b=UuMcEP0EwMF5F94wHWcu/6wCxMLgBC51yua0BNxGQ3m/Z3y2MCoGA9JfG2EXuldbzC 5/kIU0/Zc8Ztlcg+A5e0tUxbxjzyOL417mc66Rc6r+RCXEBU9oOF8z9CRvyemgLwFp4o a6hcSCqZJk2nzHFFiviv6DDe89mIf7zHggWQB1J9t4X3CK1UW5geOAq1H6yVyYu11ziH lZvDwhzBzeElmDgc8e6LIuD3eul48vgM2k4r9rLIZCO23o2tCkce4JsQtfEhogHo97k6 DFcqWBMn+mKowmwdmGchBYHNnGFG9yOJpqs8C2/ci9mMalGs7+HYiorr3p+PDM8UoqS6 QJWQ== X-Forwarded-Encrypted: i=1; AHgh+RoSuoS2K5Kkuh57bmKtAOSX13fVj4SO5aYmaG2fRgi/ytHmi/B+nG0YhDuDty0O0Uwk57Wrk9ga6TEWZEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwQVEk1cDwXH0zUUUmESgqzD/sX5n/3AYQWD3/s/2Fa2uRAboO9 8byUTtaPxdfp+NpzEvZR06lVZ+anY601YBkAhdMJYG8uXSQtlOr3FWNdKF6Yg9nL94k= X-Gm-Gg: AR+sD11eHXW8XRTQhPAAHBwM6RsllNfy18DP7J6nF8hE6GbpeTxGdKLUP2av+KuJs21 LXOmmXiF79/YtxNbbMRCZtYTOUCcvIMNY3mA/RzROSssEHLmA+nTc/IN2w73bdnt4g+JsVrGOGN q3PeXwAC7mSR68d/v5a2zm9n11KxzoOhCNUyxsdZHXF4zAiYmjUAa+Bum7doocJiHPs6Zc2lbdT YYsNKKbW1Rc6Njh6C9A3yiUt4qoasHsePXrjYdS+mWlAy3w1Hlkpj60t5KJtgxLelp/wf96x/lb 6JPsZqGljkAnmt7onRhJCpig2vQtf5zTAQwmW9pz9DYuvOyQIi3EJpbaVbOW4+EsK3//dwIS2h8 sxqfL+WWR8COjcZhORrbkzSqORuFk31QGoM3RvKAt6B+ivCAf7TC5fpYcHtDZaufZHaDfshGpjH 5D8S+9dOIsE3LoN6Hqa97f52NXXtiijq6udc2Fvje26Ftc4B6sdYSqln9fa18sTqNCLQcxz+M= X-Received: by 2002:a17:90b:528f:b0:381:cef1:11ac with SMTP id 98e67ed59e1d1-3933e5d202amr8549727a91.10.1786730230603; Fri, 14 Aug 2026 10:57:10 -0700 (PDT) Received: from localhost ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320d5bdc5c4sm6924004eec.5.2026.08.14.10.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 10:57:09 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 14 Aug 2026 10:57:08 -0700 Message-Id: Cc: "Michal Simek" , "Andi Shyti" , , , Subject: Re: [PATCH] i2c: xiic: restore runtime PM teardown in remove to fix clk WARN flood From: "Abdurrahman Hussain" To: "Andy Shevchenko" , "Abdurrahman Hussain" X-Mailer: aerc 0.21.0 References: <20260813-i2c-xiic-restore-runtime-pm-teardown-v1-1-0e7dfb206790@nexthop.ai> In-Reply-To: On Fri Aug 14, 2026 at 2:30 AM PDT, Andy Shevchenko wrote: > On Thu, Aug 13, 2026 at 02:06:40PM -0700, Abdurrahman Hussain wrote: >> The devres conversion dropped the remove-time runtime PM trailer >> (pm_runtime_disable + pm_runtime_set_suspended + >> pm_runtime_dont_use_autosuspend). devm_pm_runtime_enable's release >> action then calls pm_runtime_dont_use_autosuspend() while runtime PM >> is still enabled, triggering an immediate runtime suspend: the suspend >> callback clk_disable()s the clock that the devm_clk_get_enabled() >> release is about to clk_disable_unprepare(), and every device teardown >> WARNs in clk_core_disable() ("clkN already disabled"). >>=20 >> Restore the trailer: with runtime PM disabled and the state forced to >> suspended before devres runs, the suspend callback cannot fire and the >> clock enable count stays balanced. >>=20 >> Fixes: 50c63491ff26 ("i2c: xiic: switch to devres managed APIs") >> --- > > ^^^ Something went wrong. The SoB must be part of the official commit mes= sage. > Putting it under the cutter '---' line makes it disappear. My bad, Let me fix it and send v2 Thanks, Abdurrahman