From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010008.outbound.protection.outlook.com [52.101.61.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E4CA3D903B for ; Mon, 17 Aug 2026 16:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786984814; cv=fail; b=ItCuxae42E8WxU+Kv/58LZtWNg/q1aQcfqRNFo0Xk1QmPWuIIu3tr8EEfhlze0c2Kl3xWacQLCuesgYdEpvrdUmzdAbk39uWUyTF3FmhrAd2gDFsXBeFV7MXAnjzU1W4tj309g3TyMGhmCbSRvxHn4+UG8eS9AEyC55aVh6jN0Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786984814; c=relaxed/simple; bh=6s7JasTl1h+4ChDkur1At2+UJeBnldmG6U16N+mrzxM=; h=Content-Type:Date:Message-Id:To:From:Subject:Cc:References: In-Reply-To:MIME-Version; b=cZwNipgiaS6GfemSFg3/sFFJQP1ENJIOMZF5rfB4C3ZnGlSZ+rxQQDYEI0g52NbIEUkKS89sP8vtx9LgcmB7QNgPJHrPoYmkL6BD4VGgZgUsN9Y8p2+YfBsNePH1ES1ONEcMSJKr3U1GQeYG3WTyCeC4alGX382dbffC8zCFPVM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=rDkaW2Gd; arc=fail smtp.client-ip=52.101.61.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="rDkaW2Gd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZBxQbtE+5DyRDNgxX2HxrDA9hpPzz9hnw188o8ihc72t0Uy07hmCsC2F8a6ndG6IVBzHt6UiU/0aQ9e/KWxE7Ncc0zcuL06f2Knz/V7E6Si/oqps6AiJmnX359klV+GHJunyiebFR4izNaQRZfbs4iVCTJaHcjENo0nA9y3Xccziq0jQ/Pr7dL/5sr4uU7Tq5Yn4l08MDY3Ac7RbhWafUBRpfSGZEBywhPWvGoWxgFLZaQwpQ5cnBEcvm7WF1+w2Nnhe5sM0YhBYJ11xfjsni2Bjq7pGz7tT2er5txV4nNqvXHCON4j4kIHdMqVG+6bRhKfiNjZsF2fWxCHMsjFxPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRxah7E0qyX+cJMrpoZKbEhaIb3D6wGIYLakeSyndDs=; b=m/mT3KEzDtnb+2fxb1VMZHOsGUT3MORz9SjDFK0ZIpWlanvSZTMUkFKUAdpzV7FvywR3vN3Ld8O2vra8JKoA6VnlkLEUWT+lTfVR0ajwOk94Ko87NWHVt2uD/GBQuDbti84bQ5a5FIjeQoiZNjy9XMqGKloMubC4mG/3X6oGKJXtm6e33AXVJUz6cjYZ2tyF9BSi7506TK8MS0QBkv0okJXdiiLyk0wov0iVfJ9vFYO+A2D9rNoTbMPMUwzjqu8V9WzDIeh3FcmHN9CSvdXWqbywqYTlb3lzo++d76imknnFZqaSw31Qbi1/HRt1XJRoYTWX5Uw8eqqCo2eyi9sewg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRxah7E0qyX+cJMrpoZKbEhaIb3D6wGIYLakeSyndDs=; b=rDkaW2Gdzxp5ECzO8kGJXq8kCbLbfjdWAcPtNHsUuPR4fyx70bDTucFd+MNafPn+YOY2ISLkiuWCZqd373/hRQVwZWAWih+gOv0pnaIwUvT/UKE5glZrkq9N5MwYhCLzzBtqGsW4y5iImgA46R1JXrPSaI5yI1WxmJfTgGYxUlmVB23C/exAevGVNqLMsBFxihSIgwWsoVWsI1YuJ2PLTu9GNKrvHzWteb0mhWHq+5e4L1TeK2m8DHHKAkTuf8wlxg2k/VARzK9iKCrUS5nS+tW9Mj+XVwPUDPQfZ3ob9RGmAnKzBPC+jypjKQSd61rON9QFDlbxpoXNYbTyArWCmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CH1PR12MB9718.namprd12.prod.outlook.com (2603:10b6:610:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Mon, 17 Aug 2026 16:40:00 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0315.016; Mon, 17 Aug 2026 16:40:00 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Aug 2026 12:39:58 -0400 Message-Id: To: "Hui Su" , "Andrew Morton" , "David Hildenbrand" From: "Zi Yan" Subject: Re: [PATCH] mm/migrate_device: fix cache flush when replacing huge zero PMD Cc: "Matthew Brost" , "Joshua Hahn" , "Rakie Kim" , "Byungchul Park" , "Gregory Price" , "Ying Huang" , "Alistair Popple" , "Balbir Singh" , , X-Mailer: aerc 0.21.0 References: <20260817060845.377800-2-sh_def@163.com> In-Reply-To: <20260817060845.377800-2-sh_def@163.com> X-ClientProxiedBy: YQBPR0101CA0088.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::21) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CH1PR12MB9718:EE_ X-MS-Office365-Filtering-Correlation-Id: 557adab8-5f69-431e-6abe-08defc7e2dff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|7416014|56012099006|10067099003|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: udyaQdfmipYNmYE0M+FXJtPaaCRvEWItsmcBRals6e/FH9PsWr/oRyJAi9pPxd6Y1Su20paiQr4z8LOPfeK3YPLepSsuMl8p9bEw1Wln9J9kwPZzt4945fDQnJKuYqC5ivglQICxYdUgnJD1ThYwcPSNKaXVw67ngcbPJHOq47t5vHttdcMK7CR3esMpKHU6cd/9Go6f4+aCQzBMz3zhy2RuuAMOL061fzxyBLkRjHCUN3sTxeO88aCldeI5gQ8VjjRhpvW8eMEc7aj9fd6SaHCMw1mXjRw9DuxIWuwb565wDdAwo2jWLHemqwxy45ec/D7V+LG3oMzxBB9Yyuf/7yBmsXEy3lrlm8GxbHtAn+/IAlvMukZkMIkgmd48o8+IRqkiD3FJouvX96a6X8H0YrhZfQtKc/1CAGivg3UJZ66T2oc3bApVRwWf+LLnkeBqkUDqbXdpY4o0DXKuPzlsCT4zSWfD7PVYxEOz05/smRp3e6Ot/4Uzxfn3WfkNrYoeXsBQmeJ5ezJbWWDPyCbRFG3882FY1NHrNqJeFeMLi17ICFKw9Zyze4XqAgt4WWaKyl6MRyO9ctDZhVi+jTz5fpcQHAsb8At3XVjatHCfpPpitiq2+66scX/BRjzdjpHSFezWfLLLVj1je+4b2HJI4kIYvc4cKa2v1Dqpt9JzBzI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(7416014)(56012099006)(10067099003)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1NTRHU5NTlsV3JaZlpLUytPZWc4ZEJsSnFmUWhEMGVQM3dyclc2UVJMYXFY?= =?utf-8?B?OHRqQWJtbjk3THBFY01vVHRMTm51WjdZVGZwQWYwamd0SzFzN05UUUludm9m?= =?utf-8?B?dGtYWlRMMU9wTHhZUUZYU3h2eGtabmppQ2xkZkhqaXJuUHZhOEpDZ3JiSzFn?= =?utf-8?B?NUVxYWxkRysxZncwY2RUbE1ibTNxTEVMeHZnNGp6dUlZMlplRHNrcXpPWHgr?= =?utf-8?B?SXdodHdCTko2YnhYQS93OFJrU042Wis0aXhzT0hZSGp4MTRZSmxyMDRBazFa?= =?utf-8?B?U3luNHNob3c2UTI4V1l1MEcyZTRzWVpqdnFMTi9paGVWOE0xVmFvQXpwaGVm?= =?utf-8?B?aVptdDF0M2c3T2tCUHhPc1hWdVF6MHBlWTgwNERTUU4xbGdzSVR1V2pBMXBT?= =?utf-8?B?cXcrNVd4VUVPYnhaOWg0d1EyNFRueXVEY2FSOGFmaGlEZmFxQ1N1NXFOaitm?= =?utf-8?B?blBHdWlqbHZJR1IzeGFLTHVMdGwzaU9hb0dLWDJwVTJWOG9taUpVZDRoQ3lq?= =?utf-8?B?QTdCUzFRMUNHQ3ZZMWJqWDc0SDZNdjRvbnExamQ1UVBDdzc3M1FtUzB1SCtG?= =?utf-8?B?aU9YdExxdE9MM3VNNUUrMk9DN014REQ1OHBmLzIzVGtLakliQ3cwU2RGZjVS?= =?utf-8?B?NE1pUWNSMEJ0ck80ZXozV2RRdDBaYnRNT1JRMUJrc2pxVEl5VS83VG45RC9Y?= =?utf-8?B?dmFJU01VRFFNbUUrZWxONnF4RnJvQmsrV3g5aDIycUVERllmZXZ6ZE1wY1hU?= =?utf-8?B?bnNFVHNzODFtczJVWHB1RnF1endESlRDL0hIcXNqSXpyYTllMnZGaFVJTHZ1?= =?utf-8?B?dVV2RFZGM1NHNjBOaTBodVoxcDJNaGtGbndRcHcxd1pCQ2pQcW80SXN5bDNG?= =?utf-8?B?bWRRY1V4MHB1cVI3bTRQT2dHSlJrdkViREZTMldUZitPT3pBNVdNQkF5M2h2?= =?utf-8?B?MEdjcWlrTndqNXhKM3pmU0IzRlJIRzRrZDNzM09UMnZGQlFUaVZ5L0IxbmQw?= =?utf-8?B?VHVRRmplZ1JLaGQ2WFhYTEtCcGhMZUhiZWp0VVFPZGVxcGhFM2p4dFJleU1v?= =?utf-8?B?bU54TFRueUc2WXRRSDcrNUYrVlZ2VENGNlBwWlZQTS95eEU0dXdOcDE5VGFi?= =?utf-8?B?SzFrY29mOU05NlZLTWdKWWtEWUIwYitPWWhrWmdld1pKVHZ0UVE4Ri81U2NN?= =?utf-8?B?NjF0NDNXSVdhWHdVZFhkT0l1OEZsOGYvZjhnVVhKcUlRa21Sdkc3anF5d2Vx?= =?utf-8?B?TTVyK003clh4dGZBekVKU0ZoZERGMDl4bG1WaTlWSDBtNTAwajZyUTNGNzFO?= =?utf-8?B?ZDMvOHg2TnpTUkdNdlRoRnh5bGd4WGNqUFlGMXRDL0VrWUtsdGg3eko5VmFj?= =?utf-8?B?SVhIQ2hMTXRLSDNEb3o4NWFMUTNWSSttVnZQdVdEbjRrOVJ1engxWU05Nkpl?= =?utf-8?B?YjQxVk5oenFxcVVNTUU3bzIvMVh5MUFuTllnOGE2VWdCcDNqbkxJT2VGNExv?= =?utf-8?B?MzZpYTlRS3lLSSttVmFuaE5JK2wrczVkVk5SSDdGb2NxRm96TGdaZHIzeTRq?= =?utf-8?B?VFJiamtoL1Jkd3NCRitKOFlkWCtRdlhHWml5R3Z2UGtwS0NlbWovSS9SdWtN?= =?utf-8?B?ektLeUtlSVRtVlVxLytGbE54WVFyREc0S3owTjJDV3dTR3grN0V6KzRBTno5?= =?utf-8?B?UVY5OW1zSkFUQmV2akhISW1acSt1UWNyWlFxRnlWNWF1Rlc5OC96bVZpc2hI?= =?utf-8?B?K2E4TTRGbk1heFJxZXZDa24wTFNaa3NscStacnRpamlKalQ5bzRFQnVBUXM1?= =?utf-8?B?MVVkVjZickpRdklnWkkvQnFjMWdaMXVqUFkyK21WMXRaU2JwNWJhbmtQNHNP?= =?utf-8?B?MGh1NnhSRGljb1plL091VzBIc25pQTV6aTFQWHVsbzBzdytabytyNzM5dnRG?= =?utf-8?B?MWxFcTJ2aUVEMWNiVEdaVlhsNldERTF2VTBtbVdOVWYzOHZXbjh3NnZ6dmdF?= =?utf-8?B?TGpYWUNJWkJyenFUVWxhLzlDNy94WlhjSS8zUmFaN01oT2tKWWYxUDhyQjU3?= =?utf-8?B?a1dpTFJuVGg1L01Rd01uWkd5YXRZNjEyOCttZHp1WitMalU0dVF3Vkk5RjNq?= =?utf-8?B?cGx1aVdvRi9vbHgvcDQ0YnQ0elUxUEU5SFJ0K2MyTHRUdjIydThOamVpVlQ4?= =?utf-8?B?VHhPOER2VGU1RExuVjUyQTFTQ0xXTlVITlBsWGpwS2hVK2E5M2QyQk1Ea2JQ?= =?utf-8?B?VURUcEEyemdBNGdHckpja3Zhd1d6N2VHOFhZOThnVXhGcFhWenN3amFZUFlW?= =?utf-8?Q?et1QABbWoVWF1n2Kbf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 557adab8-5f69-431e-6abe-08defc7e2dff X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2026 16:40:00.2081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gy5rVcMhc1JejjwR70cSf8Xq14h08jYqctCNnGj+BcZlHN/ejBa6sJIup2awHUDu X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9718 On Mon Aug 17, 2026 at 2:08 AM EDT, Hui Su wrote: > migrate_vma_insert_huge_pmd_page() calls flush_cache_page() before > replacing an existing huge zero PMD. However, the third argument to > flush_cache_page() is a PFN, while addr + HPAGE_PMD_SIZE is an end > virtual address. > > More importantly, the mapping being invalidated is PMD-sized rather > than PAGE_SIZE-sized. Flush the whole PMD range with > flush_cache_range(), matching other huge PMD invalidation paths. > > Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone = device pages") > Signed-off-by: Hui Su > --- > mm/migrate_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thank you for fixing it. Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi