From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739163BE16E for ; Mon, 17 Aug 2026 21:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787003515; cv=none; b=K1CghsBtMT4q1ME5x9dHReEKBm9J97pfeUpYXTC+cHl2P1jLVk2IfEj/PUHdEHRMHfpjLAr2v53uHG1eli3bmrraQ92iaVuHEM3ZiIvZKp3tZeQ8kU0FtiGLprFwVH42HzTUUIn6FEBZ5nIywKKvAZ9/25nUzG6MagdxvGr9mHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787003515; c=relaxed/simple; bh=xJUnUoMS0efqPdEWh6VyFBSW/fIK2d8cOEcdE1MOroo=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=Cnl1X9F1kKGqCZxsgh2fcokrTmv27HbgSvhmrKbw2IInaRomO835GhVm2Hiu2lw4URRxJi+GPJaHUCNO9GUBViQDNrNfjm6jf7U8wltPNcu+8C9bDaTMtIgdV7OCtVXK96FlKrlhG5Ha4T4k+tQmntQZ01lfjWlL+/1unxadVQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WbSDnMZS; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbSDnMZS" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso1815954f8f.0 for ; Mon, 17 Aug 2026 14:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787003511; x=1787608311; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xJUnUoMS0efqPdEWh6VyFBSW/fIK2d8cOEcdE1MOroo=; b=WbSDnMZSky9cLeBu8dcHfx4VZ/2z6prlUwVz9VcVvZjsBX0LKxCCX5zigxAaaN1XMU IKaoMTbTJh4NrRtz343X6HYGpAwP1u4qx2WxqESBZ1sjFP7vhl8vQ0r6XHQSoFCZY5hb cKxENCMAy1xe/0wF6Nxf7jxPU19Bgo2sOUTXDbOPjRZXJqTpV5650wH56BEaZ2bGd/Ci RmrASZsr4rBQQlMc23LPmjsSdN6mQnbw03bCIJaKt7NmD1GPeuznoLXsxSNngeCLbFT6 PLF0i5ENACrHUiKbV7vTBOg6DgHQ9dTWmL9DSQ45pOG30TOgIefcXqhiNt2MR//WpYe3 h6+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787003511; x=1787608311; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xJUnUoMS0efqPdEWh6VyFBSW/fIK2d8cOEcdE1MOroo=; b=WzPrSDy6+UxZ0E5dB7AjLNsCxUpq4Fnk6ubge3DjtaoD+jfdfIM/BKuWTQNYMku6sG VptMRV5zOA8uYrQQWqn4/YC4niiMx5uw4ZJQ5Xodv1Ko1wjO4XVPfWCuxoAqShk7YZj7 60xt7Eh7Zd3CE9iu+997GKGchuWn4eb/fwdkbHqVI+sFpOqpfPtYvOI6wRSmcR9znFMZ 8KLnPeYF0Qgv6LQ78EnoOICEfE8BExmlJtRp8weXM84wraYeDZ91CdoUpKFZPLJWa/Fw CqdORCWessRCEp1Mb05csxELiasjdnIjtBqmcwZT7zbzzMZKei1/QNpZRbg1eFHdm5pN pI6Q== X-Forwarded-Encrypted: i=1; AHgh+RpCy0yMZmjtCgBLHtFPGGm/I5CsJkIw7zGdXWltiXMHUT6cCkiTMfEkrZ6+gra27osPx09zf1+dmPpqhe4=@vger.kernel.org X-Gm-Message-State: AOJu0YxatfZWPbx+Qg/sPHjBACWEPGxtZMa9CywtMf8brZbYe4xnrf+F C3TKKik9b49LMOTz9OI/ad9v4S4fEQ/XYrKa9D+uSUGehsTT527lZpcI X-Gm-Gg: AR+sD12Vx4r/7FMI964M7kM63u3ZMFZlRimKdstYCXcWj8IxQWd6Uy25o+1zC9LOrly m4j6lC6cg/w/Rfckx/XVjMQdV6vi3/RgaML9uicnY7gYS0/GnLhV/dPUHqZeabWymnqAuAlyisN UL/M/2K6wZ6jy5TaCrkiwb0HxsIBclGsx2Jn50FfZt/+zx0S20oC7A4urCoIe0+F9WyIDgXAmCd ttbH5SI5JhmuymYznyG251wc3lDsm8UIZOQTX8zfSBkc9xoA6GYEkgw8WrHswRH5HHtVLeRXQFr VFBMkQNg/c8A8aOELU+Jrpd7aoMeA0kNMz4nYc8XeEApDq6oOCAkNl8fOpl/9u5owuSho+AcoMF JoS/U/+YzEwdcAqcXvD+EIO7R98gLxdOcIXCOdvoTCtYXiGuT7L/z7GRXrFjRUFLEGrZU5/MPSW 9cvZ+Iiy3/Gb6fVM77jVT6MHVlBXQuNSvd4sdIVdEwlVZ8vVTWXYr4XIs0r1RsSLw9blypmySZu Wt4xDz+T7QlJIuHZf6fIuz6w5oiu+/uX1eYANrOiZcIi5tb1QNTnGA= X-Received: by 2002:a05:6000:4201:b0:47f:e760:e5b9 with SMTP id ffacd0b85a97d-482a903c1c1mr4995812f8f.18.1787003511415; Mon, 17 Aug 2026 14:51:51 -0700 (PDT) Received: from localhost (178.43.142.119.ipv4.supernova.orange.pl. [178.43.142.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b51asm6988840f8f.11.2026.08.17.14.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 14:51:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Aug 2026 23:40:26 +0200 Message-Id: Subject: Re: [PATCH v15 18/22] media: i2c: maxim-serdes: add MAX9296A driver From: "Artur Andrzejczak" To: "Dumitru Ceclan" , "Tomi Valkeinen" , "Mauro Carvalho Chehab" , "Sakari Ailus" , "Laurent Pinchart" , "Julien Massot" , "Rob Herring" , =?utf-8?q?Niklas_S=C3=B6derlund?= , "Greg Kroah-Hartman" Cc: , , , , , , =?utf-8?q?Niklas_S=C3=B6derlund?= , "Martin Hecht" , "Andrian Suciu" , "Cosmin Tanislav" X-Mailer: aerc 0.21.0 References: <20260807-gmsl2-3_serdes-v15-0-7212e9e5156a@analog.com> <20260807-gmsl2-3_serdes-v15-18-7212e9e5156a@analog.com> In-Reply-To: <20260807-gmsl2-3_serdes-v15-18-7212e9e5156a@analog.com> On Fri Aug 7, 2026 at 3:02 PM CEST, Dumitru Ceclan wrote: > [...] max9296a_set_tpg_clk() writes MAX9296A_VPRBS(0). The comment states TPG data always lands on pipe 0, but don't pipe_hw_ids start at 1 on MAX96714/96714F/96716A/96792A, with hw pipe 0 never mapped? max9626a_log_pipe_status() already reads VPRBS through max9296a_pipe_id(). Should this write use the accessor too? Also, is the "max9626a" in that function name a typo? The file header and MODULE_DESCRIPTION say "Quad GMSL2 Deserializer", but isn't this a dual-link chip? As in patch 17: could the 200 ms sleep in max9296a_select_links() poll link lock status instead? max9296a_init_phy() enables D-PHY deskew when dpll_freq > 1.5 GHz without checking for C-PHY (max96724.c gates this on !is_cphy). This might affect MAX96716A/96792A. Kind Regards, Artur Andrzejczak