From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C6447D46E for ; Tue, 18 Aug 2026 16:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787069462; cv=none; b=LdfMLg0zkV8hdcdHJM4b/7HSn/qnzkZn7+PhSg5pwkde1tauRwNydbsfN7qaFArLkSQqnorR2Y7bXB8Tfk+ccsjYxyuLyG0qRB04J3ynl7ZINQx2KZ/NTjsoV5geINtckOpTZIe0Yc1+hy75pj3WYwu6LFkCC3NTExb8IXvO4RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787069462; c=relaxed/simple; bh=c7PwQWkFv8QtOYPTSaqekUb0jNSO2JmAouy9pX/I/QA=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=b2r3qhMdTIX8/4yrACzcmfPwuFe6RkJQn5DFiFrKBFtIZbD1uAgBSzLQY5JMZlaZsR0cJ7fPG9MkK3JD/ClP6z1E2NHcn+oeFOI2JM29wdF78sxDxMHyUxFhuhmUuJaCuWiSj2CoypnubZhN5QUwIiL+HtE5l0zpB9IwXMvpeB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NRFIGYPV; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NRFIGYPV" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c2074710751so768427766b.1 for ; Tue, 18 Aug 2026 09:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787069454; x=1787674254; darn=vger.kernel.org; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=nvxB0TwdTME8MC6Z1iZNTwpBhONAfbWSssxaqP+j/pw=; b=NRFIGYPVka858bu0JECWLXkbS08vJ+HDFGMwIqngB22IAIOhtsDnv4CFPGml8JWIvU ErlDfiMn8dqiLj2+qYC1f1z/RQjX1aCtmOwUMP0DPVqjBqv6OGaOIGNcc4EzauYOKKgj rtOtkvXTcuYp7KQHoPM1FDZm0ECUGjEK9XLGTKK9TEZyI16ykUGA1biF5o1QIzNE151W lC/nTSd+VXlpRkdIIQnEOk7FfrdE3jOpYhyHiYrQ4voeD3AZPPZGCBgu+lHFZoQud/c6 HZuuuV7695LwEyBy3bbFdrIvZqUhgYvsw2ZBw62xWdnGu6FSTG65XTw6xzSz10mBkXX+ NQWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787069454; x=1787674254; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nvxB0TwdTME8MC6Z1iZNTwpBhONAfbWSssxaqP+j/pw=; b=P571nRHLfRZNYGNu8JmVp0m1Rk+Ix3GOF2CqtkjefNNN8GlPW/xNK0QKaORwCLb1vP aa/WYXbVIlLAbXtJSDnvD0hoi3yW6Ncq1lluQizFjE5n1p3fSi4xLWhRkYuC7SvFdKB0 XkNt0Gtz6uLus+MT76bFT3pEnQ4pYcXG1F2zewtTS9VEY1qquQr4FKWKYMv5LYMUo0PP CDnaG0pr3Ur8NwXShPfSvOHAsNVd8U77eU4bCqSf1IjeK5INdtGDmbNAV7bYLjXXpud4 hzl52WoH9iynLB7oUb5QVjtvTI7gBRmtdsWCqP+TDiZRjySRQ0QH8plmnc1Pk04UzxNu Eq4g== X-Forwarded-Encrypted: i=1; AHgh+RrKPxwPSrbDzDX1r2SqoufSPB1ZE9XeztuW/6Ro0BuFy0qBttoUhcvkoV/Fpyyc0yCjYO/3pmlBj82QuHU=@vger.kernel.org X-Gm-Message-State: AOJu0YxTiCWUOQWMgeN3W332PHkv7Z+umtWfwSP7pI3WL3YeZm4/HKRF C0QtZrmV203YAO5B/xfaOlsFW1OG3qdLl68CGj5n4aO1bSBf15WUhjiY X-Gm-Gg: AR+sD11j9mvGIMpnhEamgP4MhVo9wmqE4Vwzt4ySOdfz5u0ow+jz3enb5O1vRwrt4VX yjwlTfhdQkzSWnJjchP1pqc2OEoVHD6FTSCm++7Y7Fia373uVbJyekPIq3ewB4hlKNfE7Z7WDh7 ftk/Tu/50nxhLHdJ1nJoSHA3pigulvb8MLRdPDrXn6b8M06uFWSG6OlsNGPSSHQRxtjMP3sYJnV mAzmv6pVfosypUh8zEBXE8XLYVjRTqfiEEE6EAgHuKn3u0iiCf1NEOlS3kcvOxEjr3NpYT4C8ww 8wAEvJyRzGcx+OAugQlL9m9IvyqiRyHBQ9siCEYiQJ9Fvm6FuBehs4WwmSTlldGscj6tLg/WTpz ncJY5b0IXFKtQIQOUgermCtMdYgNjzCeHu5SiVWN377ux1tWKeaRe8UyKHl0Ylha36r79GNo+oE 9DsDc3+0oyzytYMZygsftL48u71VxxqOxPDoYIC9MrQxNqc4MIPT0GOi1RMKM3ucNmYB1gkQkvD Eo= X-Received: by 2002:a17:907:928c:b0:bf0:b39:dcc8 with SMTP id a640c23a62f3a-c212a1da2bamr1897122066b.26.1787069454161; Tue, 18 Aug 2026 09:10:54 -0700 (PDT) Received: from localhost ([2001:4bb8:17a:e1ae:aa1d:6b4e:97a6:f7ad]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185b99f78sm189896466b.50.2026.08.18.09.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 09:10:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 18 Aug 2026 18:10:51 +0200 Message-Id: From: "Javier Carrasco" Subject: Re: [PATCH v7 4/4] iio: light: veml6031x00: add support for events and trigger Cc: "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , To: "Andy Shevchenko" , "Javier Carrasco" X-Mailer: aerc 0.21.0-143-g2f3a2e260c09 References: <20260818-veml6031x00-v7-0-2b0de0f20edf@gmail.com> <20260818-veml6031x00-v7-4-2b0de0f20edf@gmail.com> In-Reply-To: Hi Andy, thank you for your review. Even if no more stuff comes, I would like to update the code in v8 with your suggestions before applying it if nothing speaks against it. A couple of comments to the feedback I'd like to discuss. On Tue Aug 18, 2026 at 4:01 PM CEST, Andy Shevchenko wrote: ... >> +static irqreturn_t veml6031x00_irq(int irq, void *private) >> +{ >> + struct iio_dev *iio =3D private; >> + struct veml6031x00_data *data =3D iio_priv(iio); >> + struct device *dev =3D regmap_get_device(data->regmap); >> + s64 timestamp; >> + unsigned int regval; >> + int ret; >> + bool trigger_poll; >> + >> + ret =3D pm_runtime_get_if_active(dev); >> + if (ret <=3D 0) > > < 0 seems too much to me. If there is disabled runtime PM (and supposedly > device is always on) this prevents from getting events. > I am not sure if I get this. A reference is unconditionally acquired when events are enabled as well as in buffer_preenable, and also in the probe before interrupts are enabled. Runtime PM should be active at this point. If not, the interrupt should not come from the device, even if it was on (e.g. before autosuspend kicks in). But maybe I am missing something? > ... >> +static int veml6031x00_hw_init(struct veml6031x00_data *data) >> +{ >> + struct regmap *map =3D data->regmap; >> + struct device *dev =3D regmap_get_device(map); > >> + __le16 regval =3D 0; > > Redundant assignment. > regval is assigned here to write that value in the first instruction (regmap_bulk_write()) after the variable declaration. >> + int ret, val; > > Why is 'val' signed? > >> + ret =3D regmap_bulk_write(map, VEML6031X00_REG_WL_L, ®val, sizeof(r= egval)); Here. >> + if (ret) >> + return dev_err_probe(dev, ret, "Failed to set low threshold\n"); >> + >> + regval =3D cpu_to_le16(U16_MAX); >> + ret =3D regmap_bulk_write(map, VEML6031X00_REG_WH_L, ®val, sizeof(r= egval)); >> + if (ret) >> + return dev_err_probe(dev, ret, "Failed to set high threshold\n"); >> + >> + ret =3D regmap_field_write(data->rf.int_en, 0); >> + if (ret) >> + return ret; >> + >> + ret =3D regmap_read(map, VEML6031X00_REG_INT, &val); >> + if (ret) >> + return dev_err_probe(dev, ret, "Failed to clear interrupts\n"); >> + >> + return 0; >> +} Best regards, Javier