From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3ED53ED0A for ; Mon, 31 Aug 2026 15:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788189988; cv=none; b=I/3C3waeUDQz/xlgvFy3O+ZHvJ8SWkZnUCjUfVZ/nNPOLXHpiTVjt/dYNXBMkYP5cRPQnqk49Z2hztmPSesVk/YcQC9nOUdqhfPJzC2AYAUstaL9V/a+t22bFtIS3eIUcSC8d0WH/57kAZ37BIlXA/YswVumIXRD4rf8Ang9a1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788189988; c=relaxed/simple; bh=MOSEqx16yAn5Bafqgfej14UnvGnZ0sZeAYdUubBwfXw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=sWnwAujrPeGISC48YYU2um4IMujFwXAgxLv9Q0xkPGiQ+zRAm/eDgo6uHpGB1nWOFOrz2ObjWzGCrSHln0yEcgnkEZNVUf0LMmMckC0J6tLqP9OScqe7zg74DuvvXHmEUpmK96OTsYwU2dlwnIxtchs/ktx93FlP7jumzlUNszo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Q2MLXKc/; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Q2MLXKc/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id B01B04E4146B; Mon, 31 Aug 2026 15:26:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 78D0260231; Mon, 31 Aug 2026 15:26:23 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9386C11C78AC8; Mon, 31 Aug 2026 17:26:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788189981; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=MOSEqx16yAn5Bafqgfej14UnvGnZ0sZeAYdUubBwfXw=; b=Q2MLXKc/oRyrOrt5bUK/hzX58z7rF6JIiqY6ZUOPOSQIGKtaI5fg9Oeb1RV0NWqutDvaPv gOJ/0FOFFdpkdIwaF/Cvr45Mys4ZncMbplmBKHbMWqg9ZLspZSv8Ep00y2lumGKCRs4v2H 6gQdw4/h+YXmx870Cy71EBf+ALZLLpxbk4uMOFlsizSLUt+shIDdx1iVxZi8WokNXjmlMZ G2hBOrntCutZ5ipOcFTONtGS0Tt6ujgIiHJf+jpm5CS7Zm1c7iHAuTxUtyIhKj4cmQW98y EYJDqIQaptAlVZQypV6Iqv5HNYDXKEDHTFaQ7QQ1NGkRvKNt+nqg4xnkotsgig== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Aug 2026 17:26:12 +0200 Message-Id: Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , , "Jitao Shi" , "CK Hu" , "Pin-yen Lin" , "Enric Balletbo i Serra" To: "Doug Anderson" , "Luca Ceresoli" From: "Luca Ceresoli" Subject: Re: [PATCH v2 08/12] drm/bridge: parade-ps8640: select DRM_PANEL_BRIDGE X-Mailer: aerc 0.22.0 References: <20260825-drm-bridge-drm_panel-cleanup-v2-0-c6c88ba7ffd2@bootlin.com> <20260825-drm-bridge-drm_panel-cleanup-v2-8-c6c88ba7ffd2@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Mon Aug 31, 2026 at 4:58 PM CEST, Doug Anderson wrote: > Hi, > > On Mon, Aug 31, 2026 at 2:01=E2=80=AFAM Luca Ceresoli wrote: >> >> Hi, >> >> On Thu Aug 27, 2026 at 6:23 PM CEST, Doug Anderson wrote: >> > Hi, >> > >> > On Tue, Aug 25, 2026 at 3:11=E2=80=AFAM Luca Ceresoli wrote: >> >> >> >> This driver uses the drm_panel_bridge API and not the drm_panel API s= o it >> >> should select DRM_PANEL_BRIDGE and not DRM_PANEL. >> > >> > Which exact "drm_panel_bridge" API does it use? I don't see any... >> >> It calls devm_drm_of_get_bridge() [0], which is in bridge/panel.c [1], >> which is enabled by CONFIG_DRM_PANEL_BRIDGE [2]. >> >> [0] https://elixir.bootlin.com/linux/v7.2.2/source/drivers/gpu/drm/bridg= e/parade-ps8640.c#L636 >> [1] https://elixir.bootlin.com/linux/v7.2.2/source/drivers/gpu/drm/bridg= e/panel.c#L483-L515 >> [2] https://elixir.bootlin.com/linux/v7.2.2/source/drivers/gpu/drm/Makef= ile#L159 > > Ah, indeed! I missed that since it didn't have "panel" in the name. > FWIW, then I think for this patch: > > Reviewed-by: Douglas Anderson > > ...but, ironically, that means that for the other patch I looked at > (ti-sn65dsi86.c) we're missing the "select DRM_PANEL_BRIDGE" since it > uses the same API call, doesn't it? Ouch, indeed! Thanks for noticing. I will send v3 with that fixed, can I keep your R-by if there's just that change to the sn65dsi86 patch? I am also going to double check all patches for this mistake. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com