mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: "Andreas Kemnade" <andreas@kemnade.info>, <kristo@kernel.org>,
	<sboyd@kernel.org>, <bmasney+clk@redhat.com>,
	<jbrunet+clk@baylibre.com>, <kees@kernel.org>,
	<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <hns@goldelico.com>
Subject: Re: [PATCH] clk: ti: composite: resolve parent clocks by name again
Date: Sun, 06 Sep 2026 10:32:52 +0200	[thread overview]
Message-ID: <DL83EP6TA2EE.MGYAU17GO6D6@bootlin.com> (raw)
In-Reply-To: <20260904181716.631201-1-andreas@kemnade.info>

On Fri Sep 4, 2026 at 8:17 PM CEST, Andreas Kemnade wrote:
> Trying to resolve them by DT index causes massive havoc on OMAP3, Clocks
> around the timers used as a system clocksource are not properly resolved
> causing ealy boot failures. The problem seems to be that parents must be
> resolved by looking into the clocks property of the component node marked
> with "ti,composite-mux-clock", with the switch to dt index, that node
> was not used anymore. It was used by the of_clk_parent_fill() call.
> To a lesser extent also OMAP4/5 boards are affected.
>
> Since this patch was introduced just because of a cleanup request
> and not to solve the actual problem
> (https://lore.kernel.org/linux-omap/alkZmw-XmnCOZfOD@redhat.com/)
> just revert it. Cleanup needs really more thought here.
> The similar change to the TI mux clock, which solves a problem on the AM3
> platform, seems to be harmless.
>
> So just revert
> commit fe3dd92ac54a ("clk: ti: composite: resolve parent clocks by DT index, not by name")
> for now.
>
> Fixes: fe3dd92ac54a ("clk: ti: composite: resolve parent clocks by DT index, not by name")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

Hi Andreas,

Thanks for your time and testing it this way.

Reviewed-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2026-09-06  8:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 18:17 Andreas Kemnade
2026-09-06  8:32 ` Mathieu Dubois-Briand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL83EP6TA2EE.MGYAU17GO6D6@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=andreas@kemnade.info \
    --cc=bmasney+clk@redhat.com \
    --cc=hns@goldelico.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=kees@kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®