mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "Conor Dooley" <conor@kernel.org>, "Kurt Borja" <kuurtb@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 02/10] dt-bindings: iio: adc: support the TI ADS126x ADC family
Date: Sun, 06 Sep 2026 17:16:37 -0300	[thread overview]
Message-ID: <DL8IDJ54V16N.QE5U3SI9J87Y@gmail.com> (raw)
In-Reply-To: <20260828-cartel-willow-9592e4e8b912@spud>

On Fri Aug 28, 2026 at 1:39 PM -03, Conor Dooley wrote:
> On Fri, Aug 28, 2026 at 01:38:17AM -0500, Kurt Borja wrote:
>> The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an
>> integrated PGA, internal reference, excitation and burn-out current
>> sources for sensor biasing and diagnostics. The ADS1263 is compatible
>> with ADS1262, but includes a second auxiliary ADC (ADC2) to perform main
>> channel (ADC1) cross-checking measurements, system background
>> measurements, or temperature compensation of the primary sensor.
>> 
>> Both parts can configure per-channel voltage reference source,
>> excitation current sources (IDAC), plus input and IDAC chopping for
>> offset and IDAC mismatch cancellation. This lets the device drive and
>> ratiometrically measure RTDs and other resistive sensors.
>> 
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>>  .../devicetree/bindings/iio/adc/ti,ads1262.yaml    | 376 +++++++++++++++++++++
>>  MAINTAINERS                                        |   6 +
>>  2 files changed, 382 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml
>> new file mode 100644
>> index 000000000000..7e26572388e4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml
>> @@ -0,0 +1,376 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1262.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI ADS1262/ADS1263 analog to digital converter
>> +
>> +maintainers:
>> +  - Kurt Borja <kuurtb@gmail.com>
>> +
>> +description: |
>> +  The ADS1262 and ADS1263 are 38.4-kSPS, delta-sigma (ΔΣ) ADCs with an
>> +  integrated PGA, reference, and internal fault monitors. The ADS1263 integrates
>> +  an auxiliary, 24-bit, ΔΣ ADC intended for background measurements.
>> +
>> +  Datasheets:
>> +    - ADS126x: https://www.ti.com/lit/ds/symlink/ads1262.pdf
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: ti,ads1262
>> +      - items:
>> +          - const: ti,ads1263
>> +          - const: ti,ads1262
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
>> +
>> +  spi-max-frequency:
>> +    maximum: 8000000
>> +
>> +  spi-cpha: true
>> +
>> +  interrupts:
>> +    minItems: 1
>> +    maxItems: 2
>> +    description: Data ready (DRDY) interrupt lines.
>> +
>> +  interrupt-names:
>> +    description:
>> +      The data ready (DRDY) signal has two independent interrupt lines. A
>> +      dedicated DRDY pin and a pin shared with the serial interface MISO pin,
>> +      which is called DOUT/DRDY.
>> +    minItems: 1
>> +    maxItems: 2
>> +    items:
>> +      enum: [drdy, doutdrdy]
>> +
>> +  start-gpios:
>> +    description: Start conversion control.
>> +    maxItems: 1
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +  dvdd-supply:
>> +    description: Digital power supply.
>> +
>> +  avdd-supply:
>> +    description:
>> +      Analog power supply. In bipolar supply configurations, the reported
>> +      voltage should be in reference to DGND.
>> +
>> +  avss-supply:
>> +    description:
>> +      Negative analog power supply for bipolar configurations. AVSS can only be
>> +      at or below the ground reference (DGND). If not described, AVSS is assumed
>> +      to be connected to ground (0V).
>> +
>> +  clocks:
>> +    maxItems: 1
>
> clock doesn't appear mandatory, what does it do?

Its not mandatory because the chip has an internal clock too. If an
external clock is wired, the chip also has an autodetection mechanism
so we just describe it here so we can enable it.

>
>> +
>> +  '#io-channel-cells':
>> +    minimum: 1
>> +    maximum: 2
>
> What's the use case for actually setting this as a single cell? Kinda
> confused by it.

As Jonathan said this is part dependent but we can also just make it
'const: 2' and validate the second cell's value.

>
> Otherwise, quite frankly, the binding is too complicated for me! I'll
> have to leave it up to the IIO folks to cover whether what's being done
> is sane.
>
> Cheers,
> Conor.

...

-- 
Thanks,
 ~ Kurt

  parent reply	other threads:[~2026-09-06 20:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  6:38 [PATCH v4 00/10] iio: adc: Add TI ADS126X ADC family support Kurt Borja
2026-08-28  6:38 ` [PATCH v4 01/10] dt-bindings: adc: add excitation-current-chopping property Kurt Borja
2026-08-28 16:33   ` Conor Dooley
2026-08-28  6:38 ` [PATCH v4 02/10] dt-bindings: iio: adc: support the TI ADS126x ADC family Kurt Borja
2026-08-28 16:39   ` Conor Dooley
2026-08-30  1:57     ` Jonathan Cameron
2026-08-31 16:24       ` Conor Dooley
2026-09-01  3:01         ` Jonathan Cameron
2026-09-06 20:16     ` Kurt Borja [this message]
2026-08-30  1:53   ` Jonathan Cameron
2026-09-06 20:16     ` Kurt Borja
2026-08-31 19:44   ` David Lechner
2026-09-06 20:17     ` Kurt Borja
2026-08-28  6:38 ` [PATCH v4 03/10] iio: adc: add the ti-ads1262 driver Kurt Borja
2026-08-28  8:09   ` Andy Shevchenko
2026-09-06 20:15     ` Kurt Borja
2026-09-08 10:01       ` Andy Shevchenko
2026-08-31 20:22   ` David Lechner
2026-09-01  3:07     ` Jonathan Cameron
2026-09-06 20:17     ` Kurt Borja
2026-09-10  2:43       ` Jonathan Cameron
2026-09-10 21:38       ` David Lechner
2026-08-28  6:38 ` [PATCH v4 04/10] iio: adc: ti-ads1262: support per-channel sampling frequency Kurt Borja
2026-08-30  1:36   ` Jonathan Cameron
2026-09-06 20:16     ` Kurt Borja
2026-08-30  2:22   ` Jonathan Cameron
2026-09-06 20:17     ` Kurt Borja
2026-08-28  6:38 ` [PATCH v4 05/10] iio: adc: ti-ads1262: support per-channel reference and gain Kurt Borja
2026-08-28  6:38 ` [PATCH v4 06/10] iio: adc: ti-ads1262: support input chopping Kurt Borja
2026-08-28  6:38 ` [PATCH v4 07/10] iio: adc: ti-ads1262: support excitation currents Kurt Borja
2026-08-28  6:38 ` [PATCH v4 08/10] iio: adc: ti-ads1262: support triggered buffer sampling Kurt Borja
2026-08-28  6:38 ` [PATCH v4 09/10] iio: adc: ti-ads1262: support REFOUT and VBIAS regulators Kurt Borja
2026-08-28  6:38 ` [PATCH v4 10/10] iio: adc: ti-ads1262: support common mode supplies Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL8IDJ54V16N.QE5U3SI9J87Y@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®