From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 003BF443AA7; Mon, 7 Sep 2026 08:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769810; cv=none; b=NRXAmYPQj5csjxgUWVE3eM10rw6zK+vPHiqlcNMC3ZS5ckD4Y1Dk+2b9s22wOXYl2zkZUsvB1HHA029iFT5v28Wk34wzILqNiNZ9/KIe+ZUl9mbOnSjyDx5q9PociBAnbgSNEAqMuHDHzT7pwi9Jm+F9y03jOEReG88wX+YYE7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769810; c=relaxed/simple; bh=QAEt6P9ewAx4tLQ7zDcVEugSrb2nPpwxpUVMi3n1/+A=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=i/+h+FvD4mo6vOcTy7sKhGQnjg29/ycpqjWU5UFYCN5YM4smem/n1JkgLq8lW4roHrFCqdto5oJad/2zwYPXokBZwB9GCjn7NgWJOxMkiaI1Ec7rbNj6f9NYxVJcBOfYISRxg/L4THRjyrz2kRnu183C+xq7p0/FjVf9vLUMBlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=oBR+IBXz; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="oBR+IBXz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1788769753; bh=qWRgI9AOsx/PXxW+VxjVPzW5Qmp+SlNGLn4ruFkG9nE=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=oBR+IBXzLjBaJocWvo/zFzPA1ALw0ELmD/h6uUfAsTjuFLZwd/lKN0MUcbn7x9Cwm BvOd189qqOcCUHnyyXnYr1Dds5pWLW6/HtcJs1+bPK99cpJfVE36/CuzXBhlUcZwkk Y2Nt4nJ/A8V+vqhCgsEL/tu3B1MBo3UQKZiLGHn0= X-QQ-mid: zesmtpsz8t1788769746t20a8a9a2 X-QQ-Originating-IP: wIBhlM3drIQ9Ntyumd1ujaGUl+998+uevieIExULl4I= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 07 Sep 2026 16:29:03 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 11320355853612536940 EX-QQ-RecipientCnt: 20 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=c5ea966f1287d2fb0a065fbd8bfacc535291a111e20b04421be1800d226c; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Mon, 07 Sep 2026 16:29:01 +0800 Message-Id: Subject: Re: [PATCH 2/6] usb: chipidea: usb2: add optional reset support From: "Troy Mitchell" To: "Junzhong Pan" , "Peter Chen" Cc: "Greg Kroah-Hartman" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Yixun Lan" , "Xu Yang" , "Peng Fan" , "Philipp Zabel" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , , , , , , "Troy Mitchell" Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260812-b4-spacemit-k1-usb2-v1-0-f28cf29e522b@linux.spacemit.com> <20260812-b4-spacemit-k1-usb2-v1-2-f28cf29e522b@linux.spacemit.com> <870CB1C672C91040+8a75565f-344c-4f1e-aa69-33585a88c8e5@linux.spacemit.com> In-Reply-To: <870CB1C672C91040+8a75565f-344c-4f1e-aa69-33585a88c8e5@linux.spacemit.com> X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: Ni68Q0J6fxe2wIqzzpnjqZqcDXBL641bOrXTVUP6GxzUtXHWeJH1XJNw 8uKsDXFi4zyR4vFBMulVXHap12RAkqtvyG9DxflBI6RyYUFvGBl7SFTw7/75yvJ9hRmCvJA WZx3zpUR3Dn+sQ0u44hOGt++j4pETwG/FrDRa6y2ESbwySpFmzfsYF4eMV12PS1YrrQ+L49 B3Jts8fd10gD1EfFazIDSc9sX356lJtVrUchFNYU6JvbPSUzqbSHIiEStuKhHTsvT9N2bKY XMrnvaPar5DasCTpjLNQEGYAFGbI+qIKyoFw+bZdHCsXzYUQ3Ww8+MiwGm4rUUADFGlq9u4 +BsqwdCcup3GHypTe/xA6JbwzIpTlg6bZ9AP/sYRVn7akIXmOZg+i0xEu2eL2D53u5YmFip v4Tcdg1zQedCwqg5nwWBvb1P9DV2i5/PH+gZumEY6HSIh1Jw6yU3GRHMKsdTvpc2jI7anKQ Ss4v0I+jKIXE3ZGa5yruqkZUVfNgfPNHRRBw7+/ssnqL1X5LFSwFsZye2Vhx0VsDEHADvKR TBgkfE+z69IJOtGxRC70kVCKDFbmK27FbuwuCF1uzqEkYg5VFP8lJUVRyWaVxSUC7ZBzpqd in+ZQU4Qe8k95hZvcPKa1kozSvUllU4G2GU/Imz6ndTGL+2QCxnCfbuqsg5IlK6mPBb7GJG YcB4IhV3wtqhzbXmUToTmwAC9kkLp3DL/wT8RBefcIkThHQnlq/dBm3z5EoaxtLH3rmJvlo zUtLNqvqlb9SBFsfBhvd1P0Dz9Flu8LIuBXxuswhkp1zb9NY56bW+I7jD/+8gt/VMtPjNUb z0vKiqyoMCfDAgPhBzuVIu6F2mhZwcF3zvxj84tQ0nZVtXGjZPVnzJnOX/LSkWPSvqs663/ 9wf6bezEFVcJgsXtRIZ4tLu+Y2rGA/W9lq9zKuHYlnh2KVEv+BnkSzI4CMDqEtuhtZ2e707 KimJJxbiVLWCiQkl4eouU7flPQ5bHJ1j3v3bXZoZDLzwM/k8lyqYjICSvmhBCyu0goadn9p gll/OuXn0/NC6Ocf8X78ReUuOuw+IMp81rppD13HmlhP5cZ3KcIiypggtBor3hUYV892mzY A== X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== X-QQ-RECHKSPAM: 0 --c5ea966f1287d2fb0a065fbd8bfacc535291a111e20b04421be1800d226c Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Aug 13, 2026 at 9:39 PM +08, Junzhong Pan wrote: > On 8/13/2026 5:55 PM, Peter Chen wrote: >> On 26-08-12 17:26:13, Junzhong Pan wrote: >>> The USB2 controller of SpacemiT K1 SoC requires reset support, to keep >>> compatibility, add optional reset support. >>> >>> Signed-off-by: Junzhong Pan >>> --- >>> drivers/usb/chipidea/ci_hdrc_usb2.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea= /ci_hdrc_usb2.c >>> index 8ffa1e95d8e8..00d575cd2955 100644 >>> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c >>> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c >>> @@ -12,6 +12,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -21,6 +22,7 @@ >>> struct ci_hdrc_usb2_priv { >>> struct platform_device *ci_pdev; >>> struct clk *clk; >>> + struct reset_control *reset; >>> }; >>> =20 >>> static const struct ci_hdrc_platform_data ci_default_pdata =3D { >>> @@ -80,6 +82,12 @@ static int ci_hdrc_usb2_probe(struct platform_device= *pdev) >>> return ret; >>> } >>> =20 >>> + priv->reset =3D devm_reset_control_get_optional_exclusive_deasserted(= dev, NULL); >>> + if (IS_ERR(priv->reset)) { >>> + ret =3D PTR_ERR(priv->reset); >>> + goto clk_err; >>> + } >>> + >>=20 >> You may update binding doc? >>=20 > > Sure, I forgot it, will do in v2. > > Thanks. Is the reset required for K1? If not, no binding change is needed. I checke= d the binding, and it already defines resets as an optional property. Reviewed-by: Troy Mitchell --=20 Troy Mitchell --c5ea966f1287d2fb0a065fbd8bfacc535291a111e20b04421be1800d226c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEABYKACsWIQSL4Ay2cExaPXAQcU2YCe+A+TM0LwUCap51zQ0caUB0cm95LXku b3JnAAoJEJgJ74D5MzQv9j0A/AuCeVJ9yE/gt/KfEJxLTBV6zSXK8wkfge0WTxJC wNLzAP9N5s2ZVrfHOn5l/94Qv1u5kJxbdnjE6iR9SbxpQB0UBg== =lw1Q -----END PGP SIGNATURE----- --c5ea966f1287d2fb0a065fbd8bfacc535291a111e20b04421be1800d226c--