From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CBA47798E for ; Tue, 8 Sep 2026 23:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788910283; cv=none; b=e5RHtRNT5QoHsPkKQF8YciDACTVgz5pOebhsRFKesopeBOT3kBB0SUM31xsWyWQIkx/C4cR8zTyayFInK3usW0cGX7ovVkoeyBOLd6nGKWlmhADpgqpQIji2lW7GoJ3148DX+CN1GBD0cWoWncGc8x0HsTtWROUjtfI51HMYamM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788910283; c=relaxed/simple; bh=lgK52YWEbmOHlLC5XhevTS6kX/pGRh0yPlV7xZbQ1f0=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=QKpHnrb499/N0duvxrCEfgr7U8qrOIZQ/qSSADdXtVsk+vXH/KubJL63mmfL3nVpj9TsNg/H9Ez2VfukxSbAt/gezlvp4cDxuJo4Wd6ZP2V++irTfHDRkt4sf0RHlQX5uK7r9+4SlHSLbdHPZ+We/97BcxnW31HJ06yUV3mh2go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8i4RLV1; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8i4RLV1" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-9103f5b813aso42301256d6.3 for ; Tue, 08 Sep 2026 16:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788910281; x=1789515081; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Yq7lXkoWC5jfEWJMNBS6tBwhDj/bbJjyiLJq/Z7eNiQ=; b=a8i4RLV1pifuM++BymVVYhMaH0AdhH/xLDGup7aZ6IlEPRIwxlfnQpkUQ56dZBmVbS txpSL4mTMqPsJKXmxi3PYxf+Ua1IlW9pXqvM/VAyNVtEAZj/Qp3iXAt1ZOtGbjGFQ1oA 2uXFcotFa9pnuMQOAI9juTQas/wV39y67P7IPsca+LSgnRKP9ZiQCbOscBdZVOALKhrP dbZuB78tfy00nzLF0nmd6ZvNs+FRX4I47RTeLNooVg2349Eum25A2+WVACsbjPxq54mu kmhTj4QlgFlEEivseQTrU8tLSs8WKZE1ykn+BFw8siruaFVjHO/DNn4GOW16abW1SbHi OmBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788910281; x=1789515081; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yq7lXkoWC5jfEWJMNBS6tBwhDj/bbJjyiLJq/Z7eNiQ=; b=UmEW1aoz4AVvYwTJP9SFXEZLQSBAs7GtxhxiUFsPGsHYvEcY0EV1wrk3PcKLr4zIHq ySF6wtbhdaTZTpTs8DIls7KUtRk/DQFTAO8ufZK7APceguL+MFSqs6JFWnJZLBvTMUlJ 5MZluQ4kBywf5N3yb65tvGO4z9y3LD4y/JgvwvHF5/RHj57CXfgVlTCAgyl6xUMzZtVf STDxlNSqUtIYGuGkukNALaemTaIsx8ioVmtUXdxwFiPUDqd89nMNKTA1S3MI+npaIIN5 4O2y0FWNrMgM6Ig8FTaEmmTR7C3PpA8HseIzLJGtWnWzn1PFul88MiAbkyloCFkVDXvm Soyg== X-Forwarded-Encrypted: i=1; AKwUvBz+kFquqtE8u5VzT3UtX+WTPBFXtBMaVDFmaIFwZ7jdlIqK8NVzuWXcky4K6fl9UpC5fTy/R81+wYUk2dM=@vger.kernel.org X-Gm-Message-State: AFuF++ksB52ASfL8tJkZ08T3qaAtkAzkjSlOdg7KvRRox1aL23pYZFKi sloldViSucqsLjd0uUPDBpyE+EubhmyjJ7iC5Hql5Itq3ZpRAH0ePROI X-Gm-Gg: AYBFou3/91XGu2CRMdcNyccR7qNz/k/bINhgYllyVueDCqWAuyBAskGJy55y6mOaD1u 8ZiTkWs562dBrUqvaMFIkweJWqyTbO3ljTvcRMxpyjAhnJLk9T8cR8d6r1Vi2QgZd5B85qDtExw YSeO4kOfc9WqUrqpjMficZtocxKjnGIKrSodT0Je6xOWvECUsciyerc9K/ELeCr77IpH+Pqo6gj oZQxcjgM1MG1eG6OI9jDKlATAkghhdyI0tO/SlDDV4egjbR+Ey3vRCAxKVSt9HtyScFzXaSKeBB t87Bvf47hEUd1Vjk6v43AD4zTz0lCwlKnwHxfVT1yZ00XvxZQjGB4hOV5wfijvRH1ZoKJpBqmLN I6PcQxyEkh1f+L/lvWb90qZqYUF0GGWMl0oQA1GBF7srvtBN29X3P93A+iO6ORQW3mWSFRjskQg aiBaFT/sLDy/imeiNufLoLxuBIHJNvd3UguVFT868wJ0rixyPWpgkmmiDdMtyCmRo0Mg== X-Received: by 2002:ad4:5ce2:0:b0:908:958f:4db with SMTP id 6a1803df08f44-9103eefd24fmr369191086d6.3.1788910276570; Tue, 08 Sep 2026 16:31:16 -0700 (PDT) Received: from localhost ([2600:4040:9399:4000:e553:72e5:7d37:c7ef]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91040694c35sm129077696d6.36.2026.09.08.16.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 16:31:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 08 Sep 2026 19:31:14 -0400 Message-Id: Cc: "Bobby Eshleman" , "Boris Pismenny" , "Carolina Jubran" , "Cosmin Ratiu" , "Daniel Zahka" , "Doruk Tan Ozturk" , "Dragos Tatulea" , "Gal Pressman" , "Jianbo Liu" , "Kees Cook" , "Leon Romanovsky" , "open list" , , , "Mark Bloch" , "Petr Machata" , "Raed Salem" , "Rahul Rameshbabu" , "Saeed Mahameed" , "Shuah Khan" , "Shuah Khan" , "Simon Horman" , "Willem de Bruijn" , "Willem de Bruijn" Subject: Re: [PATCH net-next V4 09/14] net/mlx5e: psp: Add an rx_decap steering table From: "Daniel Zahka" To: "Tariq Toukan" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , , "Paolo Abeni" , "Sabrina Dubroca" X-Mailer: aerc 0.21.0-threadmapfix References: <20260908065244.3799142-1-tariqt@nvidia.com> <20260908065244.3799142-10-tariqt@nvidia.com> In-Reply-To: <20260908065244.3799142-10-tariqt@nvidia.com> On Tue Sep 8, 2026 at 2:52 AM EDT, Tariq Toukan wrote: > From: Cosmin Ratiu > =20 > +static void accel_psp_fs_rx_reconfigure(struct mlx5e_psp_fs *fs, > + bool decap_wanted) > +{ > + bool decap_supported =3D > + MLX5_CAP_FLOWTABLE(fs->mdev, > + flow_table_properties_nic_receive.reformat_del_psp_transport); not for this series, but this makes me think having some way of letting the user know whether or not psp with hw gro is enabled would be nice, so that they don't wonder why stuff isn't coalescing when they have old fw like I do :) I could see a similar thing being useful for gso features if the psp device can't segment something that it otherwise can for non-psp. > + bool decap_enable =3D decap_wanted && decap_supported; > + struct mlx5_flow_destination dest =3D {}; > + int err; > + > + if (decap_enable =3D=3D fs->decap_enabled) > + return; > + > + /* Create the decap table if needed. */ > + if (decap_enable && !fs->decap.ft) { > + err =3D accel_psp_fs_rx_decap_ft_create(fs, &fs->decap); > + if (err) > + goto out_err; > + } > + > + /* Redirect traffic to the correct table. */ > + dest.type =3D MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE; > + dest.ft =3D decap_enable ? fs->decap.ft : fs->rx.ft; > + err =3D mlx5_modify_rule_destination(fs->check.rule, &dest, NULL); > + if (err) > + goto out_err; > + > + fs->decap_enabled =3D decap_enable; > + return; > + > +out_err: > + mlx5_core_warn(fs->mdev, > + "Failed to create/modify PSP decapsulation rules (err %d), HW G= RO for PSP unavailable\n", > + err); > +}