From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Andreas Kemnade" <andreas@kemnade.info>,
<tomi.valkeinen@ideasonboard.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<kees@kernel.org>, <luca.ceresoli@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/omap: dsi: print errors with device prefix
Date: Thu, 10 Sep 2026 05:05:49 +0200 [thread overview]
Message-ID: <DLBAYH9MDSMY.NHHAKEJE7QRQ@bootlin.com> (raw)
In-Reply-To: <20260908172213.446608-1-andreas@kemnade.info>
Hello Andreas,
On Tue Sep 8, 2026 at 7:22 PM CEST, Andreas Kemnade wrote:
> There are two dsi controllers on OMAP4/5. If both are in use, messages
> without device prefix have no indication which controller they are coming
> from. That makes debugging harder.
> Replace DSSERR/DBG macros with dev_-prefixed print functions where
> the device is reliably accessible.
> Also replace function names by %s ... __func__ constructs and remove
> some debug outputs to satisfy checkpatch.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Are you aiming at doing the same cleanup in other omapdrm files? Removing
DSSDBG/DSSERR etc entirely would be nice.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-09-10 3:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 17:22 Andreas Kemnade
2026-09-10 3:05 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLBAYH9MDSMY.NHHAKEJE7QRQ@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=andreas@kemnade.info \
--cc=dri-devel@lists.freedesktop.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®