From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f41.google.com (mail-pz2-f41.google.com [74.125.228.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB74F4EDCB8 for ; Thu, 17 Sep 2026 20:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789675900; cv=none; b=YjTPdlZWIejWLq5CjJR+Cs6CSjDnY21r/LuxgxKMC+CDoMGfdtYaGUcYsvGCxcF/9bALIzHEliJzK33KSOiH1fZvyWxbQvrEMyQ16NI7KuBIvtEXTgojqhyiyEWThBB0b/lNGFk7UXQduIuqnn6li5UlUuEPkneGL49qAAD8itI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789675900; c=relaxed/simple; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ficLZlXxyMbJxTn8t6wVhM+6R1NgQ0lKMOTjfPgin4Xl22Lw2J7qYk5M3qqvrBw/fwIjx7L5ghiij1Zo3W+uZSG/bh/08rxgl/QfbOb9g6X5NUY+GNE9gjG3+AIiAEtXv1vEBuyCKVc6CoOzGhFJ9yso0hp4YvWGRCun1kz6zuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jEG1HNV1; arc=none smtp.client-ip=74.125.228.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jEG1HNV1" Received: by mail-pz2-f41.google.com with SMTP id d2e1a72fcca58-85469a34908so72014b3a.0 for ; Thu, 17 Sep 2026 13:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789675884; x=1790280684; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; b=jEG1HNV1nB356xIIlFyTqdaGPUUh9EjM/3PMbUs+3AGI4ehoP6+sJVH1PhlKRJdi74 49iLVhT9tC9NObKt7CYqbEQamlyNxL8drgZcjYZ9wTLMuI4t48nW91cDfveXf0Si7vCw 54dSWTEmPbs9HqyhwNdcIeab67Tty0F+QyFDkFaySQpj76fSQNllBZtFFvlb1jacOCR2 FmpL9hmFxdFK867OkjHeAXKI83GK8UB4CV1xuosFIQTGXxVsJUsjkAlXWhAILWlyh4HL lpFK8QRjRmw0sPKGRoO7Aa3cih6io/pYDi7ISzk1TEp/o6Wckao1szsQ3Um6dWzlqWkz 9vEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789675884; x=1790280684; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; b=EmY5XSwgjGFWPSmYUvRP5a46x3gFQ6sPyX7ZASFb3jmnIwLUtGwhZAliGbHBdA/WhX ByGDhsJiwDZlvCfkBR/PFYyutbLRlHvtkD2jZ3J5BXqasIuA46OdVpEqHI0hHLeSWYLb k9dbPZUsp9Y5OUuAJaUqYi0KLOA2vZ+Y0rKdqX7hZ6u8dRwep90eDJbIlknJcIxA2zYi CxG6PNUN9QB/6e6f8RtY9MLYDInZMzsjM9GoDizOQQj992i8a/u8AZE9rICf9tfTmDK0 4bBLiqJJIDVkP4+8DDjJI7uYlN3d7+fUrNJmOOAuRH0m1S9uV8QjWf+lHUwTKZ7ZrsPJ J+DA== X-Forwarded-Encrypted: i=1; AKwUvBy+ZE6/fXUiI/U7fPp+UPLDBLg+vjo0+PZC2ignnypmN2ruZgrfGAPXHd/gYRCL8yTxpxJdnQG2nI8pek8=@vger.kernel.org X-Gm-Message-State: AFuF++lhXK160PjIeCdDuknG73wuaGf5NtBsa3or+AH63XjqFQwlQavA yZuC4hLVsgytdrYw1s4RLL7NuIo3jj55oflKita6cYO1qITo8COfeLzn X-Gm-Gg: AYBFou2XhjE+Tawkpcb2+ToCAvvK1uWsQMvH0Evs6E0E71/g53uKovM3eJh1ajggerR pdbL895a1Qrc7D0sEdESEDlcyMWBEDQhmP+R/2rVjPwYFHN+hJeHd2cGtitDwbaPWqgzzc2yJVn R2xNWOEzMpZkLtqh2pbMl8YFYJrXwj8G2yPwuU++FontneEcM2G5r4yqSZNkg8OlQHbZ7DbwMzS Ge3TdWNDpdakFK68wBPcFkRqScxwYskQYfxuetIiaW8Yt+tHPfADvDr8ArSXFDg0pqIK80KFPWW BemK8XFlESFeDHZGmIv772hui5VGWk0sSED6EoYLelQAgozL53WEkvzomdSbohzeEhLrzRY9+ff 11piqgH9P92czEbvXFYja6pANxOxDwfjVMtrrXh7qC8PommoXreeoKkMkNM9FXXocqwwuuIDdHD EjI/1glhqF0RqFIWiBVfA94r7Kw2yDUEtk0xjFHnfey6Ko+/UXESaoxAXkkuHFKdheTZ7t1Out9 8S93HLpquzt1ZaWIRqVuDfsT+I= X-Received: by 2002:a05:6a20:cfa2:b0:3dd:5831:ef58 with SMTP id adf61e73a8af0-3dd8c456190mr204908637.15.1789675883461; Thu, 17 Sep 2026 13:11:23 -0700 (PDT) Received: from localhost ([13.93.150.60]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14395d13ee7sm16211287c88.8.2026.09.17.13.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 13:11:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 17 Sep 2026 20:11:18 +0000 Message-Id: Cc: "David Ahern" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Randy Dunlap" , , "Arun Ajith S" , "Roopa Prabhu" , "Jaehee Park" , "Jonathan Corbet" , "Shuah Khan" , "Shuah Khan" , , , , "Alexander Aring" , , Subject: Re: [PATCH net-next v2 1/2] ipv6: update NUD_FAILED neighbors from NA messages From: "Lawrence Lee" To: "Ido Schimmel" X-Mailer: aerc 0.17.0 References: <6596966f734f3d416bfa83722f7a595149bcc3f8.1789448374.git.lfqlee314@gmail.com> <20260916120202.GA935660@shredder> <20260917143750.GA1332286@shredder> In-Reply-To: <20260917143750.GA1332286@shredder> On Thu Sep 17, 2026 at 2:37 PM UTC, Ido Schimmel wrote: > On Wed, Sep 16, 2026 at 05:43:11PM +0000, Lawrence Lee wrote: > > I added the lowpan changes after my local Sashiko review run=20 > > identified an issue where a FAILED neighbor can retain an outdated=20 > > private short address if it's moved to STALE by a non-override NA.=20 > > Happy to drop all lowpan-related changes or update comments/commit=20 > > message to reflect the changes, please let me know your preference. > > And if the entry is INCOMPLETE and we get a non-override NA? > lowpan_ndisc_update() will ignore it. It's a pre-existing issue and > there is a TODO comment about this: > > "/* react on overrides only. TODO check if this is really right. */" > > You can mention that it's a pre-existing issue under the '---'. That > way, hopefully, Sashiko will not flag it and it won't clutter the git > log. > > > This was added in response to another Sashiko local review finding. =20 > > Let's say we have some FAILED neighbor T with NTF_ROUTER set. If we=20 > > get an NA from source address S with target address T and with the=20 > > Router bit clear, existing kernel code will cleanup routes with=20 > > gateway S, but IMO we should clean routes with gateway T instead=20 > > since that is the neighbor which was updated by the NA. I can either=20 > > update comments/commit message to reflect this or remove the change=20 > > entirely, please let me know your preference. > > And if the neighbour was in a different state than FAILED? It seems like > another pre-existing issue. I guess that in practice, most of the time, > the source address of the NA is also the target address in the payload. > You can mention this under the '---'. I will remove both of these changes, add comments below the '---' as=20 suggested, and resubmit.