From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A15C345EB7 for ; Fri, 18 Sep 2026 00:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789691711; cv=none; b=b2lhiH3DotQ7QHoh8xBFghbIfSLcrJtKWy+gkJRd/qp/TkIa/DsUzae9mbEpzHcR42QhPLRR8xFyOraxIfQe0HB8C4CND3zzS6HnyVWdLAFmxbiR27HY9nEFgIspIHxSNuHu9iaBoJQk13cmgaNQcllTuSAC40Xs/lvOiQKolgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789691711; c=relaxed/simple; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=OE0aluOJKdz9o1+e2DJyRnS2MT0FepEgvwYDldrLroCfvbir01BhwtHLHATHKK2MQ6DRfld9Uv5vmOTMek2RXFunUBXoqZDdcEZEEboaAaHHi0zhbcHGRH43Y+QFJqYRQDNju30xLRunMY2vJGifLj4ZlKfRsNYX17XXZICbjTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b=g5frHq5i; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b="g5frHq5i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789691702; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; b=g5frHq5iolSfhZmMT1S+3FKrIYFMmLUvGiIXBDitA8INAs4gwmSKvWPoJO+WDpb6z8JX4MxqX hxcczVcils9C8wzRGU8weDzfrhV/6NOvJKq6TWVV2HP1FlGb7PMONOJIXrTYJyjBRlcy33F2Gcu f9fpuJ5IzldaEB+PDjBp383WuIYR8RjED63ma3p02k+xy4BebkbufLlmhuqB00NjuBYLiOA/Gqn WaSjR4AbRalGjLvLW88dW2ErzJhCgFGAv00+uf+P/nE8VYe0tOWkpDWw3qtYsA0bqH05odCSCof P7q31N3Tu7847u0RIxS1e/RI8btpQZPsBNctW8nUZ95w== X-Forward-Email-ID: 6aac871042fb3e762f6d18f9 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Thu, 17 Sep 2026 20:34:18 -0400 Message-Id: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: "Joshua Peisach" To: "Krzysztof Kozlowski" , "Michal Wilczynski" Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" , , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , "Joshua Peisach" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >>=20 >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >>=20 >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > I commented on v3 saying that I would test if I could. I don't just throw "Reviewed-by" on everything I look at. If anything, I've been trying to be more honest in reviews, and only review ones that I actually care about[1]. If reviewing patches isn't a good way for newbies to start getting familiar with the kernel code (especially a NEW driver), then I don't know what is. And to be clear, I'm not using a LLM to review. I am using actual intelligence. For the JH7110 PR specifically, I did actually go through and review each commit, because I wanted to learn what was happening and why. Actually, that's why I asked where the data sheet was[2]. So if you really want to, drop the Reviewed-by tag. And if it makes you feel better, I'll leave the series alone. -Josh [1] I won't be reviewing PRs around devicetree since I'm not confident (or frankly, interested) in it at this point. https://lore.kernel.org/all/D= L94TU52KBMO.2HAKJMJXV2CPE@ubuntu.com/ [2] Michal giving me the hardware info: https://lore.kernel.org/all/071901ef-57f3-456f-af5b-a8c99a0a7dd3@samsung.co= m/