From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CD3377A9B for ; Fri, 18 Sep 2026 09:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789723460; cv=none; b=VH0Lvj4wLztu6FwZND4x1kvbaE3YjV8bnO2Hun3BdqgI6wOw+OzVDfIpPqebG3lBtbvzPSvo2iE+GjEB/FC/k37dGcZr9njcFo+eO+6/HoJT20oW+ONOqE270vp/UPFwFW/LANno7wDe+y6WpXNXtB5g4O2z1KbE4GBJbGc3qFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789723460; c=relaxed/simple; bh=Qm7bjiKhFqbIFmiNskPuXrImM93JStnXHBKSIQsraOg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=CWchEjjQlBtIPQBsBojJSWZoDzPuyQcoBslrbsvYOYkOm2s34G19YTTkh11PHfXOjMGD0Gze56VxPdZ9WVn/+Kw8Nmk3iyYgnN1bCnAKxSmqYP++E3mTMatmcYLiB+Tv6gecZ812HYWe3PCP2Z/Gq0txv+MsZtZCbHiXEfwO9Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=LMJK0OLM; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="LMJK0OLM" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b912e4b11so2728005e9.3 for ; Fri, 18 Sep 2026 02:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789723456; x=1790328256; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Qm7bjiKhFqbIFmiNskPuXrImM93JStnXHBKSIQsraOg=; b=LMJK0OLMidDI3v6RZkuK1KA2UxQgmPg34zBLfv/cahiohQyf5z52b9OgiTHQQAiwrA m/9E8aD0Fuv2/xPZYSLGRd0qz9zl9Wqgzi8tlKLEuwsOiFioVouX/kSqMrGQ3k8hgVBu JfWuIvTg6+HRlHckPWBQ29Wj76hcOnsvZnImoaaNVDGQnJ2ZZkFrVk2hNugo5KKrVGcK rFJvxypj9ypvpeMyw+VIp0RqqFG+6Y37Ez2FT7Sp52fu4I1I9xQXEx6Pf2N2ghrogUTj BowrxxUiCkd5LhYPdfJlgAiVGvU9ek+jih4bGfvxrg5gThQxTGNKeqnF+VCaMQvTyAB9 Ykjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789723456; x=1790328256; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Qm7bjiKhFqbIFmiNskPuXrImM93JStnXHBKSIQsraOg=; b=FUJqgV7b7V8Y4UXKB3Nbx7RXOEdVMs3evqZDtBKpYLCV2CDceAH8M3xteC4cO2qYvf QN5OuBgrYE1VLY1pnub2yc1fHDZIR28T0tUpIYixHwj0tWpw4qx0/MIcRyYeWd4Bzhti ISCwuSlwh+XV6aqYP9XreeS9BFNRM3F38vexLuyZiO+nl5kxqZgpnj8sj/RyiTU8xj++ vSDMmkM1Bups6a86iEXDo73fYUvwNNOHvUJ6+A4x5Tpa/yYc9yB3oo6DFKFzsCIPdB15 FQvXcuukxmj1mqohJ9gGoMgNUYriJYXF2EydpChlGOixZpyV0sJptOoSeLYzTN9E4i5A 2QOw== X-Forwarded-Encrypted: i=1; AKwUvBwM+x7nAYncpihOfs/e7l+EL32QKIRfZhccN002IrcWLFiXXzOfcUDoEUOny0h6ql1yI5s8kr/kHp5hV/0=@vger.kernel.org X-Gm-Message-State: AFuF++kvTlV1eD4+pelN0V6gBec6EmuWt3jvBKxEoQxkMuKhX9gNWpfn NLiK6iYwCoUOn64/Yya8cJd9/2/gE76Jg8NLGhzMGIEHxrgB8SJFXy9SoWYnT5EKCxA= X-Gm-Gg: AYBFou06gmNAJX5uu4NkpL49xhbMCBn/qGpJqNGV0TUzUvsDVhgttCCFYIC7NnE+jj2 3XS4E1SIJvGIIPw9/83uM4BFOAa2xG3g+V5jmgJzpnRxk2+gCqP/NZfArMjTVe6Ed8B9bg2BBln ka53zrHjKK0BJSWCqG1npIJwOnnBKl2CupfYs3MDNXot40mT2Rr0rKaVCLBJ8ngbLSxU7CnZGpr Z5+t37c4p1quSlxlevBhshV0Sv4iVOiqMQ//UcOqBYE16HaMl9i4vY0YB7IPTQwqy/KhYMKpsDo 9TrbNesEtJZDmW8U4F7F3cO4Z9uj/0GZ/WjVoxZB6qt86+wZbELVYA7ozbYmOsbiuInUehhrFk3 yot7+memGHnUQvNS3lle0NIFEdVDJcgEJai1K7m3xZsia6JlOK2SAArgVkgZRlJJrGNwV2pQ4+a MqoF9yj1czINoJliN9rCypu6pF8gSZoaBGILavk8IbfD+hSQl7XnfSc6LUUkFiWAth X-Received: by 2002:a05:600c:19d1:b0:49c:fc6e:a3d6 with SMTP id 5b1f17b1804b1-49fc574ef3cmr20370365e9.21.1789723456007; Fri, 18 Sep 2026 02:24:16 -0700 (PDT) Received: from localhost ([2001:4090:a244:8223:c4e6:4d28:61c:74bb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fc7ce03e7sm43132485e9.3.2026.09.18.02.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 02:24:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=493b123f8147839c0c2aaec039714385462bec8d85bf63ca694b6cf1d34d; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Fri, 18 Sep 2026 11:24:09 +0200 Message-Id: Cc: , Subject: Re: [PATCH] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call From: "Markus Schneider-Pargmann" To: "Joshua Crofts" , "Markus Schneider-Pargmann" , "Marc Kleine-Budde" , "Vincent Mailhol" X-Mailer: aerc 0.21.0-146-gb5c16ebe1835 References: <20260916124236.1389-1-joshua.crofts1@gmail.com> In-Reply-To: <20260916124236.1389-1-joshua.crofts1@gmail.com> --493b123f8147839c0c2aaec039714385462bec8d85bf63ca694b6cf1d34d Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Joshua, On Wed Sep 16, 2026 at 2:42 PM CEST, Joshua Crofts wrote: > m_can_pci_remove() forgets to call pm_runtime_dont_use_autosuspend() on > teardown, even though autosuspend is enabled in m_can_pci_probe(). > > Add the missing function call. > Can you please add a Fixes: tag? > Signed-off-by: Joshua Crofts After that it looks good to me: Acked-by: Markus Schneider-Pargmann Best Markus --493b123f8147839c0c2aaec039714385462bec8d85bf63ca694b6cf1d34d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKMEABYKAEsWIQSJYVVm/x+5xmOiprOFwVZpkBVKUwUCaq0DORsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIRHG1zcEBiYXlsaWJyZS5jb20ACgkQhcFWaZAVSlP6 wAEAlbqVje7vDQ6PkvR3bLgVahwVoaHyE3uBno9sF8mhjf8BAOI7P2SACAlwIUSF 1cmXTEydsjoErRK2ZYT9NAYgiqYE =c5vM -----END PGP SIGNATURE----- --493b123f8147839c0c2aaec039714385462bec8d85bf63ca694b6cf1d34d--