From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDF633D512 for ; Fri, 18 Sep 2026 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789745590; cv=none; b=g3L6FxIguY21jNF0Ds9Tbil0G7DGMAgXdYFrfJIu3p5jvGHwZkQSO6RBRJ/E7ARMAqJT/4oJHPezM6tggNx8xMPqvuL7edaamMqea/9adL2sTxieVmwWcrNFFC6s7ZsTvMiAP2WjxMgoOK3fa4+sDehZZL5djq3FrEUsX3x8kKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789745590; c=relaxed/simple; bh=L1WiWMmX3DsfOI8wyFB2zH02SO5nVuyZ3sk5usay3Fs=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=lc6v9gHG9VU6OMvfJZVEEY/v6YuO1W2l1p3fUs/s6s8UmFIlgVajKC+eDVvuSHzqp8eOEx8z+AmAUKrsxl9nLwOpzgBe94O9CWhx8FzACxvxZb0xI/HsmMhklGUaMnombExPJGh+rRYKM8YJgbX8rtPu881a4+4U7Cp284dxm70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b=iIx8a7Ut; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b="iIx8a7Ut" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: To: From: Subject: Cc: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789745581; bh=WtQrZyaQlO+mtHmYw2SBSJxPWTjmzlVgI7Rp9b5tPg4=; b=iIx8a7UtQBnm9gk6rLQHK0IUP3MEaoFE5+A0iE1FZueL+yr1EdEjZZG5gNeo72rdjLqA7RPLA DT6Sy8qrFDXjLMYjX/Xz8N3w9KEH5Ud1spbKQL96L2DnXKdsFoxMWc6Np6/PT/+XdET+tivv0Q/ ki5rFerHi9c+bb7n8GhL7LV7lTWjOl9ug40MZ3CIyRAZnXY7wHfELQOVFOKgzOszuMctguMgVSp FBwclqPn8c1wAdm3NqBXJBfIOTin6fR/v/gan9uujMT3jhTgYPj/5NWPaUU8mOnmUw0VcRvaCOF DKM6VZyP/9AXqQgCnJWWKSzl2VR9I2Z1yq4OvYs0MJCA== X-Forward-Email-ID: 6aad59a12df78bc22ddeff38 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Fri, 18 Sep 2026 11:32:45 -0400 Message-Id: Cc: , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Subject: Re: [PATCH v4 00/20] drm: starfive: jh7110: Enable display subsystem From: "Joshua Peisach" To: "Michal Wilczynski" , "Joshua Peisach" , "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <136d6789-2f0c-4a91-ab2d-de3a3f119d5d@samsung.com> In-Reply-To: <136d6789-2f0c-4a91-ab2d-de3a3f119d5d@samsung.com> On Thu Sep 17, 2026 at 1:22 PM EDT, Michal Wilczynski wrote: > > > On 9/16/26 02:45, Joshua Peisach wrote: >> On Tue Sep 15, 2026 at 11:32 AM EDT, Michal Wilczynski wrote: >>> >>> Testing >>> =3D=3D=3D=3D=3D=3D=3D >>> >>> Tested on a VisionFive 2 v1.3B using modetest. >>=20 >> I.. got nothing. I did have to manually modprobe the modules, but >> unless I am doing something wrong.. I didn't get anything and modetest >> just gave -2. > > Hmm have you also changed the DTB not just the kernel and the modules > (you can also built in everything). > Yes (I didn't built-in everything, but I did make sure the DTB was copied and flash-kernel was run) > Also note modetest needs -M verisilicon. > "failed to open device 'versilicon' with busid '(null)': No such file or directory" > If that is not it, could you send "dmesg | grep -iE > 'verisilicon|inno|hdmi|vout'" and "ls /sys/class/drm/"? > the dmesg output: [ 0.090950] /soc/display-subsystem@29400000/hdmi@29590000/controller: Fi= xed dependency cycle(s) with /soc/display-subsystem@29400000/display@294000= 00 [ 0.091029] /soc/display-subsystem@29400000/display@29400000: Fixed depe= ndency cycle(s) with /soc/display-subsystem@29400000/hdmi@29590000/controll= er [ 0.104227] /hdmi-connector: Fixed dependency cycle(s) with /soc/display= -subsystem@29400000/hdmi@29590000/controller [ 0.104272] /soc/display-subsystem@29400000/hdmi@29590000/controller: Fi= xed dependency cycle(s) with /hdmi-connector /sys/class/drm only contains the file "version" -Josh >>=20 >>> --- >>> Michal Wilczynski (20): >>> dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy >>> dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-contr= oller >>> dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem >>> dt-bindings: soc: starfive: Add starfive,jh7110-vout-syscon >>> dt-bindings: display: verisilicon: Add starfive,jh7110-dc8200 >>> dt-bindings: soc: starfive: Add starfive,jh7110-vout-subsystem >>> drm/bridge: inno-hdmi: Split probe out of bind >>> drm/bridge: inno-hdmi: Allow the register map to come from a pare= nt >>> drm/bridge: inno-hdmi: Add .disable platform operation >>> drm/bridge: inno-hdmi: Add .mode_valid platform operation >>> drm/bridge: inno-hdmi: Make the PHY configuration table optional >>> soc: starfive: Add jh7110-hdmi-subsystem driver >>> soc: starfive: Add jh7110-vout-subsystem driver >>> clk: starfive: jh7110-vout: Allow pixel clock rate propagation >>> drm/bridge: starfive: Add JH7110 HDMI controller driver >>> phy: Add common Innosilicon HDMI PHY helpers >>> phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers >>> phy: starfive: Add jh7110-inno-hdmi-phy driver >>> riscv: dts: starfive: jh7110: Update DT for display subsystem >>> MAINTAINERS: Add StarFive JH7110 display subsystem entry >>> >>> .../starfive,jh7110-inno-hdmi-controller.yaml | 121 +++++ >>> .../bindings/display/verisilicon,dc.yaml | 1 + >>> .../mfd/starfive,jh7110-hdmi-subsystem.yaml | 95 ++++ >>> .../phy/starfive,jh7110-inno-hdmi-phy.yaml | 49 ++ >>> .../soc/starfive/starfive,jh7110-syscon.yaml | 1 + >>> .../starfive/starfive,jh7110-vout-subsystem.yaml | 218 ++++++++ >>> MAINTAINERS | 13 + >>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 121 ++++- >>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 105 +++- >>> drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 +- >>> drivers/gpu/drm/bridge/Kconfig | 11 + >>> drivers/gpu/drm/bridge/Makefile | 1 + >>> drivers/gpu/drm/bridge/inno-hdmi.c | 112 +++- >>> drivers/gpu/drm/bridge/jh7110-inno-hdmi.c | 297 +++++++++++ >>> drivers/phy/Kconfig | 8 + >>> drivers/phy/Makefile | 1 + >>> drivers/phy/phy-inno-hdmi.c | 298 +++++++++++ >>> drivers/phy/rockchip/Kconfig | 1 + >>> drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 168 +----- >>> drivers/phy/starfive/Kconfig | 20 + >>> drivers/phy/starfive/Makefile | 1 + >>> drivers/phy/starfive/phy-jh7110-inno-hdmi.c | 579 +++++++++++++= ++++++++ >>> drivers/soc/Kconfig | 1 + >>> drivers/soc/Makefile | 1 + >>> drivers/soc/starfive/Kconfig | 43 ++ >>> drivers/soc/starfive/Makefile | 3 + >>> drivers/soc/starfive/jh7110-hdmi-subsystem.c | 73 +++ >>> drivers/soc/starfive/jh7110-vout-subsystem.c | 82 +++ >>> include/drm/bridge/inno_hdmi.h | 10 +- >>> include/linux/phy/inno-hdmi-phy.h | 85 +++ >>> 30 files changed, 2337 insertions(+), 188 deletions(-) >>> --- >>> base-commit: fd73f4a6659897191fa0d40695fe370925dd3780 >>> change-id: 20251031-jh7110-clean-send-7d2242118026 >>> >>> Best regards, >>=20 >> By the way, something weird happenined while I applied the patches >> using git am. Somehow, some were out of order. The 10th patch >> adding .mode_valid tried to be applied before .disable even though >> in the series, the order is correctly set? git would obviously >> fail because the .disable entry did not exist in the header, so I had >> to manually put those in. >>=20 >> I guess it's possible that something went wrong here? I personally >> pulled the mailbox from the lore.kernel.org mbox.gz file. > > I would recommend using b4 shazam instead > >>=20 > > Best regards,