From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "김우석[학생](전자정보대학 전자공학과)" <5mghybrid@khu.ac.kr>
Cc: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<conor.dooley@microchip.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<richardcochran@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net RESEND 1/2] net: macb: Preserve one-step mode on rejected timestamp requests
Date: Mon, 21 Sep 2026 20:16:57 +0200 [thread overview]
Message-ID: <DLL782VNNCCH.1JND0AEPMQ462@bootlin.com> (raw)
In-Reply-To: <CAH1Bc_yDpY1q3yLH5R+fbr_3=LicRv-qsrcPQYspZHz095TVxg@mail.gmail.com>
Hello 김우석,
On Mon Sep 21, 2026 at 5:48 PM CEST, 김우석 wrote:
> Thanks for explaining the approach.
No worries, doing it especially as you are new according to the lore
mailing list history. Welcome!
> I found both issues while validating hardware timestamp configuration
> on the Raspberry Pi 5's Ethernet interface for my research. I reproduced
> them on the board and tested both fixes there, as described in the
> cover letter. These were hardware-verified failures, rather than
> cleanup based only on source inspection.
Great news. Nowadays the difference between "LLM found an issue through
static analysis, generated bugfix and sent it" versus "someone had a
real issue and fixed it with the LLM help" is hard to tell, and the
first approach is sadly more common.
> I've already applied the fixes locally on my Pi, so there is no
> immediate urgency on my side. That said, the structure you suggested
> looks like a cleaner way to handle the configuration path overall, and
> I think it makes sense to take this opportunity to rework it in that
> direction rather than keep the changes limited to the current fixes.
>
> Rather than posting a v2 limited to the current two fixes, I'll prepare
> a new series that refactors gem_set_hwtst() along those lines and
> incorporates both fixes. I'll link back to this series for context and
> validate the reworked path on the Pi 5.
Perfect. Make sure to fix your SoB: we require real names in the kernel
and kimwooseok looks more like a username.
Side tangent: I wouldn't be surprised if you were even allowed to use
Hanguls if you preferred. Though there isn't a large precedent, I hope
we can assume (1) systems have full unicode range support and (2) no
one expects a name to always be firstname + lastname.
⟩ git log torvalds/master | grep -a -P 'Signed-of.*\p{Hangul}'
Signed-off-by: 이상호 <...@gmail.com>
Signed-off-by: 배석진 <...@samsung.com>
My own "é" never caused much trouble.
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-21 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 8:04 [PATCH net RESEND 0/2] net: macb: Fix PTP timestamp configuration handling kimwooseok
2026-09-11 8:04 ` [PATCH net RESEND 1/2] net: macb: Preserve one-step mode on rejected timestamp requests kimwooseok
2026-09-11 9:51 ` Nicolai Buchwitz
2026-09-15 8:38 ` Paolo Abeni
2026-09-15 11:47 ` kimwooseok
2026-09-20 9:04 ` 김우석[학생](전자정보대학 전자공학과)
2026-09-21 13:11 ` Théo Lebrun
2026-09-21 15:48 ` 김우석[학생](전자정보대학 전자공학과)
2026-09-21 18:16 ` Théo Lebrun [this message]
2026-09-11 8:04 ` [PATCH net RESEND 2/2] net: macb: Use all-frame timestamping for PTPv1 RX filters kimwooseok
2026-09-11 9:55 ` Nicolai Buchwitz
2026-09-15 8:38 ` Paolo Abeni
2026-09-15 11:48 ` kimwooseok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLL782VNNCCH.1JND0AEPMQ462@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=5mghybrid@khu.ac.kr \
--cc=andrew+netdev@lunn.ch \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®