From: "Abdurrahman Hussain" <abdurrahman@nexthop.ai>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Abdurrahman Hussain" <abdurrahman@nexthop.ai>
Cc: "Michal Simek" <michal.simek@amd.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] i2c: xiic: restore non-managed runtime PM to fix clk WARN flood
Date: Mon, 21 Sep 2026 11:32:13 -0700 [thread overview]
Message-ID: <DLL7JS0LKL6X.1F7SU76VO5XVK@nexthop.ai> (raw)
In-Reply-To: <aqJQ8Qm_nhBaWR-s@ashevche-desk.local>
On Wed Sep 9, 2026 at 11:40 PM PDT, Andy Shevchenko wrote:
> On Wed, Sep 09, 2026 at 08:51:33PM -0700, Abdurrahman Hussain wrote:
>> On Fri Aug 21, 2026 at 6:12 PM PDT, Abdurrahman Hussain wrote:
>
>> Gentle ping on this one. It has been quiet since v7 went out on Aug 21.
>>
>> Andy, v4 onwards switched to request_threaded_irq()/free_irq() with the
>> explicit free in the probe error path and in remove(), per your comment on
>> v3. Does that address your concern, or is there anything else you would
>> like changed?
>
> Seems okay to me.
>
>> Andi, this is a regression fix for 50c63491ff26 (the devres conversion),
>> and the WARN fires on every unbind/rmmod of the driver, so it would be
>> good to get it into 7.2 or early 7.3 fixes if the patch looks OK to you.
>
> v7.2 is already released, so v7.3-rcX is the best you can get.
>
>> Happy to respin if anything is still open.
Andi, ping on this one.
It is a regression from my own 50c63491ff26 ("i2c: xiic: switch to
devres managed APIs"), which landed in v7.1, so both v7.1 and v7.2 WARN
on every unbind/rmmod of the driver. Andy was happy with v7 [1].
Could you take it for 7.3 fixes?
Abdurrahman
prev parent reply other threads:[~2026-09-21 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 1:12 Abdurrahman Hussain
2026-09-10 3:51 ` Abdurrahman Hussain
2026-09-10 6:40 ` Andy Shevchenko
2026-09-21 18:32 ` Abdurrahman Hussain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLL7JS0LKL6X.1F7SU76VO5XVK@nexthop.ai \
--to=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®