From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102D530568B; Tue, 22 Sep 2026 08:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790064496; cv=none; b=Y/fok7f92SzOD02fycHRLtYQ6cCQ+M8vfUYh/aZydeLxSz54QtggfOunzXS5MVPynDUwpUgqu4GeaYa3uGJndlomMIyodv3+l31tif1GVXXpSbZ4x16LC5YieUCUdlfY2DwkzPgwePHVqc7Vm+QoZcY5GnbDYkxd7b+3iuNKXhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790064496; c=relaxed/simple; bh=zcp8tcZsfdsmxUcen5sJupr/nyZnxY5fTXf1NQWKnsw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=VuJ2wrTAG5vTyrYAo0DOJn+QEXMFyoKSreJ4tDLIUqWNq039HOphUdHO/TsHJxvU8p4GaQtvCisE/Z267ISuSrkfhKHIJ/BpDHS9EHOqLbT82ZaaSVgmj5MSQK4OCyos8wI1ukUXEGc6t7iKagfyNOdTFCtMc9gBY1gYtyxc4AQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=FGUyk9MH; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FGUyk9MH" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7663D1A0FBC; Tue, 22 Sep 2026 08:08:01 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 468C860580; Tue, 22 Sep 2026 08:08:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4056C1032925B; Tue, 22 Sep 2026 10:07:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790064477; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=zcp8tcZsfdsmxUcen5sJupr/nyZnxY5fTXf1NQWKnsw=; b=FGUyk9MHJzJ0m0z8YAThEo2DOBHDLTsuC25rLZr2qIfJay2Q0I+gVCvTxsv2nvY/dDnJb9 IgXAUJLDLFyWtCu0gq4m+hX3dLL+xecsNJ8WJa5QPeWS1Zy6AUoS89OPdFALC8X5Qo/SYt P+8Axb3+Z77DYvypZw+Bo1A5RcA0P5rB/gomubC1yCw1+sui5hmFk5wLv6D9zSGNbH/9I3 BDo6gZcaNWSmUaB3MSGwrUc50FkG95rYvnEytrHx7tFcZXjfqgUddfJurME6kZVkekBte7 SOpxzk5wN3ckVBb+KRlg6NycfNY3+6MfShb4b9lHPUZw9BG8DyTys0vA4UWL/w== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 22 Sep 2026 10:07:36 +0200 Message-Id: Subject: Re: [PATCH v3 19/19] drm/bridge: analogix_dp: don't create a panel_bridge Cc: "Albert Esteve" , "Anusha Srivatsa" , "Dmitry Baryshkov" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , , , , , , , , , , , "Heiko Stuebner" To: "Damon Ding" , "Luca Ceresoli" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jessica Zhang" , "Laurentiu Palcu" , "Lucas Stach" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Paul Cercueil" , "Paul Kocialkowski" , "Linus Walleij" , "Inki Dae" , "Jagan Teki" , "Marek Szyprowski" , "Sean Paul" , "Jonathan Corbet" , "Shuah Khan" , "Randy Dunlap" From: "Luca Ceresoli" X-Mailer: aerc 0.22.0 References: <20260916-drm-bridge-every-panel-v3-0-83afb4f1a707@bootlin.com> <20260916-drm-bridge-every-panel-v3-19-83afb4f1a707@bootlin.com> <975a4d45-9a61-4858-b498-8bc0a1e44746@rock-chips.com> <96882735-091f-49c6-a47b-5da8be711818@rock-chips.com> In-Reply-To: <96882735-091f-49c6-a47b-5da8be711818@rock-chips.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Damon, On Mon Sep 21, 2026 at 8:34 AM CEST, Damon Ding wrote: > On 9/21/2026 11:07 AM, Damon Ding wrote: >> Hi Luca, >> >> On 9/16/2026 9:45 PM, Luca Ceresoli wrote: >>> Now a panel_bridge is automatically created for every drm_panel and the >>> panel-bridge API is just a deprecated wrapper to access it. >>> >>> Update and simplify the code by just getting a reference to the >>> already-existing bridge using of_drm_get_bridge_by_endpoint(). >>> >>> As of_drm_get_bridge_by_endpoint() returns a refcounted bridge, take ca= re >>> of putting the bridge reference. This is not easily done in the remove >>> path >>> due to the different probe paths of the user drivers, so add a devm >>> action >>> to ensure the reference is put only when it was taken. >>> >>> Assisted-by: opencode:deepseek-v4-flash-0731 >>> Signed-off-by: Luca Ceresoli >>> --- >>> =C2=A0 drivers/gpu/drm/bridge/analogix/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 - >>> =C2=A0 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 40 ++++++++= ++++ >>> +--------- >>> =C2=A0 drivers/gpu/drm/exynos/exynos_dp.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 36 + >>> +----------------- >>> =C2=A0 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c=C2=A0=C2=A0=C2= =A0 |=C2=A0 9 ----- >>> =C2=A0 include/drm/bridge/analogix_dp.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 1 - >>> =C2=A0 5 files changed, 25 insertions(+), 62 deletions(-) >>> > > [snip] > >>> @@ -488,14 +487,6 @@ static void rockchip_dp_remove(struct >>> platform_device *pdev) >>> =C2=A0 { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct rockchip_dp_device *dp =3D platfo= rm_get_drvdata(pdev); > > The above unused &rockchip_dp_device could be also remved. Ah, indeed! I guess I can keep your review tags if applying this patch with only this line removed. Correct? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com