mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sandie Cao" <sandie.cao@deepcomputing.io>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Yixun Lan" <dlan@kernel.org>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Wed, 23 Sep 2026 15:02:12 +0800	[thread overview]
Message-ID: <DLMI4JHT5Q8L.2MHI30VCCP3W9@linux.spacemit.com> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.2bcc8e57.b8bf.421b.9230.3eea00252952@feishu.cn>

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Wed, Sep 23, 2026 at 02:35:20PM +0800, Sandie Cao wrote:
> FML13V05 SD card slot is inside the board, it doesn't need cd-gpio,
> FML13V05 Keeps GPIO88 to low, Then SD card is always on for SD Card
> driver.

An internal slot does not necessarily mean the card is non-removable.
I don't think its location alone justifies keeping card detect asserted:
GPIO88 would report a card present even when the slot is empty.

> We check the vmmc-supply is p3v3. We have the same SDK DTS config with
> k3_com260[1] , so, this patch follows the SD card patch of k3_com260
> dts[2].
>
> If this is not correct, we will change it.

Could you confirm from the schematics that the SD power wiring matches
CoM260 and that the card's VDD is actually connected to ALDO4? If so,
this supply reference is fine. The same SDK configuration alone does
not establish the wiring.

If the card instead uses a fixed, always-on supply with no software power
control, vmmc-supply is optional for the MMC core; it should not point to
an unrelated ALDO4 rail.

-- 
Troy Mitchell

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

  reply	other threads:[~2026-09-23  7:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 11:02 [PATCH 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
2026-09-22 11:04 ` [PATCH 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
2026-09-22 11:04 ` [PATCH 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
2026-09-23  2:18   ` Troy Mitchell
2026-09-23  4:07     ` Sandie Cao
2026-09-23  6:36       ` Troy Mitchell
2026-09-23  6:44         ` Sandie Cao
2026-09-23 17:33   ` Yao Zi
2026-09-22 11:04 ` [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
2026-09-23  2:23   ` Troy Mitchell
2026-09-23  6:35     ` Sandie Cao
2026-09-23  7:02       ` Troy Mitchell [this message]
2026-09-23  8:01         ` Sandie Cao
2026-09-23  9:13           ` Troy Mitchell
2026-09-23  9:51             ` Sandie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLMI4JHT5Q8L.2MHI30VCCP3W9@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®