From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE5D2459E1 for ; Tue, 29 Sep 2026 13:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790690134; cv=none; b=MSRShmG2tBOnUnSuJZly75d+bGosELAGCStqUBBm6CslU703FBg8Hqk3AkVwGnmHLXxv/2XbG7f/bsBHdAFPsaaBSj4q69qJfu4XT4t+35GMnEA/J2icTFTFX1AnLbIBtspm8o2dTfw6Eb0ca9dtaVWA52+9p/ABw0mQTyzH/M8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790690134; c=relaxed/simple; bh=4p28RXrT7PT8oNTwuBnUDLcaLE9T4b721BcQemIIdfA=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=EKNqI3wlLzuk8JytSSPjxPEKFRakyYIydTcKC9QN5ZYyMtmu91Hoa2ox/PZMv2oSQZ97uv5FjdSCOSSpD4jQL1r/p+xj06NUqK3bKgMSixD1BS5QEdtvhwyGbzodMf+7uKvVV888fyoqeUpkI4VjaQB4N/vur9x+5NMNdGRqy0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=neDElrUx; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="neDElrUx" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0AB8D4E410B8; Tue, 29 Sep 2026 13:55:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C5CB8601BD; Tue, 29 Sep 2026 13:55:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E57B310328C55; Tue, 29 Sep 2026 15:55:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790690127; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=pad1YA7/p08a+nzZNTwHGqME67fHB2DyZyGefFtLlR4=; b=neDElrUxzMHbbEzD7tEuaCDirSjmoOtdmCczz5vmTFvG88A0E41rKHKI0cveH/QbIZv/UF 81KWExR7SFPZZOHsEeaJu+syGvZ/s2JwBzIQYbxey6MGfwHKTaUEyrMI4d1ilCZ/iayekh def+IiKt0VPhOdSo9FNhBSvSfAv4aCrS7VJmSzyOOZhht8PUWlRec0ED6JgBrHgWq5mYRG uH1w5a5knCqKGWj+tMGAcUR7f7hiS0TS4oyn+xm/FazGZm9h20LfqnNceuyPpF2b1u0PGX Dl78CfRcCB7vZ/L9vuQh0E0Khx80g4ph78VacWcArQce5Dv4p69ej8boQx1h7w== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 29 Sep 2026 15:55:23 +0200 Message-Id: Subject: Re: [PATCH] drm/panel: select DRM_KMS_HELPER Cc: "kernelci.org bot" , "Jessica Zhang" , , To: "Sasha Levin" , "Neil Armstrong" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Luca Ceresoli" From: "Luca Ceresoli" X-Mailer: aerc 0.22.0 References: <20260929114828.3260345-1-sashal@kernel.org> In-Reply-To: <20260929114828.3260345-1-sashal@kernel.org> X-Last-TLS-Session-Version: TLSv1.3 On Tue Sep 29, 2026 at 1:48 PM CEST, Sasha Levin wrote: > Since the panel_bridge code moved into drm_panel.c, any config with > DRM built in but without the KMS helpers fails to link, for example > arc haps_hs_smp_defconfig with allnoconfig and the kselftest fragment: > > arc-elf32-ld: drivers/gpu/drm/drm_panel.o:(.rodata+0x28): undefined > reference to `drm_atomic_helper_bridge_duplicate_state' > arc-elf32-ld: drivers/gpu/drm/drm_panel.o:(.rodata+0x2c): undefined > reference to `drm_atomic_helper_bridge_destroy_state' > ... > > With DRM=3Dm, modpost fails the same way: > > ERROR: modpost: drivers/gpu/drm/drm_panel.ko: symbol > 'drm_atomic_helper_bridge_duplicate_state' undefined! > > The panel_bridge used to live in bridge/panel.c, which was part of > drm_kms_helper and was therefore only built when DRM_KMS_HELPER was > enabled. drm_panel.c is built for DRM_PANEL instead, which > DRM_PANEL_BRIDGE selects whenever DRM_BRIDGE is set, and DRM_BRIDGE > is enabled for every DRM config. Nothing on that path selects > DRM_KMS_HELPER, so the bridge and connector helpers used by the moved > code can be missing. > > The panel_bridge code in drm_panel.c is built unconditionally, so > make DRM_PANEL select DRM_KMS_HELPER. > > Reported-by: kernelci.org bot > Closes: https://d.kernelci.org/i/maestro:9ed7f4b210fa7c1d3bb109b0fcd62285= e98c5b81 > Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to drm_panel.c") > Assisted-by: LLM > Signed-off-by: Sasha Levin Reviewed-by: Luca Ceresoli Tested-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com