Re: [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

["Danilo Krummrich" <dakr@kernel.org>]

On Tue Sep 29, 2026 at 10:43 PM CEST, John Hubbard wrote:
> This is a high value thing to print, because it acts as kind of a
> bookend, showing the beginning of trying to boot up.
>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
>  drivers/gpu/nova-core/driver.rs | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
> index 291a047e4d86..96f2638d6400 100644
> --- a/drivers/gpu/nova-core/driver.rs
> +++ b/drivers/gpu/nova-core/driver.rs
> @@ -102,6 +102,8 @@ fn probe<'bound>(
>      ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
>          try_pin_init!(NovaCore {
>              _: {
> +                dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");


I'd like to keep it outside of this block, as it will transform into a field
storing a pci::DeviceEnableGuard soon.

Let's put it in its own _: {} block or before try_pin_init!().

> +
>                  pdev.enable_device_mem()?;
>                  pdev.set_master();
>              },
>
> base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
> -- 
> 2.55.0